Fix CQS signal readability-named-parameter in xplat/js/react-native-github/packages [A]

Reviewed By: javache

Differential Revision: D83719624

packages/react-native/Libraries/Network/RCTHTTPRequestHandler.h

@@ -13,7 +13,7 @@ typedef NSURLSessionConfiguration * (^NSURLSessionConfigurationProvider)(void);
  *  The block provided via this function will provide the NSURLSessionConfiguration for all HTTP requests made by the
  * app.
  */
-RCT_EXTERN void RCTSetCustomNSURLSessionConfigurationProvider(NSURLSessionConfigurationProvider);
+RCT_EXTERN void RCTSetCustomNSURLSessionConfigurationProvider(NSURLSessionConfigurationProvider /*provider*/);
 /**
  * This is the default RCTURLRequestHandler implementation for HTTP requests.
  */

packages/react-native/React/Base/RCTAssert.h

@@ -37,8 +37,13 @@ RCT_EXTERN BOOL RCTIsMainQueue(void);
   do {                            \
   } while (false)
 #endif
-RCT_EXTERN void _RCTAssertFormat(const char *, const char *, int, const char *, NSString *, ...)
-    NS_FORMAT_FUNCTION(5, 6);
+RCT_EXTERN void _RCTAssertFormat(
+    const char * /*condition*/,
+    const char * /*fileName*/,
+    int /*lineNumber*/,
+    const char * /*function*/,
+    NSString * /*format*/,
+    ...) NS_FORMAT_FUNCTION(5, 6);
 
 /**
  * Report a fatal condition when executing. These calls will _NOT_ be compiled out

packages/react-native/React/Base/RCTAssert.m

@@ -22,7 +22,7 @@ RCTAssertFunction RCTCurrentAssertFunction = nil;
 RCTFatalHandler RCTCurrentFatalHandler = nil;
 RCTFatalExceptionHandler RCTCurrentFatalExceptionHandler = nil;
 
-NSException *_RCTNotImplementedException(SEL, Class);
+NSException *_RCTNotImplementedException(SEL /*cmd*/, Class /*cls*/);
 NSException *_RCTNotImplementedException(SEL cmd, Class cls)
 {
   NSString *msg = [NSString stringWithFormat:

packages/react-native/React/Base/RCTBridge.mm

@@ -117,7 +117,7 @@ NSSet<NSString *> *getCoreModuleClasses(void)
 }
 
 static NSMutableArray<NSString *> *modulesLoadedWithOldArch;
-void addModuleLoadedWithOldArch(NSString *);
+void addModuleLoadedWithOldArch(NSString * /*moduleName*/);
 void addModuleLoadedWithOldArch(NSString *moduleName)
 {
   static dispatch_once_t onceToken;
@@ -138,7 +138,7 @@ NSMutableArray<NSString *> *getModulesLoadedWithOldArch(void)
  * prior to the first bridge initialization.
  * TODO: (T115656171) Refactor RCTRegisterModule out of Bridge.m since it doesn't use the Bridge.
  */
-void RCTRegisterModule(Class);
+void RCTRegisterModule(Class /*moduleClass*/);
 void RCTRegisterModule(Class moduleClass)
 {
   if (RCTAreLegacyLogsEnabled() && ![getCoreModuleClasses() containsObject:[moduleClass description]]) {

packages/react-native/React/Base/RCTConvert.h

@@ -177,9 +177,14 @@ typedef NSArray UIColorArray __deprecated_msg("Use NSArray<UIColor *>");
 /**
  * Underlying implementations of RCT_XXX_CONVERTER macros. Ignore these.
  */
-RCT_EXTERN NSNumber *RCTConvertEnumValue(const char *, NSDictionary *, NSNumber *, id);
-RCT_EXTERN NSNumber *RCTConvertMultiEnumValue(const char *, NSDictionary *, NSNumber *, id);
-RCT_EXTERN NSArray *RCTConvertArrayValue(SEL, id);
+RCT_EXTERN NSNumber *
+RCTConvertEnumValue(const char * /*typeName*/, NSDictionary * /*mapping*/, NSNumber * /*defaultValue*/, id /*json*/);
+RCT_EXTERN NSNumber *RCTConvertMultiEnumValue(
+    const char * /*typeName*/,
+    NSDictionary * /*mapping*/,
+    NSNumber * /*defaultValue*/,
+    id /*json*/);
+RCT_EXTERN NSArray *RCTConvertArrayValue(SEL /*type*/, id /*json*/);
 
 /**
  * This macro is used for logging conversion errors. This is just used to

packages/react-native/React/Base/RCTLog.h

@@ -75,12 +75,12 @@ RCTFormatLog(NSDate *timestamp, RCTLogLevel level, NSString *fileName, NSNumber
 /**
  * A method to generate a string RCTLogLevel
  */
-RCT_EXTERN NSString *RCTFormatLogLevel(RCTLogLevel);
+RCT_EXTERN NSString *RCTFormatLogLevel(RCTLogLevel /*level*/);
 
 /**
  * A method to generate a string from a RCTLogSource
  */
-RCT_EXTERN NSString *RCTFormatLogSource(RCTLogSource);
+RCT_EXTERN NSString *RCTFormatLogSource(RCTLogSource /*source*/);
 
 /**
  * The default logging function used by RCTLogXX.
@@ -149,5 +149,7 @@ RCT_EXTERN void RCTLogSetBridgelessCallableJSModules(RCTCallableJSModules *calla
   } while (0)
 #endif
 
-RCT_EXTERN void _RCTLogNativeInternal(RCTLogLevel, const char *, int, NSString *, ...) NS_FORMAT_FUNCTION(4, 5);
-RCT_EXTERN void _RCTLogJavaScriptInternal(RCTLogLevel, NSString *);
+RCT_EXTERN void
+_RCTLogNativeInternal(RCTLogLevel /*level*/, const char * /*fileName*/, int /*lineNumber*/, NSString * /*format*/, ...)
+    NS_FORMAT_FUNCTION(4, 5);
+RCT_EXTERN void _RCTLogJavaScriptInternal(RCTLogLevel /*level*/, NSString * /*message*/);

packages/react-native/React/Base/RCTUtils.mm

@@ -706,7 +706,7 @@ NSURL *RCTDataURL(NSString *mimeType, NSData *data)
                                                [data base64EncodedStringWithOptions:(NSDataBase64EncodingOptions)0]]];
 }
 
-BOOL RCTIsGzippedData(NSData *__nullable); // exposed for unit testing purposes
+BOOL RCTIsGzippedData(NSData *__nullable /*data*/); // exposed for unit testing purposes
 BOOL RCTIsGzippedData(NSData *__nullable data)
 {
   UInt8 *bytes = (UInt8 *)data.bytes;

packages/react-native/React/CoreModules/RCTAppearance.h

@@ -12,7 +12,7 @@
 #import <React/RCTEventEmitter.h>
 
 RCT_EXTERN void RCTEnableAppearancePreference(BOOL enabled);
-RCT_EXTERN void RCTOverrideAppearancePreference(NSString *);
+RCT_EXTERN void RCTOverrideAppearancePreference(NSString * /*colorSchemeOverride*/);
 RCT_EXTERN void RCTUseKeyWindowForSystemStyle(BOOL useMainScreen);
 RCT_EXTERN NSString *RCTCurrentOverrideAppearancePreference(void);
 RCT_EXTERN NSString *RCTColorSchemePreference(UITraitCollection *traitCollection);

packages/react-native/React/CxxBridge/RCTMessageThread.h

@@ -21,8 +21,8 @@ class RCTMessageThread : public MessageQueueThread,
  public:
   RCTMessageThread(NSRunLoop* runLoop, RCTJavaScriptCompleteBlock errorBlock);
   ~RCTMessageThread() override;
-  void runOnQueue(std::function<void()>&&) override;
-  void runOnQueueSync(std::function<void()>&&) override;
+  void runOnQueue(std::function<void()>&& /*func*/) override;
+  void runOnQueueSync(std::function<void()>&& /*func*/) override;
   void quitSynchronous() override;
   void setRunLoop(NSRunLoop* runLoop);
 

packages/react-native/React/CxxBridge/RCTObjcExecutor.mm

@@ -90,7 +90,7 @@ class RCTObjcExecutor : public JSExecutor {
                          }];
   }
 
-  void setBundleRegistry(std::unique_ptr<RAMBundleRegistry>) override
+  void setBundleRegistry(std::unique_ptr<RAMBundleRegistry> /*bundleRegistry*/) override
   {
     RCTAssert(NO, @"RAM bundles are not supported in RCTObjcExecutor");
   }

packages/react-native/React/Profiler/RCTProfile.h

@@ -43,7 +43,7 @@ RCT_EXTERN dispatch_queue_t RCTProfileGetQueue(void)
 
 RCT_EXTERN NSUInteger _RCTProfileBeginFlowEvent(void)
     __deprecated_msg("This API will be removed along with the legacy architecture.");
-RCT_EXTERN void _RCTProfileEndFlowEvent(NSUInteger)
+RCT_EXTERN void _RCTProfileEndFlowEvent(NSUInteger /*cookie*/)
     __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
@@ -55,7 +55,7 @@ RCT_EXTERN BOOL RCTProfileIsProfiling(void)
 /**
  * Start collecting profiling information
  */
-RCT_EXTERN void RCTProfileInit(RCTBridge *)
+RCT_EXTERN void RCTProfileInit(RCTBridge * /*bridge*/)
     __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
@@ -63,7 +63,7 @@ RCT_EXTERN void RCTProfileInit(RCTBridge *)
  * returned is compliant with google's trace event format - the format used
  * as input to trace-viewer
  */
-RCT_EXTERN void RCTProfileEnd(RCTBridge *, void (^)(NSString *))
+RCT_EXTERN void RCTProfileEnd(RCTBridge * /*bridge*/, void (^/*callback*/)(NSString *))
     __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
@@ -164,13 +164,13 @@ RCT_EXTERN void RCTProfileImmediateEvent(uint64_t tag, NSString *name, NSTimeInt
 /**
  * Hook into a bridge instance to log all bridge module's method calls
  */
-RCT_EXTERN void RCTProfileHookModules(RCTBridge *)
+RCT_EXTERN void RCTProfileHookModules(RCTBridge * /*bridge*/)
     __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * Unhook from a given bridge instance's modules
  */
-RCT_EXTERN void RCTProfileUnhookModules(RCTBridge *)
+RCT_EXTERN void RCTProfileUnhookModules(RCTBridge * /*bridge*/)
     __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
@@ -215,7 +215,7 @@ typedef struct {
   void (*end_async_flow)(uint64_t tag, const char *name, int cookie);
 } RCTProfileCallbacks __deprecated_msg("This API will be removed along with the legacy architecture.");
 
-RCT_EXTERN void RCTProfileRegisterCallbacks(RCTProfileCallbacks *)
+RCT_EXTERN void RCTProfileRegisterCallbacks(RCTProfileCallbacks * /*cb*/)
     __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**

packages/react-native/React/Profiler/RCTProfile.m

@@ -184,7 +184,7 @@ RCT_EXTERN void RCTProfileTrampoline(void);
 static void *RCTProfileTrampoline = NULL;
 #endif
 
-RCT_EXTERN void RCTProfileTrampolineStart(id, SEL);
+RCT_EXTERN void RCTProfileTrampolineStart(id /*self*/, SEL /*cmd*/);
 void RCTProfileTrampolineStart(id self, SEL cmd)
 {
   /**