Fix CQS signal readability-named-parameter in xplat/js/react-native-github/packages [A]

Reviewed By: javache

Differential Revision: D83703007

packages/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp

@@ -45,7 +45,10 @@ class JSIExecutor::NativeModuleProxy : public jsi::HostObject {
     return nativeModules->getModule(rt, name);
   }
 
-  void set(Runtime&, const PropNameID&, const Value&) override {
+  void set(
+      Runtime& /*unused*/,
+      const PropNameID& /*name*/,
+      const Value& /*value*/) override {
     throw std::runtime_error(
         "Unable to put on NativeModules: Operation unsupported");
   }

packages/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.h

@@ -83,7 +83,7 @@ class [[deprecated(
       std::unique_ptr<const JSBigString> script,
       std::string sourceURL) override;
 #ifndef RCT_REMOVE_LEGACY_ARCH
-  void setBundleRegistry(std::unique_ptr<RAMBundleRegistry>) override;
+  void setBundleRegistry(std::unique_ptr<RAMBundleRegistry> r) override;
 #endif // RCT_REMOVE_LEGACY_ARCH
   void registerBundle(uint32_t bundleId, const std::string& bundlePath)
       override;

packages/react-native/ReactCommon/jsinspector-modern/UniqueMonostate.h

@@ -18,22 +18,28 @@ namespace facebook::react::jsinspector_modern {
  */
 template <size_t key>
 struct UniqueMonostate {
-  constexpr bool operator==(const UniqueMonostate<key>&) const noexcept {
+  constexpr bool operator==(
+      const UniqueMonostate<key>& /*unused*/) const noexcept {
     return true;
   }
-  constexpr bool operator!=(const UniqueMonostate<key>&) const noexcept {
+  constexpr bool operator!=(
+      const UniqueMonostate<key>& /*unused*/) const noexcept {
     return false;
   }
-  constexpr bool operator<(const UniqueMonostate<key>&) const noexcept {
+  constexpr bool operator<(
+      const UniqueMonostate<key>& /*unused*/) const noexcept {
     return false;
   }
-  constexpr bool operator>(const UniqueMonostate<key>&) const noexcept {
+  constexpr bool operator>(
+      const UniqueMonostate<key>& /*unused*/) const noexcept {
     return false;
   }
-  constexpr bool operator<=(const UniqueMonostate<key>&) const noexcept {
+  constexpr bool operator<=(
+      const UniqueMonostate<key>& /*unused*/) const noexcept {
     return true;
   }
-  constexpr bool operator>=(const UniqueMonostate<key>&) const noexcept {
+  constexpr bool operator>=(
+      const UniqueMonostate<key>& /*unused*/) const noexcept {
     return true;
   }
 };
@@ -45,8 +51,8 @@ namespace std {
 template <size_t key>
 struct hash<::facebook::react::jsinspector_modern::UniqueMonostate<key>> {
   size_t operator()(
-      const ::facebook::react::jsinspector_modern::UniqueMonostate<key>&)
-      const noexcept {
+      const ::facebook::react::jsinspector_modern::UniqueMonostate<
+          key>& /*unused*/) const noexcept {
     return key;
   }
 };

packages/react-native/ReactCommon/jsinspector-modern/tests/InspectorMocks.h

@@ -175,7 +175,7 @@ class MockRuntimeAgentDelegate : public RuntimeAgentDelegate {
   inline MockRuntimeAgentDelegate(
       FrontendChannel frontendChannel,
       SessionState& sessionState,
-      std::unique_ptr<RuntimeAgentDelegate::ExportedState>,
+      std::unique_ptr<RuntimeAgentDelegate::ExportedState> /*unused*/,
       ExecutionContextDescription executionContextDescription,
       const RuntimeExecutor& /*runtimeExecutor*/)
       : frontendChannel(std::move(frontendChannel)),

packages/react-native/ReactCommon/jsinspector-modern/tests/JsiIntegrationTest.h

@@ -186,7 +186,7 @@ class JsiIntegrationPortableTestBase : public ::testing::Test,
   }
 
   void onSetPausedInDebuggerMessage(
-      const OverlaySetPausedInDebuggerMessageRequest&) override {}
+      const OverlaySetPausedInDebuggerMessageRequest& /*request*/) override {}
 };
 
 } // namespace facebook::react::jsinspector_modern

packages/react-native/ReactCommon/jsinspector-modern/tests/ReactNativeMocks.h

@@ -29,7 +29,7 @@ class MockMessageQueueThread : public react::MessageQueueThread {
   void runOnQueue(std::function<void()>&& func) override;
 
   // Unused
-  void runOnQueueSync(std::function<void()>&&) override;
+  void runOnQueueSync(std::function<void()>&& callback) override;
 
   // Unused
   void quitSynchronous() override;

packages/react-native/ReactCommon/react/bridging/Array.h

@@ -37,7 +37,7 @@ struct BridgingStatic {
       facebook::jsi::Runtime& rt,
       const T& array,
       const std::shared_ptr<CallInvoker>& jsInvoker,
-      std::index_sequence<Index...>) {
+      std::index_sequence<Index...> /*unused*/) {
     return jsi::Array::createWithElements(
         rt, bridging::toJs(rt, std::get<Index>(array), jsInvoker)...);
   }

packages/react-native/ReactCommon/react/bridging/Base.h

@@ -24,7 +24,7 @@ struct Bridging;
 template <>
 struct Bridging<void> {
   // Highly generic code may result in "casting" to void.
-  static void fromJs(jsi::Runtime&, const jsi::Value&) {}
+  static void fromJs(jsi::Runtime& /*unused*/, const jsi::Value& /*unused*/) {}
 };
 
 namespace bridging {
@@ -105,7 +105,8 @@ template <typename T>
 auto toJs(
     jsi::Runtime& rt,
     T&& value,
-    const std::shared_ptr<CallInvoker>& = nullptr) -> remove_cvref_t<T> {
+    const std::shared_ptr<CallInvoker>& /*unused*/ = nullptr)
+    -> remove_cvref_t<T> {
   return convert(rt, std::forward<T>(value));
 }
 
@@ -113,7 +114,7 @@ template <typename T>
 auto toJs(
     jsi::Runtime& rt,
     T&& value,
-    const std::shared_ptr<CallInvoker>& = nullptr)
+    const std::shared_ptr<CallInvoker>& /*unused*/ = nullptr)
     -> decltype(Bridging<bridging_t<T>>::toJs(rt, std::forward<T>(value))) {
   return Bridging<bridging_t<T>>::toJs(rt, std::forward<T>(value));
 }