Fix CQS signal readability-named-parameter in xplat/js/react-native-github/packages [B]

Reviewed By: rshest Differential Revision: D83704348
2025-11-01 09:14:26 +00:00 · 2025-10-02 01:30:41 -07:00
8 changed files with 13 additions and 11 deletions
@@ -13,7 +13,7 @@ namespace facebook::react {

 template <>
 struct Bridging<bool> {
-  static bool fromJs(jsi::Runtime&, const jsi::Value& value) {
+  static bool fromJs(jsi::Runtime& /*unused*/, const jsi::Value& value) {
    return value.asBool();
  }

@@ -86,12 +86,12 @@ JSReturnT callFromJs(
 }

 template <typename ReturnT, typename... ArgsT>
-constexpr size_t getParameterCount(ReturnT (*)(ArgsT...)) {
+constexpr size_t getParameterCount(ReturnT (* /*unused*/)(ArgsT...)) {
  return sizeof...(ArgsT);
 }

 template <typename Class, typename ReturnT, typename... ArgsT>
-constexpr size_t getParameterCount(ReturnT (Class::*)(ArgsT...)) {
+constexpr size_t getParameterCount(ReturnT (Class::* /*unused*/)(ArgsT...)) {
  return sizeof...(ArgsT);
 }

@@ -179,7 +179,8 @@ class SyncCallback<R(Args...)> {
  }

  template <size_t... Index>
-  R apply(std::tuple<Args...>&& args, std::index_sequence<Index...>) const {
+  R apply(std::tuple<Args...>&& args, std::index_sequence<Index...> /*unused*/)
+      const {
    return call(std::move(std::get<Index>(args))...);
  }

@@ -262,7 +263,7 @@ struct Bridging<std::function<R(Args...)>> {
      jsi::Runtime& rt,
      const jsi::Value* args,
      const std::shared_ptr<CallInvoker>& jsInvoker,
-      std::index_sequence<Index...>) {
+      std::index_sequence<Index...> /*unused*/) {
    return fn(bridging::fromJs<Args>(rt, args[Index], jsInvoker)...);
  }
 };
@@ -24,7 +24,7 @@ struct Bridging<std::nullptr_t> {
    }
  }

-  static std::nullptr_t toJs(jsi::Runtime&, std::nullptr_t) {
+  static std::nullptr_t toJs(jsi::Runtime& /*unused*/, std::nullptr_t) {
    return nullptr;
  }
 };
@@ -53,7 +53,8 @@ class JSI_EXPORT JavaTurboModule : public TurboModule {
 protected:
  void configureEventEmitterCallback();

-  [[deprecated]] void setEventEmitterCallback(jni::alias_ref<jobject>) {
+  [[deprecated]] void setEventEmitterCallback(
+      jni::alias_ref<jobject> /*unused*/) {
    configureEventEmitterCallback();
  }

@@ -82,8 +82,8 @@ class ParagraphAttributes : public DebugStringConvertible {
   */
  std::optional<TextAlignmentVertical> textAlignVertical{};

-  bool operator==(const ParagraphAttributes&) const;
-  bool operator!=(const ParagraphAttributes&) const;
+  bool operator==(const ParagraphAttributes& rhs) const;
+  bool operator!=(const ParagraphAttributes& rhs) const;

 #pragma mark - DebugStringConvertible

@@ -233,7 +233,7 @@ inline void fromRawValue(
 }

 inline void fromRawValue(
-    const PropsParserContext&,
+    const PropsParserContext& /*unused*/,
    const RawValue& value,
    AccessibilityValue& result) {
  auto map = (std::unordered_map<std::string, RawValue>)value;
@@ -34,7 +34,7 @@ class CSSValueParser {
  template <CSSDataType... AllowedTypesT>
  constexpr std::variant<std::monostate, AllowedTypesT...> consumeValue(
      CSSDelimiter delimeter,
-      CSSCompoundDataType<AllowedTypesT...>) {
+      CSSCompoundDataType<AllowedTypesT...> /*unused*/) {
    using ReturnT = std::variant<std::monostate, AllowedTypesT...>;

    auto consumedValue =