Intl Schedulerand Facebook GitHub Bot
c2ca91db9f
translation auto-update for Apps/Wilde/scripts/intl-config.json on master
...
Summary:
Chronos Job Instance ID: 1125907902962069
Sandcastle Job Instance ID: 22517999111494527
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46845052
fbshipit-source-id: d83c36e5ed7186b2b95883c9bb8755c11e02e7b5
2023-06-19 12:34:01 -07:00
Graham Mendick and Facebook GitHub Bot
187f16ddc6
Support Android Transitions during Fragment navigation ( #37857 )
...
Summary:
Adds support for Android Transitions during Fragment navigation.
React Native navigation libraries (like [the Navigation router](https://github.com/grahammendick/navigation/blob/e9deae985a1962db17d6b1fbf90628d20c29810c/NavigationReactNative/src/android/src/main/java/com/navigation/reactnative/NavigationStackView.java#L139 ) and [React Native Screens](https://github.com/software-mansion/react-native-screens/blob/ea240b46866d66398904d0c2d0fe5fabdc2f269b/android/src/main/java/com/swmansion/rnscreens/ScreenContainer.kt#L98 )) use Fragments to manage the stack of screens. But they can’t use Transitions to animate these Fragments because React Native images disappear during the Transition (see the videos in the Test Plan section below).
Navigation libraries are forced to [setCustomAnimations](https://developer.android.com/reference/androidx/fragment/app/FragmentTransaction.html#setCustomAnimations(int,int) ) instead of [enter and exit Transitions](https://developer.android.com/reference/android/app/Fragment#setEnterTransition(android.transition.Transition) ). But animations have limitations compared to Transitions
- Animations have to be resx files so can’t be defined declaratively in React
- Android’s Material Transforms are built around Transitions
- Native shared elements only support Transitions
Images disappearing during Transitions is [a known Fresco bug](https://github.com/facebook/fresco/issues/2512 ). This PR applies [the fix suggested by the Fresco repo](https://github.com/facebook/fresco/issues/1445#issuecomment-315763953 ).
## Changelog:
[ANDROID] [FIXED] - Support Android Transitions during Fragment navigation
Pull Request resolved: https://github.com/facebook/react-native/pull/37857
Test Plan:
I’ve created a [minimal reproduction that demonstrates the bug](https://github.com/grahammendick/image-disappears-during-transition-bug ). The first video below shows the example from that repo. You can see that the image disappears when changing the painting. It should fade out and in like the text does.
The second video shows the same example after the fix is applied. You can see that the painting fades out and in just like the text.
https://github.com/facebook/react-native/assets/1761227/6739f029-eda0-44d2-b328-a73b075bd82a
https://github.com/facebook/react-native/assets/1761227/9c73cdf0-303b-4a82-8df5-5f6a5846a58e
Reviewed By: javache
Differential Revision: D46769995
Pulled By: dmytrorykun
fbshipit-source-id: 0ced8af7b246d8c59cbfb5cabf422114c6154c65
2023-06-19 11:13:48 -07:00
Nicola Corti and Facebook GitHub Bot
9101e44615
Expose react_utils via prefab to fix broken test_android ( #37965 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37965
test_android is currently failing as we're not shipping the implementation of one of the symbol inside `react_utils`
which is now accessed by the `ConcreteComponentDescriptor.h` file (used by the app project).
Either we expose `react_utils` as a static library (.a) or as a dynamic library (.so). I've decided to go for the latter
for the sake of saving space on user devices.
Changelog:
[Internal] [Changed] - Expose react_utils via prefab to fix broken test_android
Reviewed By: sammy-SC
Differential Revision: D46841689
fbshipit-source-id: a5467ca3a7ac2f26f7a5a2c4d6e161a391766b0d
2023-06-19 10:46:51 -07:00
ankit-tailor and Facebook GitHub Bot
3d6a2a9cbd
refactor: converted NativeAnimatedInterpolationTest to kotlin ( #37960 )
...
Summary:
This PR converts [NativeAnimatedNodeTraversalTest](https://github.com/facebook/react-native/tree/main/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/animated/NativeAnimatedNodeTraversalTest.java ) into Kotlin as requested in https://github.com/facebook/react-native/issues/37708
## Changelog:
[INTERNAL] [CHANGED] - Convert `NativeAnimatedNodeTraversalTest` to Kotlin
Pull Request resolved: https://github.com/facebook/react-native/pull/37960
Test Plan:
1. Run `./gradlew :packages:react-native:ReactAndroid:test`.
2. All tests should pass.
Reviewed By: javache
Differential Revision: D46838215
Pulled By: rshest
fbshipit-source-id: 6681d74896a0c94fa7f3ad2ce79eeab4974c55f4
2023-06-19 10:34:32 -07:00
Samuel Susla and Facebook GitHub Bot
c1bfd0cda4
Re-add gating to RuntimeScheduler::Task around setNativeState ( #37597 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37597
changelog: [internal]
In https://github.com/facebook/react-native/commit/7211ef19624304b6a4d5219a8e0a2c67651b8b33 I removed use of CoreFeatures class from RuntimeScheduler to work around a circular dependency in cocoapods.
In D46218604 I resolved the circular dependency issue and this diff adds the feature flag back.
Reviewed By: javache
Differential Revision: D46218660
fbshipit-source-id: abcdd522195cd5fa979ed3a559c00e1f2d2ae23a
2023-06-19 07:58:45 -07:00
Intl Schedulerand Facebook GitHub Bot
109a8a0229
translation auto-update for Apps/Wilde/scripts/intl-config.json on master
...
Summary:
Chronos Job Instance ID: 1125907902661436
Sandcastle Job Instance ID: 9007200228784914
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46838811
fbshipit-source-id: 0f93a1cd777250ced2009781f4e055c13e4045a4
2023-06-19 05:16:00 -07:00
Intl Schedulerand Facebook GitHub Bot
a528902663
translation auto-update for i18n/barcelona.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907902554121
Sandcastle Job Instance ID: 36028797995243282
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46836681
fbshipit-source-id: 8a75c554969e294b391b65a11ca7e4ee3b02e6ce
2023-06-19 02:56:48 -07:00
Intl Schedulerand Facebook GitHub Bot
c8c9f04e11
translation auto-update for i18n/messenger.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907902554121
Sandcastle Job Instance ID: 36028797995243282
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46836676
fbshipit-source-id: 4d737023ab0d699ac119d7228469c2ca8d496c7c
2023-06-19 02:56:48 -07:00
Intl Schedulerand Facebook GitHub Bot
11010b5c74
translation auto-update for i18n/creatorstudio.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907902554121
Sandcastle Job Instance ID: 36028797995243282
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46836669
fbshipit-source-id: bd670de9fe71b4eaa354fd6d3d32aa7b84513014
2023-06-19 02:56:48 -07:00
Intl Schedulerand Facebook GitHub Bot
6edceb9155
translation auto-update for i18n/fb4a.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907902554121
Sandcastle Job Instance ID: 36028797995243282
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46836672
fbshipit-source-id: 4032fe32e9da5c2a1c57e6308a695db01c7c346c
2023-06-19 02:56:48 -07:00
Intl Schedulerand Facebook GitHub Bot
4ad086a01d
translation auto-update for i18n/talk.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907902554121
Sandcastle Job Instance ID: 36028797995243282
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46836666
fbshipit-source-id: ea301c6a87bb99ed86aa14990a8a8e213f7484c3
2023-06-19 02:56:48 -07:00
Intl Schedulerand Facebook GitHub Bot
0f39f3dd01
translation auto-update for i18n/oculus-mirage.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907902554121
Sandcastle Job Instance ID: 36028797995243282
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46836680
fbshipit-source-id: a611209750ab3e4fe80981647e35c5e6eff1ce19
2023-06-19 02:56:48 -07:00
Carmi Grushko and Facebook GitHub Bot
f6f848f9da
Update ktfmt component on FBS:master ( #37950 )
...
Differential Revision: D46802820
fbshipit-source-id: a2737658576bf86f431a7b355d853a529f6a2c34
2023-06-18 23:22:12 -07:00
Intl Schedulerand Facebook GitHub Bot
92199a727c
translation auto-update for Apps/Wilde/scripts/intl-config.json on master
...
Summary:
Chronos Job Instance ID: 1125907902463243
Sandcastle Job Instance ID: 36028797995197700
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46832154
fbshipit-source-id: 82223c908ab80deb521ee3d29c4081d56591c072
2023-06-18 21:27:06 -07:00
Intl Schedulerand Facebook GitHub Bot
a2f69158b5
translation auto-update for i18n/barcelona.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907902394694
Sandcastle Job Instance ID: 27021598738649603
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46831128
fbshipit-source-id: 3c9139c13c1ace5a5a353caf1d15cdc2c7d10fe8
2023-06-18 16:56:26 -07:00
Intl Schedulerand Facebook GitHub Bot
b2264b98d9
translation auto-update for i18n/pages-manager.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907902394694
Sandcastle Job Instance ID: 27021598738649603
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46831131
fbshipit-source-id: 64464af3f09569f990b30ed20248bcf08f27ac76
2023-06-18 16:56:26 -07:00
Intl Schedulerand Facebook GitHub Bot
7725ea60e3
translation auto-update for i18n/creatorstudio.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907902394694
Sandcastle Job Instance ID: 27021598738649603
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46831130
fbshipit-source-id: 69d04cbb97d4df569b385ea988a6d11e4a59e8ae
2023-06-18 16:56:26 -07:00
Intl Schedulerand Facebook GitHub Bot
53b721e578
translation auto-update for i18n/fb4a.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907902394694
Sandcastle Job Instance ID: 27021598738649603
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46831143
fbshipit-source-id: f9c0bf1b4d30a4165a72d877fdd4eb6ebe88a094
2023-06-18 16:56:26 -07:00
Intl Schedulerand Facebook GitHub Bot
19abfac7b2
translation auto-update for i18n/anna.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907902394694
Sandcastle Job Instance ID: 27021598738649603
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46831139
fbshipit-source-id: 81a7d7b6ad5decfb951fb486b8af68c5d011bb86
2023-06-18 16:56:26 -07:00
Intl Schedulerand Facebook GitHub Bot
564a83681c
translation auto-update for Apps/Wilde/scripts/intl-config.json on master
...
Summary:
Chronos Job Instance ID: 1125907902391870
Sandcastle Job Instance ID: 4503600603166431
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46830005
fbshipit-source-id: acd3c21501ec9a763c0ba0e3c0a185a25d9f3afd
2023-06-18 11:55:33 -07:00
Intl Schedulerand Facebook GitHub Bot
d052d5f780
translation auto-update for i18n/talk.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907902027871
Sandcastle Job Instance ID: 27021598738469361
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46828652
fbshipit-source-id: ec58fe8ebdad312609743f1674f308f18ce33891
2023-06-18 06:43:34 -07:00
Intl Schedulerand Facebook GitHub Bot
27fb8b2bca
translation auto-update for i18n/barcelona.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907902027871
Sandcastle Job Instance ID: 27021598738469361
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46828650
fbshipit-source-id: 70fd9f800fca23d727f6246d6ff659d2e8e0da51
2023-06-18 06:43:34 -07:00
Intl Schedulerand Facebook GitHub Bot
1231ab6472
translation auto-update for i18n/adsmanager.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907902027871
Sandcastle Job Instance ID: 27021598738469361
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46828645
fbshipit-source-id: 1b21b2d39dd81e00b1f572732d4849e3333910fc
2023-06-18 06:43:34 -07:00
Intl Schedulerand Facebook GitHub Bot
692458c72c
translation auto-update for i18n/pages-manager.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907902027871
Sandcastle Job Instance ID: 27021598738469361
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46828649
fbshipit-source-id: 612bf012bea257dec10d7cca83069d7c267b420b
2023-06-18 06:43:34 -07:00
Intl Schedulerand Facebook GitHub Bot
fed0be56c2
translation auto-update for Apps/Wilde/scripts/intl-config.json on master
...
Summary:
Chronos Job Instance ID: 1125907902062758
Sandcastle Job Instance ID: 18014399485519691
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46827865
fbshipit-source-id: 03cf98f93fc2fb1329079a76da30248ac8d131fd
2023-06-18 05:00:07 -07:00
Intl Schedulerand Facebook GitHub Bot
061e3245b5
translation auto-update for Apps/Wilde/scripts/intl-config.json on master
...
Summary:
Chronos Job Instance ID: 1125907901759875
Sandcastle Job Instance ID: 27021598738215434
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46823756
fbshipit-source-id: 0065c2c182c5cabf504097cc4d05fd56064663fc
2023-06-17 12:14:40 -07:00
Intl Schedulerand Facebook GitHub Bot
36b5fe0b1e
translation auto-update for i18n/talk.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907901618950
Sandcastle Job Instance ID: 13510799857052383
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46823029
fbshipit-source-id: f5e5c1480fd6b85b2b08c227b1d9913c010f1531
2023-06-17 09:29:58 -07:00
Intl Schedulerand Facebook GitHub Bot
b5b2d8d076
translation auto-update for i18n/oculus-mirage.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907901618950
Sandcastle Job Instance ID: 13510799857052383
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46823020
fbshipit-source-id: d4aa979a0e8c7090192f90ece1c6cbe738cdbbbc
2023-06-17 09:29:58 -07:00
Samuel Susla and Facebook GitHub Bot
bb879d3ecb
Move CoreFeatures to React-utils ( #37599 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37599
changelog: [internal]
Moving CoreFeatures class to `utils` module from `core` module. There are other modules besides `core` that need to use CoreFeatures and moving it to `utils` will prevent circular dependency.
Reviewed By: javache, rshest
Differential Revision: D46218604
fbshipit-source-id: 6030f00ad37f55f0c95f4eafa61fb22808b880a4
2023-06-17 07:49:56 -07:00
Ruslan Shestopalyuk and Facebook GitHub Bot
af57ce18d8
Hide unnecessarily exposed private methods in GlobalPerformanceLogger ( #37947 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37947
# Changelog:
[Internal] -
This is a follow-up to an earlier change, that inadvertently added internal methods as public into the GlobalPerformance API.
Reviewed By: rubennorte
Differential Revision: D46820273
fbshipit-source-id: b960b436e3e5e8f81a76bd3ced7282f76906dfca
2023-06-17 06:05:33 -07:00
Intl Schedulerand Facebook GitHub Bot
53526e756f
translation auto-update for Apps/Wilde/scripts/intl-config.json on master
...
Summary:
Chronos Job Instance ID: 1125907901446115
Sandcastle Job Instance ID: 18014399485170687
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46821576
fbshipit-source-id: b758826346428ca2b40d079b10de336c433e6755
2023-06-17 04:19:19 -07:00
Intl Schedulerand Facebook GitHub Bot
c7d0a8823c
translation auto-update for i18n/anna.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907901184259
Sandcastle Job Instance ID: 27021598737781976
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46819604
fbshipit-source-id: 7ea92faedbf50ec760a975c46a7ae7773f91d7e7
2023-06-16 21:41:32 -07:00
Intl Schedulerand Facebook GitHub Bot
2f4182da06
translation auto-update for i18n/talk.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907901184259
Sandcastle Job Instance ID: 27021598737781976
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46819606
fbshipit-source-id: 8cd775f6124e3ce996dc521efa2b9477eb0b6938
2023-06-16 21:41:32 -07:00
Intl Schedulerand Facebook GitHub Bot
17b714fd8a
translation auto-update for i18n/portal_async.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907901184259
Sandcastle Job Instance ID: 27021598737781976
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46819589
fbshipit-source-id: 7ab988d4a3bd446c65dad778e1da14f7dca27d97
2023-06-16 21:41:32 -07:00
Intl Schedulerand Facebook GitHub Bot
71e7bbbc2c
translation auto-update for Apps/Wilde/scripts/intl-config.json on master
...
Summary:
Chronos Job Instance ID: 1125907901243147
Sandcastle Job Instance ID: 36028797994468775
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46819262
fbshipit-source-id: 85876f5642d606661725f2f9cf81b114d6b0bc06
2023-06-16 20:39:36 -07:00
Vincent Riemer and Facebook GitHub Bot
3aa42a2d3d
Add plumbing/boilerplate for an iOS implementation of the gotpointercapture and lostpointercapture events (second try) ( #37889 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37889
Changelog: [Internal] - Add plumbing/boilerplate for an iOS implementation of the gotpointercapture and lostpointercapture events
Lets try this again: The key difference between this and D44977499 (which I previously reverted) is that in propsConversions & primitives I've ommited the "capture" versions of those methods as it was causing issues. Since we're not doing any runtime checks of those raw props it isn't particularlly necessary (at least not yet) and if we ever want to we can address that when it comes up.
The original diff description follows:
This diff simply adds the boilerplate necessary to hook up the gotpointercapture and lostpointercapture events to the fabric iOS touch handler. This diff does not contain any actual implementation of their behavior as that will occur in future diffs.
Reviewed By: adanoff
Differential Revision: D46709127
fbshipit-source-id: 339dc99e14f2e72d9116bbe84edc67cb5bfaa73b
2023-06-16 15:09:13 -07:00
Intl Schedulerand Facebook GitHub Bot
9a8071e401
translation auto-update for i18n/oculus-mirage.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907901104572
Sandcastle Job Instance ID: 22517999110029078
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46813068
fbshipit-source-id: 33a0e3f4d5884076c8f671ded84ba198113967f2
2023-06-16 14:55:08 -07:00
Intl Schedulerand Facebook GitHub Bot
b687499801
translation auto-update for i18n/instagram.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907901104572
Sandcastle Job Instance ID: 22517999110029078
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46813063
fbshipit-source-id: 971a766c6328770cb7e620bbf1d2a0592b825c1b
2023-06-16 14:55:08 -07:00
Intl Schedulerand Facebook GitHub Bot
8bb7f527df
translation auto-update for i18n/messenger.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907901104572
Sandcastle Job Instance ID: 22517999110029078
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46813060
fbshipit-source-id: 366a682d7f3a7f155eb173e257bea7d4e21c9bdc
2023-06-16 14:55:08 -07:00
Intl Schedulerand Facebook GitHub Bot
47d1e3b966
translation auto-update for i18n/talk.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907901104572
Sandcastle Job Instance ID: 22517999110029078
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46813053
fbshipit-source-id: 08bd5a03dab002835af32575414cb48d880a2609
2023-06-16 14:55:08 -07:00
Intl Schedulerand Facebook GitHub Bot
25c9d0fdee
translation auto-update for i18n/fb4a.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907901104572
Sandcastle Job Instance ID: 22517999110029078
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46813062
fbshipit-source-id: fed7836f590cc9b2b3028ad268b0783da0498c5b
2023-06-16 14:55:08 -07:00
Intl Schedulerand Facebook GitHub Bot
56e402c22c
translation auto-update for i18n/analyticsapp.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907901104572
Sandcastle Job Instance ID: 22517999110029078
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46813056
fbshipit-source-id: becc2692aab72b681eae33f4ffedfbe74b6a39fe
2023-06-16 14:55:08 -07:00
Intl Schedulerand Facebook GitHub Bot
62ec7a3211
translation auto-update for i18n/portal_workplacelive_on_portal.config.json on master
...
Summary:
Chronos Job Instance ID: 1125907901104572
Sandcastle Job Instance ID: 22517999110029078
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46813059
fbshipit-source-id: 53157d153de606108ed936e3d5f7ffca474be1b8
2023-06-16 14:55:08 -07:00
Nick Gerleman and Facebook GitHub Bot
19699ab3b5
Native ARIA Roles: Remove JS Shim ( #37304 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37304
### Stack
ARIA roles in React Native are implemented on top of accessibilityRole. This is lossy because there are many more ARIA roles than accessibilityRole. This is especially true for RN on desktop where accessibilityRole was designed around accessibility APIs only available on mobile.
This series of changes aims to change this implementation to instead pass the ARIA role to native, alongside any existing accessibilityRole. This gives the platform more control in exactly how to map an ARIA role to native behavior.
As an example, this would allow mapping any ARIA role to AutomationControlType on Windows without needing to fork to add new options to accessibilityRole.
It also allows greater implementation flexibility for other platforms down the line, but for now, iOS and Android behave the same as before (though with their implementation living in native).
### Diff
This removes the JS shimming of `role` to `accessibilityRole`. It can be landed when the native `role` implementation for both iOS and Android are live for versions we service out of band.
This will require any out of tree platforms to add their own native implementation for `role` to continue to work.
Changelog: [Internal]
Reviewed By: philIip
Differential Revision: D45432518
fbshipit-source-id: 02ac28049a029381af019c042fc7f37833f4157c
2023-06-16 13:21:49 -07:00
Genki Kondo and Facebook GitHub Bot
5f8bbf2bd2
Mitigate flickering on color animations ( #37925 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37925
Vectorized animations (XY, Color) are split into multiple animations for each component that execute in parallel. Upon each of these animations completing, a rerender is triggered to sync the state back to the JS AnimatedValue nodes.
The problem with this is that calling update() on AnimatedProps when each animation completes results in potential flickering as all animations that are part of the vectorized animation may not have completed yet. For example, only the animation for the red channel of an animating color may have been completed, resulting in a temporary red color being rendered. So, for now, ignore AnimatedProps that use a vectorized animation.
Follow up will properly address vectorized animations - only call the update() when all animations complete.
Changelog:
[General][Fixed] - Mitigate flickering on color animations
Reviewed By: rshest
Differential Revision: D46778405
fbshipit-source-id: 5ecb0be95a131b22e5081024d4e094b22b57aac4
2023-06-16 10:40:39 -07:00
Riccardo Cipolleschi and Facebook GitHub Bot
71936fcf43
Fix hermes-engine in Nightlies
...
Summary:
With commit [332be0f ](https://github.com/facebook/react-native/commit/332be0f0c84c48e0b0edd373636b0b5538fa3b2b ) nightlies were broken due to a wrong update with the method we need to use to download hermes.
This change fixes that issue
## Changelog:
[Internal] - Fix hermes-engine download in Nightlies
Reviewed By: cortinico
Differential Revision: D46800717
fbshipit-source-id: 62ce94b980110f46337ce2520fa3c9fbcfe856cc
2023-06-16 10:25:49 -07:00
Nicola Corti and Facebook GitHub Bot
84fc79f453
Bump Gradle to 8.1.1
...
Summary:
Just keeping our Gradle version up to date.
Changelog:
[Internal] [Changed] - Bump Gradle to 8.1.1
Reviewed By: yungsters
Differential Revision: D46769069
fbshipit-source-id: b79ae35473f40e821cf6a1b8e094e33d1b1a44d7
2023-06-16 08:40:11 -07:00
Nicola Corti and Facebook GitHub Bot
f38fc9ba86
Unblock test_android by using a non-internal method of OkHTTP
...
Summary:
test_android is currently broken due to us using `toHttpUrl` which is `Deprecated` with
.ERROR severity level in OkHTTP 4. This fixes it by using the HttpUrl.Builder class
which is always accessible in OkHTTP.
Changelog:
[Internal] [Changed] - Unblock test_android by using a non-internal method of OkHTTP
Reviewed By: sammy-SC
Differential Revision: D46799515
fbshipit-source-id: 874194f0d9be6ba48b49a86b1a17836a8310cc8d
2023-06-16 08:06:08 -07:00
Pieter De Baets and Facebook GitHub Bot
a855013fc6
Use static_cast instead of static_pointer_cast where possible ( #37932 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37932
`static_cast<Derived &>(*sharedBase)` is preferred over `*std::static_pointer_cast<Derived>(sharedBase)`, since we don't need to copy the underlying shared_ptr to do so. The same applies for `std::const_pointer_cast`.
Changelog: [Internal]
Reviewed By: rshest
Differential Revision: D46766558
fbshipit-source-id: 5d0b660107b2a60340952e2b5ec2792e3ed1832a
2023-06-16 08:00:57 -07:00
Intl Schedulerand Facebook GitHub Bot
fa17aad24e
translation auto-update for Apps/Wilde/scripts/intl-config.json on master
...
Summary:
Chronos Job Instance ID: 1125907900746121
Sandcastle Job Instance ID: 13510799856289353
allow-large-files
ignore-conflict-markers
opt-out-review
Differential Revision: D46799013
fbshipit-source-id: fb554c0a053e01f0f7627cee2b896ee7372f6773
2023-06-16 06:37:11 -07:00