Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move CoreFeatures to React-utils (#37599)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37599

changelog: [internal]

Moving CoreFeatures class to `utils` module from `core` module. There are other modules besides `core` that need to use CoreFeatures and moving it to `utils` will prevent circular dependency.

Reviewed By: javache, rshest

Differential Revision: D46218604

fbshipit-source-id: 6030f00ad37f55f0c95f4eafa61fb22808b880a4
This commit is contained in:
Samuel Susla
2023-06-17 07:49:56 -07:00
committed by Facebook GitHub Bot
parent af57ce18d8
commit bb879d3ecb
24 changed files with 22 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/React/Fabric/Mounting/ComponentViews/Image/RCTImageComponentView.mm
+1 -1
View File
@@ -14,9 +14,9 @@
#import <react/renderer/components/image/ImageComponentDescriptor.h>
#import <react/renderer/components/image/ImageEventEmitter.h>
#import <react/renderer/components/image/ImageProps.h>
#import <react/renderer/core/CoreFeatures.h>
#import <react/renderer/imagemanager/ImageRequest.h>
#import <react/renderer/imagemanager/RCTImagePrimitivesConversions.h>
#import <react/utils/CoreFeatures.h>
using namespace facebook::react;
packages/react-native/React/Fabric/Mounting/RCTMountingManager.mm
+1 -1
View File
@@ -17,11 +17,11 @@
#import <React/RCTUtils.h>
#import <react/config/ReactNativeConfig.h>
#import <react/renderer/components/root/RootShadowNode.h>
#import <react/renderer/core/CoreFeatures.h>
#import <react/renderer/core/LayoutableShadowNode.h>
#import <react/renderer/core/RawProps.h>
#import <react/renderer/debug/SystraceSection.h>
#import <react/renderer/mounting/TelemetryController.h>
#import <react/utils/CoreFeatures.h>
#import <React/RCTComponentViewProtocol.h>
#import <React/RCTComponentViewRegistry.h>
packages/react-native/React/Fabric/RCTSurfacePresenter.mm
+1 -1
View File
@@ -29,12 +29,12 @@
#import <react/config/ReactNativeConfig.h>
#import <react/renderer/componentregistry/ComponentDescriptorFactory.h>
#import <react/renderer/components/text/BaseTextProps.h>
#import <react/renderer/core/CoreFeatures.h>
#import <react/renderer/runtimescheduler/RuntimeScheduler.h>
#import <react/renderer/scheduler/AsynchronousEventBeat.h>
#import <react/renderer/scheduler/SchedulerToolbox.h>
#import <react/renderer/scheduler/SynchronousEventBeat.h>
#import <react/utils/ContextContainer.h>
#import <react/utils/CoreFeatures.h>
#import <react/utils/ManagedObjectWrapper.h>
#import "PlatformRunLoopObserver.h"
packages/react-native/ReactAndroid/src/main/jni/react/fabric/Binding.cpp
+1 -1
View File
@@ -26,7 +26,6 @@
#include <jsi/jsi.h>
#include <react/renderer/animations/LayoutAnimationDriver.h>
#include <react/renderer/componentregistry/ComponentDescriptorFactory.h>
#include <react/renderer/core/CoreFeatures.h>
#include <react/renderer/core/EventBeat.h>
#include <react/renderer/core/EventEmitter.h>
#include <react/renderer/core/conversions.h>
@@ -36,6 +35,7 @@
#include <react/renderer/scheduler/SchedulerToolbox.h>
#include <react/renderer/uimanager/primitives.h>
#include <react/utils/ContextContainer.h>
#include <react/utils/CoreFeatures.h>
namespace facebook::react {
packages/react-native/ReactAndroid/src/main/jni/react/fabric/FabricMountingManager.cpp
+1 -1
View File
@@ -13,12 +13,12 @@
#include <react/jni/ReadableNativeMap.h>
#include <react/renderer/components/scrollview/ScrollViewProps.h>
#include <react/renderer/core/CoreFeatures.h>
#include <react/renderer/core/conversions.h>
#include <react/renderer/debug/SystraceSection.h>
#include <react/renderer/mounting/MountingTransaction.h>
#include <react/renderer/mounting/ShadowView.h>
#include <react/renderer/mounting/ShadowViewMutation.h>
#include <react/utils/CoreFeatures.h>
#include <fbjni/fbjni.h>
#include <glog/logging.h>
packages/react-native/ReactCommon/React-FabricImage.podspec
+1
View File
@@ -77,6 +77,7 @@ Pod::Spec.new do |s|
s.dependency "DoubleConversion"
s.dependency "React-ImageManager"
s.dependency "React-Fabric"
s.dependency "React-utils"
s.dependency "Yoga"
if ENV["USE_HERMES"] == nil || ENV["USE_HERMES"] == "1"
packages/react-native/ReactCommon/react/renderer/components/image/CMakeLists.txt
+1
View File
@@ -26,6 +26,7 @@ target_link_libraries(rrc_image
glog_init
jsi
react_debug
react_utils
react_render_core
react_render_debug
react_render_graphics
packages/react-native/ReactCommon/react/renderer/components/image/ImageProps.cpp
+1 -1
View File
@@ -7,8 +7,8 @@
#include <react/renderer/components/image/ImageProps.h>
#include <react/renderer/components/image/conversions.h>
#include <react/renderer/core/CoreFeatures.h>
#include <react/renderer/core/propsConversions.h>
#include <react/utils/CoreFeatures.h>
namespace facebook::react {
packages/react-native/ReactCommon/react/renderer/components/scrollview/ScrollViewProps.cpp
+1 -1
View File
@@ -8,9 +8,9 @@
#include "ScrollViewProps.h"
#include <react/renderer/components/scrollview/conversions.h>
#include <react/renderer/core/CoreFeatures.h>
#include <react/renderer/core/graphicsConversions.h>
#include <react/renderer/debug/debugStringConvertibleUtils.h>
#include <react/utils/CoreFeatures.h>
#include <react/renderer/core/propsConversions.h>
packages/react-native/ReactCommon/react/renderer/components/text/BaseTextProps.cpp
+1 -1
View File
@@ -8,10 +8,10 @@
#include "BaseTextProps.h"
#include <react/renderer/attributedstring/conversions.h>
#include <react/renderer/core/CoreFeatures.h>
#include <react/renderer/core/graphicsConversions.h>
#include <react/renderer/core/propsConversions.h>
#include <react/renderer/debug/DebugStringConvertibleItem.h>
#include <react/utils/CoreFeatures.h>
namespace facebook::react {
packages/react-native/ReactCommon/react/renderer/components/text/ParagraphLayoutManager.cpp
+1 -1
View File
@@ -7,7 +7,7 @@
#include "ParagraphLayoutManager.h"
#include <folly/Hash.h>
#include <react/renderer/core/CoreFeatures.h>
#include <react/utils/CoreFeatures.h>
namespace facebook::react {
packages/react-native/ReactCommon/react/renderer/components/text/ParagraphProps.cpp
+1 -1
View File
@@ -9,9 +9,9 @@
#include <react/renderer/attributedstring/conversions.h>
#include <react/renderer/attributedstring/primitives.h>
#include <react/renderer/core/CoreFeatures.h>
#include <react/renderer/core/propsConversions.h>
#include <react/renderer/debug/debugStringConvertibleUtils.h>
#include <react/utils/CoreFeatures.h>
#include <glog/logging.h>
packages/react-native/ReactCommon/react/renderer/components/textinput/androidtextinput/react/renderer/components/androidtextinput/AndroidTextInputProps.cpp
+1 -1
View File
@@ -7,9 +7,9 @@
#include "AndroidTextInputProps.h"
#include <react/renderer/components/image/conversions.h>
#include <react/renderer/core/CoreFeatures.h>
#include <react/renderer/core/graphicsConversions.h>
#include <react/renderer/core/propsConversions.h>
#include <react/utils/CoreFeatures.h>
namespace facebook::react {
packages/react-native/ReactCommon/react/renderer/components/view/AccessibilityProps.cpp
+1 -1
View File
@@ -9,9 +9,9 @@
#include <react/renderer/components/view/accessibilityPropsConversions.h>
#include <react/renderer/components/view/propsConversions.h>
#include <react/renderer/core/CoreFeatures.h>
#include <react/renderer/core/propsConversions.h>
#include <react/renderer/debug/debugStringConvertibleUtils.h>
#include <react/utils/CoreFeatures.h>
namespace facebook::react {
packages/react-native/ReactCommon/react/renderer/components/view/ViewProps.cpp
+1 -1
View File
@@ -11,10 +11,10 @@
#include <react/renderer/components/view/conversions.h>
#include <react/renderer/components/view/propsConversions.h>
#include <react/renderer/core/CoreFeatures.h>
#include <react/renderer/core/graphicsConversions.h>
#include <react/renderer/core/propsConversions.h>
#include <react/renderer/debug/debugStringConvertibleUtils.h>
#include <react/utils/CoreFeatures.h>
namespace facebook::react {
packages/react-native/ReactCommon/react/renderer/components/view/ViewShadowNode.cpp
+1 -1
View File
@@ -8,7 +8,7 @@
#include "ViewShadowNode.h"
#include <react/config/ReactNativeConfig.h>
#include <react/renderer/components/view/primitives.h>
#include <react/renderer/core/CoreFeatures.h>
#include <react/utils/CoreFeatures.h>
namespace facebook::react {
packages/react-native/ReactCommon/react/renderer/components/view/YogaStylableProps.cpp
+1 -1
View File
@@ -9,9 +9,9 @@
#include <react/renderer/components/view/conversions.h>
#include <react/renderer/components/view/propsConversions.h>
#include <react/renderer/core/CoreFeatures.h>
#include <react/renderer/core/propsConversions.h>
#include <react/renderer/debug/debugStringConvertibleUtils.h>
#include <react/utils/CoreFeatures.h>
#include <yoga/YGNode.h>
#include <yoga/Yoga.h>
packages/react-native/ReactCommon/react/renderer/core/ConcreteComponentDescriptor.h
+1 -1
View File
@@ -13,7 +13,6 @@
#include <react/debug/react_native_assert.h>
#include <react/renderer/components/view/ViewPropsInterpolation.h>
#include <react/renderer/core/ComponentDescriptor.h>
#include <react/renderer/core/CoreFeatures.h>
#include <react/renderer/core/EventDispatcher.h>
#include <react/renderer/core/Props.h>
#include <react/renderer/core/PropsParserContext.h>
@@ -21,6 +20,7 @@
#include <react/renderer/core/ShadowNodeFragment.h>
#include <react/renderer/core/State.h>
#include <react/renderer/graphics/Float.h>
#include <react/utils/CoreFeatures.h>
namespace facebook::react {
packages/react-native/ReactCommon/react/renderer/core/Props.cpp
+1 -1
View File
@@ -8,8 +8,8 @@
#include "Props.h"
#include <folly/dynamic.h>
#include <react/renderer/core/CoreFeatures.h>
#include <react/renderer/core/propsConversions.h>
#include <react/utils/CoreFeatures.h>
namespace facebook::react {
packages/react-native/ReactCommon/react/renderer/runtimescheduler/primitives.h
+1 -1
View File
@@ -9,8 +9,8 @@
#include <folly/dynamic.h>
#include <jsi/jsi.h>
#include <react/renderer/core/CoreFeatures.h>
#include <react/renderer/runtimescheduler/Task.h>
#include <react/utils/CoreFeatures.h>
namespace facebook::react {
packages/react-native/ReactCommon/react/renderer/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.cpp
+1 -1
View File
@@ -12,11 +12,11 @@
#include <react/common/mapbuffer/JReadableMapBuffer.h>
#include <react/jni/ReadableNativeMap.h>
#include <react/renderer/attributedstring/conversions.h>
#include <react/renderer/core/CoreFeatures.h>
#include <react/renderer/core/conversions.h>
#include <react/renderer/mapbuffer/MapBuffer.h>
#include <react/renderer/mapbuffer/MapBufferBuilder.h>
#include <react/renderer/telemetry/TransactionTelemetry.h>
#include <react/utils/CoreFeatures.h>
using namespace facebook::jni;
packages/react-native/ReactCommon/react/renderer/uimanager/primitives.h
+1 -1
View File
@@ -12,10 +12,10 @@
#include <jsi/jsi.h>
#include <react/debug/react_native_assert.h>
#include <react/renderer/components/text/RawTextShadowNode.h>
#include <react/renderer/core/CoreFeatures.h>
#include <react/renderer/core/EventHandler.h>
#include <react/renderer/core/ShadowNode.h>
#include <react/renderer/core/TraitCast.h>
#include <react/utils/CoreFeatures.h>
namespace facebook::react {
packages/react-native/ReactCommon/react/renderer/core/CoreFeatures.cpp → packages/react-native/ReactCommon/react/utils/CoreFeatures.cpp
View File
packages/react-native/ReactCommon/react/renderer/core/CoreFeatures.h → packages/react-native/ReactCommon/react/utils/CoreFeatures.h
View File