Commit Graph
8933 Commits
Author SHA1 Message Date
aryanrawlani28 d48453693c GUI: U32: Use translated strings as arguments for formatting function usage. 2020-08-30 14:43:41 +02:00
aryanrawlani28 a647812bfb iOS: Use U32 for clipboards. 2020-08-30 14:43:41 +02:00
aryanrawlani28 3fc336300f 3DS: Use U32Strings for displaying OSD Messages 2020-08-30 14:43:41 +02:00
aryanrawlani28 3c79c2a519 GUI: U32: Fix incorrect format specifier for aspect ratio message. 2020-08-30 14:43:41 +02:00
aryanrawlani28 1950e38154 ANDROID: Support OSD Messages for U32. 2020-08-30 14:43:41 +02:00
Thierry Crozat a54b5826ea UPDATES: Fix compilation with U32 strings 2020-08-30 14:43:41 +02:00
aryanrawlani28 a9c5e930f0 ANDROID: Make clipboards work with U32Strings. 2020-08-30 14:43:41 +02:00
aryanrawlani28 f0ad817716 SDL: Fix clipboard fetching internally
- This doesn't mean that it displays properly in the GUI, but it does return the proper value from getTextFromClipboard.
2020-08-30 14:43:41 +02:00
Thierry Crozat 733df0bfa1 MACOSX: Fix getting text from clipboard 2020-08-30 14:43:41 +02:00
aryanrawlani28 f9b05f5e5a BACKENDS: DIALOGS: MACOS: Improve readability and remove redundant code. 2020-08-30 14:43:41 +02:00
aryanrawlani28 0ca5a40d85 TTS: ALL: Improve u32-ity
- Allow the base class to take in a string with custom charset, convert to U32 and pass it along.
- Remove redudandant functions in all tts-subsystems
- Remove unnecessary "charset" argument, as U32Strings imply that we are using a UTF-32 charset
- Adjust relative code appropriately according to the above point.
2020-08-30 14:43:41 +02:00
aryanrawlani28 f95762881e GUI: U32: Use unicode strings for native Windows dialogs
These make use of newly added win-wrapper UTF8ToUnicode.
2020-08-30 14:43:41 +02:00
aryanrawlani28 93cb408c05 BACKENDS: WIN32: Add UTF8ToUnicode for Win32wrapper
- The new changes for converting GUI to U32 will need these.
- Provide missing notes for codepage params in other wrapper functions
2020-08-30 14:43:41 +02:00
aryanrawlani28 9bf3f73d8a GUI: U32: Use U32Strings for native dialogs
- Make DialogManager showFileBrowser take in u32
- Show filebrowser with u32 in MacOS and GTK
2020-08-30 14:43:41 +02:00
aryanrawlani28 56911beea2 GUI: U32: Add and use a U32Tokenizer
- Added in common/tokenizer.cpp
- Uses iterators to function
2020-08-30 14:43:41 +02:00
aryanrawlani28 68d01321d6 GUI: U32: Downscale changes of U32, fix review issues
This commit addresses a range of changes, within scummvm subproject.

- Audio files, like mididrv, remove U32String based name and identifier, because ASCII only.
- mididrv.cpp had some wrong format for warning messages, fix those
- Message dialogs were modified to use default arguments more often, but reverting back to the orignal to minimize changes.
- SetTooltip has a fake constructor that takes in a string, and use it.
- U32Format had some break statements missing, add those.
- RemapWidget: Use fake constructor for setLabel and setTooltip, to make minimal changes
- SDL: setting text in clipboard no longer uses SDL_iconv_string
- TTS: Override base class "say" with strings, so tts->say can be used with normal strings too.
- About dialog: fix incorrect code for u32string variables
- Fix some extra brackets
- Some buttons were incorrectly removed from using translated labels, revert those
- Message Dialog: Pass default and alt buttons as const references
- Saveload Dialog: Use translations in missing places, use const-references. Also, use translations in a correct manner.
- Use const references for tooltip in GraphicsWidget, EditTextWidget, error.cpp
- DomainEditTextWidget: Use U32String for text
2020-08-30 14:43:41 +02:00
aryanrawlani28 4b6976c558 GUI: U32: Reduce number of files changed and fixes
Up until last commit, everything was working fine but the amount of files changed was too large. This commit tries to reduce the changes.

- Add a fake constructor to Keymap, text-to-speech, setDescription (save-state)
- Redirecting functions for PopUpWidget::appendEntry, ButtonWidget::setLabel, GUIErrorMessage
- Use the above functions and constructors to reduce changes in Engines
- Fix warnings being in unicode. Only output english text in - Warnings, Errors, etc.
- Mark some strings as "translation" strings. (Not yet added to POTFILES)
- Remove some CP related things from po/modules.mk
- Previously used some Common::convertToU32 where it was not necessary, replace this with u32constructor
2020-08-30 14:43:41 +02:00
aryanrawlani28 bd19eaa5bf GUI: U32: More code improvements in engines and misc fixes
- Xeen's GUIError now takes in U32String
- Scumm's ValueDisplayDialog takes in U32
- Mohawk's InfoDialog & PauseDialog takes in U32
- Mohawk - in riven.cpp, Some assignment fixes
- Backends -in sdl.cpp, Remove incorrect conversion from iso8859 when setting text in clipboard
- Graphics - Add u32 strings instead of decoding each piece in format
2020-08-30 14:43:41 +02:00
aryanrawlani28 f46be5c766 GUI: U32: Improve splitting osd messages
Use iterators for construction instead of continous adding
2020-08-30 14:43:41 +02:00
aryanrawlani28 d12c6c4338 GUI: U32: Code cleanup
- Remove extra parantheses leftover from temp code
- SaveLoadDialog - do not encode when setting labels
- Remove mapping variable from ThemeEngine::loadScalableFont (and use default 0)
- Remove incorrect u32 constructor wrapper from confman.set in eventrecorder.cpp
2020-08-30 14:43:41 +02:00
aryanrawlani28 185fb72783 GUI: U32: Improve U32 code
- Revert accidentally put translations in mt32.cpp
- Use U32::format in some places earlier missed
- Add %u and %i for u32::format
- Add support for GUIErrorMsgFormat to use u32::format internally
- Use the above whereever needed
- Improve linux tts by removing redundant code
- Some places I had changed nullptr -> "". Revert this
2020-08-30 14:43:41 +02:00
aryanrawlani28 e91f968992 GUI: U32: encode and use c strings for translations in macos dialogs 2020-08-30 14:43:41 +02:00
aryanrawlani28 8cfa8a5589 GUI: U32: Use u32 for menu items in mac 2020-08-30 14:43:41 +02:00
aryanrawlani28 4bcac1df17 GUI: U32: Use u32 in clipboards for MacOS 2020-08-30 14:43:41 +02:00
aryanrawlani28 a9bfe35216 GUI: U32: More issue fixes and general improvements
- Use the fake constructor for message dialog less often
- solve errors regarding comparision between string and u32string in midi
- solve errors in testbed/speech related to ttsMan->say
- fix unsigned comparision warning in tab.cpp
- fix issue with static strings and translations in sdl-graphics
2020-08-30 14:43:41 +02:00
aryanrawlani28 da380a9002 GUI: U32: Fix issues with ustr formatting
- Fix one off error with 'pos'
- Fix last line not being inserted in osdMessage when display
2020-08-30 14:43:41 +02:00
aryanrawlani28 4506bcd9f3 GUI: U32: Fix compilation errors
After rebasing to get even with master, some compilation errors occured. This commit fixes that.
2020-08-30 14:43:41 +02:00
aryanrawlani28 e22b32abfe GUI: U32: Use Common::U32String::format where necessary and GUIError to u32
- Where necessary as in, where translated messages are used.
- GUIErrorMessage now takes in U32String
- error messages across some engines use U32Strings. they are changed because they show a message dialog.
2020-08-30 14:43:41 +02:00
aryanrawlani28 1ca1712b4d GUI: U32: Fix problems with u32strings formatting
- Improve U32's format helper
- Add insertString helper to u32
2020-08-30 14:43:41 +02:00
aryanrawlani28 0118839c59 GUI: U32: Use u32 for tts (MacOS) 2020-08-30 14:43:41 +02:00
aryanrawlani28 bcbe2fe2ea GUI: U32: Enable u32 for tts (Linux) 2020-08-30 14:43:41 +02:00
aryanrawlani28 ef7ec444d3 GUI: U32: Enable u32 for tts (Windows)
They always take in U32 strings now.

- Revert tts descriptions to string, they don't use translations, so better to keep it as strings.
- Make read() take in const U32 references.
2020-08-30 14:43:41 +02:00
aryanrawlani28 d4d5b8906e GUI: U32: Begin making TTS take in U32Strings for saying
Only for strings without an explicit action. The first level takes in a u32 string, encodes it, and passes it along further with the default action

- For gui widgets, the strings are passed in as native u32 strings.
- For everything else, they are being converted to u32 by Common::convertToU32... and then being passed along
2020-08-30 14:43:41 +02:00
aryanrawlani28 49c36c2b45 GUI: U32: Begin converting texts in clipboards to u32strings
With this commit the base class variables and the parts where getClipboard and setClipboard are used is changed accordingly.
2020-08-30 14:43:41 +02:00
aryanrawlani28 3641e24daa JANITORIAL: Add missing space 2020-08-30 14:43:41 +02:00
aryanrawlani28 b9a449480b GUI: U32: Remove u32::format references
- Removed because implicit conversion can simply handle this usecase
2020-08-30 14:43:41 +02:00
aryanrawlani28 160a1320cc GUI: U32: Rename more temp code and fix issues
- Remove convertFromU32.. where necessary
- Replace convertFromU32 to .encode() for better readability
- Fix spacing issues in tabs
- Fix spacing issues in popups
- Fix weird font rendering in certain menus.
- Fix dialog changing sizes by huge amount when changing languages
- Some minor changes from String::format to U32String::Format
2020-08-30 14:43:41 +02:00
aryanrawlani28 96912f4adb GUI: U32: Rename some references of strings to use U32() & not helper method 2020-08-30 14:43:41 +02:00
aryanrawlani28 f800ca4ada GUI: U32: Convert majority of code to use U32
This commit also includes some additional major changes.

- Return U32String from TransMan getTranslation()
- Change tooltips to be U32Strings
- Remove temporary code of convertToU32String
- U32 Support various dialogs (Browser, FileBrowser, Messages, Chooser, etc)
- U32 for music plugins
- U32 for OSD messages
- Add some helper functions to ustr.cpp
- Change default tooltips from nullptr & 0 -> ""
- Some runtime exceptions may occur when changing languages due to incorrect String::Format
2020-08-30 14:43:41 +02:00
aryanrawlani28 aafade4507 GUI: U32: Shift most widgets to draw with u32
- ButtonWidgets (Button, Radio, Checkbox, dropdown)
- StaticTextWidgets
- PopUpWidgets
- Tabs
- Add a temporary overloaded drawDDText function to make other widgets draw normally
2020-08-30 14:43:41 +02:00
Eugene Sandulenko 98e0b14852 RELEASE: This is 2.3.0git 2020-08-30 13:42:19 +02:00
SupSuper eb1882e243 BACKENDS: Use game ID instead of game domain for Discord presence 2020-08-29 20:01:16 +01:00
Thierry Crozat fb9abcd154 KEYMAPPER: Enable virtual keyboard while remapping keys 2020-08-29 16:31:37 +01:00
Thierry Crozat 760815b3b8 BACKENDS: Do not define a Quit action if the NoQuit feature is enabled 2020-08-29 16:31:37 +01:00
Thierry Crozat 3baad9e2a4 IOS7: Hide virtual keyboard input assistant bar 2020-08-29 16:31:37 +01:00
Eugene Sandulenko 045df72426 EVENTRECORDER: Fix crash on attempt to save. Fixed #10045
Since we have two event managers during recording, we invalidate
cache in order to avoid cache miss
2020-08-29 17:22:38 +02:00
Pawel Kolodziejski 949d251fc5 BACKENDS: Fixed typo in name 2020-08-29 15:14:40 +02:00
Cameron Cawley 2cdbc27ef8 ANDROID: Fix creating the default event manager 2020-08-27 23:05:45 +01:00
Bastien Bouclet 55db1210eb 3DS: Set a Virtual Memory Address when linking the plugins
Setting the base address for the plugin elf files high in memory forces
the linker to generate veneers to turn relative jumps to the main binary
into absolute jumps. This removes the need to allocate the plugins near
the the main binary in the program address space. This also removes the
need to handle the R_ARM_CALL and R_ARM_JUMP24 relocation types.

Fixes #11555.
2020-08-27 21:14:07 +02:00
Artem Vorobiev fc02c528b9 ANDROID: Fix sigsegv and sigfpe on start. Enable basic touch control. 2020-08-27 19:56:32 +02:00