No need to explicitly set it to 1.0. (There may have been in an
earlier version, to avoid any possible rounding error. But if so,
that reason is long gone.)
The high-resolution videos play back at much lower volume than the
original ones. This adds hard-coded values for how much to amplify
each cutscene. It's all done by ear, and it does introduce some
clipping, but I think it should be acceptable.
Of course, it could also be a problem with the audio decoder, so
this may be the wrong approach entirely.
Replaces an earlier patch that had a bad byte.
Original instruction: 0x80, 0xd2, // lsg global[D2h].
The op byte does not match the expected length or opcode comment.
0x80 would be: lag uint16.
0x89 is: lsg byte.
This new patch also does not disturb the logic of a nearby IF block.
After leaving the cell on Arsano there's a desk you need to attach your
watch to and set the alarm to attract the guard in the next room. If the
alarm goes off while reading the newspaper, the game glitches out with
wrong palette colors, scene, ..
Although renderImage for ImageId doesn't use _currentImage, it needs to
be set for compatibility with the section based renderImage function.
The functionality doesn't change with this commit, except that the
palette brightness gets updated if the image is in a different file.
The audio samples' offset and corresponding file number are better
described in sound.h. Also the variable timer2 was renamed quite a while
ago and served only as a reference to the original source code.
When Rif puts on the rat disguise, he is swapped out for a
different actor. When he takes off the disguise, after reaching
Sist's office, the old actor is swapped back in again.
At that point, original Rif's actor will have a _lastZone pointer
which not only is for the wrong room, it was deleted when Rif in
disguise left the room.
To fix this, we also swap the actors's _lastZone pointers.
When built with enable-text-console and disable-readline, flushing output
immediately after printing the debugger prompt, before waiting for input,
ensures that external tools can spawn ScummVM, detect the prompt, and pipe
in automated responses (e.g., expect scripts).
Explicit flushing was necessary at least on Windows, where support for
automating terminal input is less sophisticated. Otherwise, the prompt
string doesn't make it through the pipe, and both the script and ScummVM
get stuck waiting for input.
Peter Kohaut
Torbjörn Andersson
sluicebox
Vhati
Jean-Christophe Rona
Cameron Cawley
Paul Gilbert
Thierry Crozat
Lothar Serra Mari
Paolo Bossi
Antoniou Athanasios
Joseph-Eugene Winzer
Ľubomír Remák