Commit Graph
4622 Commits
Author SHA1 Message Date
Michael Schneider d649f2524f Remove legacy ASVideoNode flags 2016-11-14 09:21:38 -08:00
Adlai Holler e2e32870ed Reduce Flashing & Optimize ASTableNode/ASCollectionNode Data Loading (#2541)
* Optimize data controller loading by combining section updates with first set of item updates

* Update call pattern test

* Add some explanation about the approach
2016-11-14 14:30:41 +09:00
Michael Schneider 44aa582ceb Fix crash if batch update blocks are nil although method declaration allows nullable (#2599) 2016-11-14 10:15:11 +09:00
Austin Louden ae11fc755e Update deprecations in ASCollectionView example, enable warnings (#2594)
* Update example deprecations and flags

* update podfile
2016-11-10 22:42:37 -08:00
gazreese 3cdbc63e31 [ASVideoNode] Addition of reset method to return to initial state (#2119)
* [ASVideoNode] Addition of reset method to allow video node to return to initial state of placeholder and play button

* Implemented pull request review comments for code style
2016-11-10 16:35:43 -08:00
Michael Schneider 2ba8239ff5 ASViewController example improvements (#2592) 2016-11-10 16:33:01 -08:00
Adlai Holler 171cc2f527 Improve Automatic Subnode Management Node Ordering (#2589)
* Add failing tests for subnode ordering

* Ensure that subnode ordering matches layout spec tree ordering
2016-11-10 09:22:53 +09:00
george-gw f22e1c2eb0 [LayoutSpecExamples] Added swift counterpart. (#2576)
* [LayoutSpecExamples] Added swift counterpart.

* Fixed copyright text.
2016-11-10 08:54:53 +09:00
Michael Schneider 1eb2bb6606 Add ASDynamicCast (#2586) 2016-11-10 07:41:45 +09:00
Adlai Holler 6bbc9a3cb0 Add a macro (default 0) to control event backtrace recording (#2584) 2016-11-08 21:50:59 -08:00
Adlai Holler 9385425d07 Fix compiler complaining about unused variable in release builds (#2583) 2016-11-09 14:31:05 +09:00
Adlai Holler 88fecbe3eb Fix Issue in ASPagerNode Flags Handling, Restore Disabled Test (#2582)
* Fix ASPagerNode flags handling, restore affected test

* Rejigger ASPagerNode's flag handling to ensure it handles edge case in production
2016-11-09 14:20:07 +09:00
Hannah Troisi edf2b669ae [ASCollectionViewLayoutInspecting] make -scrollableDirections required (#2543)
* [ASCollectionViewLayoutInspecting] make -scrollableDirections a required method

* doh!

* fixed?

* add assert per @appleguy's comment

* use self.layoutInspector, add check at the start of didChangeBounds...
2016-11-09 13:48:16 +09:00
appleguy 55b5dff80c [ASLayoutSpec] Initial commit to support visualizing layout specs (with Playground app). (#2554)
* Initial ASLayoutSpecPlayground commit

* Initial exploratory stab at the main challenge of the app - visualizing ASLayoutSpecs

* Halfway through moving debug features out of ASDK framework files and into debug files. Project builds.

* [ASLayoutSpecPlayground] Created new Inspector node, cleaning up internal implementation to start formalizing support for layout spec visualization.

* Workaround for ensuring creation of visualizerNode for ALL layoutspecs

* continued development

* Layout Inspector Work in Progress

* Resizing the playground works in the shrink direction, not for grow.

* added new ASLayoutableInspectorNode features

* Cleaned up examples code.

* Cleaning up  code.

* more code cleanup

* [ASLayoutableInspector] Transition to an ASTableNode-based architecture to support larger numbers of buttons / customizable types.

* [ASLayoutableInspector] Support different layoutable property types to set up buttons that can edit all of them.

* Huy debugging

* Refactored layout inspector code for extensibility.

* Properly lock layoutableContextMap

* Fix context handling in ASDisplayNode:measureWithSizeRange

* Fix ASLayoutSpecPlayground:ViewController:toggleVisualization

* added slider to InspectorCell

* [ASLayoutSpecPlayground] Improvements to propagation of visualize mode, resize handle, minor cleanup.

* Fix to ASEnvironment

* [ASLayoutSpecPlayground] Fix a few minor issues from the merge with latest master.

* Implement layout spec cache

* add pager ndoe

* add more examples

* add more layout examples

* [ASLayoutPlayground] Fix merge issues

* [ASLayoutPlayground] Fix up the example project from the 2.0 API changes.

* [ASLayoutPlayground] Some fixes (#2411)

* [ASLayoutPlayground]: Some fixes
* Fixed crash when tapping descender.
* Fixed setting the item to inspect.
* Fixed button states in inspector node.
* Added sliders for spacingBefore, spacingAfter, ascender.

* [ASLayoutSpecPlayground] Deselect the buttons when editing is over.

* [ASLayoutSpecPlayground] Changed flexGrow/Shrink's values from YES/NO to 1.0/0.0

* [Project] Create new Debug/ directory for advanced tools dedicated to debugging.

* [LayoutSpecPlayground] Rename project without AS in title, to be consistent with LayoutSpecExamples.

* [Bulid] Fix Xcode project to use new Debug subdirectory / group.

* [Bulid] Fix a small merge error.

* [Build] Fix build issue for Framework target.

* [Bulid] Fix podspec to expose InspectorNode header; Remove old-cocoapods emojis from ASDKgram :)

* Move aside ASLayoutSpecPlayground-Swift to match master

* [LayoutSpecPlayground] Cleanup implementation in several files, xcodeproj, etc.

* [ASControlNode] Add comment for new assertion, to be enabled in a separate diff.
2016-11-08 20:16:16 -08:00
Adlai Holler a1156e108f Reduce memory consumption caused by event tracing (#2570) 2016-11-08 18:06:31 -08:00
Michael Schneider 2e46aa1e89 Move ASEventLog out of the Private folder (#2580) 2016-11-09 10:41:45 +09:00
Hannah Troisi 549a90418c another deprecation warning (#2571) 2016-11-09 10:41:27 +09:00
Adlai Holler 5c15869087 Disable Text Node Fast Path (#2581)
* Disable text node fast path

* Actually commit the test change
2016-11-09 10:25:02 +09:00
Huy Nguyen fb6d1830a0 Beter table/collection update history (#2562)
- Introduce thread-safe ASEventLog
- ASCollectionNode and ASTableNode share their event log with their ASDataController. The controller uses it to log change set submitting and finishing events.
- ASCollectionNode and ASTableNode print their data source and delegate in their debug description.
2016-11-08 16:44:49 -08:00
Garrett Moon 06f5754b37 This way we only have to update the version number in one place. (#2577) 2016-11-08 16:19:52 -08:00
Scott Goodson d3e942acf7 [Build] Disable failing test in ASViewController until it can be investigated. 2016-11-08 15:25:05 -08:00
Scott Goodson f9a96d58b8 [Build] Update build script to use iOS 10.1 (Xcode 8.1). 2.0-beta.1 2016-11-07 18:24:34 -08:00
Luke Parham 2754af3858 added index of page with node method to ASPagerNode along with some tests (#2561) 2016-11-07 16:07:54 -08:00
Hannah Troisi 9949c6348d [Examples] update example projects to 2.0 API (#2568)
* update example projects to latest Collection / Table API

* udpate delegate / data source methods
2016-11-07 15:55:09 -08:00
Garrett Moon cc00626642 Fix Carthage build (#2567) 2016-11-07 15:54:23 -08:00
Scott Goodson c4a4df7c52 [Build] Move aside ASLayoutSpecPlayground-Swift for now, as it is causing an Xcode 8.0-specific build failure. 2016-11-07 15:15:58 -08:00
Garrett Moon 47f9084bee Include latest version of PINRemoteImage and PINCache (#2565) 2016-11-07 15:01:33 -08:00
Hannah Trosi 72eb924932 replace missing layoutSpecThatFits method 2016-11-07 03:17:48 -08:00
Garrett Moon 17bd3acdee Revert "Need to trampoline to main to make contents check safe if nodes are loaded. (#2545)"
This reverts commit 11e07ff409.
2016-11-06 18:09:29 -08:00
Scott Goodson d7ba0a9c6d [Build] Add imports that are necessary for clang to parse header files after compilation.
This allows the objc-diff tool (which creates API diffs) to run successfully.
2016-11-06 15:04:30 -08:00
Hannah Troisi 7a373ac638 Update Layout Examples to ASDK 2.0 (#2551)
* Objective-c project updated to ASDK 2.0

* fix assets error

* [LayoutSpecExamples] Renamed new example project to be easier to type / find.

* [Bulid] Manually create Sample.xcscheme file to hopefully fix complaining bulid :).

* clean up project

* commentary on ASAbsoluteLayoutSpec

* address @maicki's comments
2016-11-06 13:47:48 -08:00
Scott Goodson 735d1411d2 [Cocoapods] Update podspec to 2.0-beta.1 version; reference AsyncDisplayKit Twitter account. 2016-11-05 19:32:41 -07:00
Michael Schneider de36ef29bd Fix height check in ratio layout spec (#2553) 2016-11-05 18:45:42 -07:00
Michael Schneider e4da4131cf Improve layout spec block documentation (#2547) 2016-11-05 18:45:18 -07:00
Garrett Moon 11e07ff409 Need to trampoline to main to make contents check safe if nodes are loaded. (#2545) 2016-11-04 11:33:17 -07:00
Garrett Moon 62a0296148 Implementation needs to match decleration. (#2539) 2016-11-02 18:19:26 -07:00
Michael Schneider dae374d482 Initial commit to cleanup modifying subnode hierarchy (#2535) 2016-11-02 17:12:35 -07:00
Garrett Moon 076d22e9f1 Do not reuse NSStringDrawingContexts (#2537) 2016-11-02 14:37:51 -07:00
george-gw ff9e493a59 Fixed asciiArtString. (#2523) 2016-11-01 17:33:27 -07:00
Adlai Holler a6e2f8e5ab Finish Porting indexPath-Oriented Methods to ASTableNode/ASCollectionNode (#2527)
* Finish porting over the indexPath-oriented properties from table/collection view to node

* Make indexPathForSelectedRow a property
2016-11-01 15:03:46 -07:00
Hannah Troisi e1e5eb6ca0 improve deprecation message (#2524) 2016-11-01 11:33:31 -07:00
Hannah Troisi aac52d7f6d Improve Deprecation Warning for myself (#2521) 2016-11-01 09:12:04 -07:00
Michael Schneider 58e9c807b9 Fix using UIActivityIndicatorView provided in view block (#2522) 2016-11-01 07:58:54 -07:00
Hannah Troisi 8e6f842b8d [ASLayoutElementStyle] implement -description with sizing info (#2495)
* Layout style object debugging

* Remove cocoapods crap
2016-11-01 07:58:43 -07:00
Scott Goodson 6297fa5241 [ASTableNode] Minor fix so visibleNodes is in the same position as declaration in ASCollectionNode. 2016-10-31 20:24:24 -07:00
Michael Schneider f7ea4f67f7 Fix Swift Example (#2520) 2016-10-31 19:25:06 -07:00
Garrett Moon 68990cb6cc Deprecations should be re-enabled. If there are specific deprecations… (#2519)
* Deprecations should be re-enabled. If there are specific deprecations we'd like to hold off on, we should address those specifically.

* Fix decleration

* Move select to undeprecated

* Fix deprecations
2016-10-31 17:30:40 -07:00
Michael Schneider 4464b7de60 Improve deprecation situation for 2.0 (#2514)
* Improve deprecations for 2.0

- Add deprecations for node / layoutSpec style properties
- Implement missing methods on ASDisplay from deprecation header
- Cleanup all of the deprecation categories

* Remove DeprecatedProtocolMethods

* Fix "Life without Cocoapods"

* Update comments
2016-10-31 16:46:21 -07:00
Adlai Holler f09b92641c Invalidate TextNode Renderer Instead of Changing constrainedSize (#2516)
* Instead of changing its constrained size, just invalidate renderer. It's virtually the same.

* Check constrained size before invalidating renderer
2016-10-31 14:14:21 -07:00
Michael Schneider 7ecce6b677 Remove thread affinity for _displaysAsynchronously (#2518) 2016-10-31 14:12:50 -07:00