Commit Graph
4622 Commits
Author SHA1 Message Date
Garrett Moon 700d927e3a Don't even bother removing since it's a weak hash table. 2018-06-27 15:05:31 -07:00
Garrett Moon 2a1c063ea0 Huy's comments 2018-06-27 14:50:22 -07:00
Garrett Moon 0dcfaec023 Make ASDisplayNode+InterfaceState.h public 2018-06-27 12:36:25 -07:00
Garrett Moon 205f6d4c3d Add CHANGELOG 2018-06-27 12:25:43 -07:00
Garrett Moon 8c5981e623 Switch to respondsToSelector for int del instead of separate object 2018-06-27 12:24:12 -07:00
Garrett Moon e8b8fd651e Adds support for having multiple interface state delegates.
Hopefully in a performant way.
2018-06-20 17:03:51 -07:00
Max Wang fa0ef6fdd2 ASConfiguration version check only when have json dict (#971)
* fix SIMULATE_WEB_RESPONSE not imported #449

* Fix to make rangeMode update in right time

* remove uncessary assert

* avoid extra version log.

* check dictionary earlier
2018-06-19 09:20:34 -07:00
Adlai Holler a0e5f4c002 Create an experiment to remove extra collection teardown step (#975)
* Create an experiment to remove extra collection teardown step, simplify delegate proxy

* chagelog

* Remove detritus
2018-06-19 08:32:02 -07:00
Andrei Titov 4669a24fdf Fixed removing node from supernode after layout transition (#937)
Fixed removing node from supernode after layout transition when automaticallyManagesSubnodes is disabled. In case if developer prefer to manage subnodes by himself then he wants to be sure that stack will not change automatically.
2018-06-18 18:43:09 -07:00
Max Wang f4f1454be1 Pointer check #trivial (#970) 2018-06-18 18:38:26 -07:00
Adlai Holler dbe469a94a Standardize "extern" decls on AS_EXTERN (#972)
* Standardize "extern" decls on AS_EXTERN

* Rebase & remove from implementation files
2018-06-18 15:53:34 -07:00
Adlai Holler 69e0c096e1 Remove unused/unneeded header macros (#973) 2018-06-18 11:38:02 -07:00
Adlai Holler a11506564a Reduce usage of autorelease pools (#968)
* Reduce reliance on the autorelease pool

* changelog

* A few more places

* Use it in another place
2018-06-15 10:15:25 -07:00
Christian Selig a4dd19d808 Update showcase to include Apollo for Reddit (#967) 2018-06-13 21:35:19 +01:00
Huy Nguyen 42ac10aac3 Fix crash when call needsMainThreadDeallocation on NSProxy instances #trivial (#965) sync-base-07-21-18 2018-06-12 19:32:11 +01:00
Max Wang 5c13cbe7a2 Fix method name typo in _locked_isLayoutTransitionInvalid #trivial (#963) 2018-06-12 08:56:37 +01:00
Adlai Holler f6c5dc31e2 Generalize the main thread ivar dealloc stuff (#959) 2018-06-07 09:41:58 -07:00
Adlai Holler 35d59acd83 Add support for acquiring multiple locks at once (#958)
* Add ASLocking which supports -tryLock and taking multiple locks safely

* Better multi locking

* Assert about lock set capacity
2018-06-05 12:31:30 -07:00
Max Wang 9214e3c2ef Renew supplementary node on relayout (#842)
* fix SIMULATE_WEB_RESPONSE not imported #449

* Fix to make rangeMode update in right time

* Renew supplementary node on relayout.

* Add support for layoutDelegate (ASCollectionLayout).

* revert space

* Update change log

* fix build error

* refactor

* set default size

* return early when can delegate
2018-06-04 10:29:41 -07:00
Adlai Holler 21973c8840 Clean up async transaction system a bit (#955)
* Clean up async transaction system a bit

* Update changelog
2018-06-02 12:28:04 -07:00
Max Wang 9fe2f476a1 add ASTextNode2 snapshot test (#935)
* fix SIMULATE_WEB_RESPONSE not imported #449

* Fix to make rangeMode update in right time

* remove uncessary assert

* textnode2-snapshot-test

* add change log

* fix image recording

* disable recording

* renaming test method

* reset experiment in teardown
2018-06-02 09:01:01 -07:00
Adlai Holler ee06e97e0f Make ASPerformMainThreadDeallocation visible in C (#952)
* Make ASPerformMainThreadDeallocation visible in C

* Update changelog
2018-06-01 13:54:46 -07:00
Malik Kuru 079c11b756 Added 'Waplog' to showcase. (#953) 2018-06-01 23:05:37 +03:00
Adlai Holler 6bdf57210e Cut 2.7 release (#949) 2018-05-29 12:50:28 -07:00
muukii 70eae57640 Update AppIcon in showcase (#946) 2018-05-29 11:54:37 +03:00
Huy Nguyen 8a4bb6cf06 [ASTableView] Generate a new cell layout if existing ones are invalid (#942) 2018-05-28 18:26:01 +03:00
Sagar Bhosale 60e3f97241 Update tip-1-nodeBlocks.md (#943)
collectionView is being replaced with collectionNode.
2018-05-26 08:44:59 -07:00
Max Wang 62b07e100e Match interfacestate update sequence to uikit (#882)
* fix SIMULATE_WEB_RESPONSE not imported #449

* Fix to make rangeMode update in right time

* Match interface update closer to UIKit.

* allow the correct exiting sequence for thrashing

* refactor
2018-05-25 18:21:50 -07:00
Adlai Holler cac14e0bce Standardize Property Declaration Style in Core Classes (#870)
* Audit property attributes for core classes

* Update style guide

* Go crazy

* Update changelog
2018-05-24 14:42:43 -07:00
Garrett Moon 9ccba7fe74 Update to unsplash (#938)
* Switch photos from 500px to Unsplash

* Good bye comment view :(

* Update license headers
2018-05-23 20:47:42 -07:00
Adlai Holler 8b890f07be Create a new dealloc queue that is more efficient (#931)
* Fork dealloc queue in an experiment

* Fix and put back

* Use the right selector

* Go simpler

* Clarify name

* Type inference

* Use CFTypeRefs like a boss

* Improve comments

* License header
2018-05-22 09:06:24 -07:00
appleguy b2e5f9ec64 [ASTextNode2] Simplify compare-assign check & lock _pointScaleFactors accessor #trivial (#934) 2018-05-22 07:58:33 -07:00
Flo ede9a7f929 [ASImageNode+AnimatedImage] Fix early return when animatedImage is nil in setAnimatedImage #trivial (#925)
* [ASNetworkImageNodeTests] Add defaultImage test and improve image test. #trivial

* [ASImageNode+AnimatedImage] Fix early return when animatedImage is nil in setAnimatedImage. #trivial
2018-05-21 13:09:01 -07:00
Huy Nguyen b9ae6c4fa8 [ASDisplayNode] Fix an issue that causes a node to sometimes return an outdated calculated size or size range (#808) 2018-05-21 18:36:19 +01:00
Max Wang 06358d8662 Fix pager node for interface coalescing (#877)
* fix SIMULATE_WEB_RESPONSE not imported #449

* Fix to make rangeMode update in right time

* Fix pager node for interface coalescing

* Fix typo

* change log
2018-05-19 13:52:30 -07:00
appleguy 6799e26b03 [ASTextNode2] Upgrade lock safety by protecting all ivars (including rarely-changed ones). (#918)
* [ASTextNode2] Upgrade lock safety by protecting all ivars (including rarely-changed ones).

Although I don't know of any specific crashes caused by this, I think we should
lock all properties by default. There are also some indications of premature
optimization in keeping lock scope small, where it is actually important to
have transactional integrity, and also where the ASDisplayNode base class is
otherwise going to repeatedly re-lock the object anyway.

I think this will remain pretty efficient, especially with os_unfair_lock enabled.

* Use compare-assign macros
2018-05-19 12:47:06 -07:00
Max Wang 62dd3ca7ce Remove assert. fix #878 #914 (#924)
* fix SIMULATE_WEB_RESPONSE not imported #449

* Fix to make rangeMode update in right time

* remove uncessary assert
2018-05-17 15:55:13 -07:00
Adlai Holler 73cdc1b4e4 Call out to delegate for control users in experiments (#923) 2018-05-16 08:33:28 -07:00
Huy Nguyen 0830f6cf23 [ASCollectionNode/ASTableNode] Fix a crash occurs while remeasuring cell nodes (#917) 2018-05-15 20:18:54 +01:00
Huy Nguyen 970ebd987e Improve thread-safety of ASDisplayNode's didExitHierarchy #trivial (#916)
Since `didExitHierarchy` is called without the node's instance lock being held, the lock must be acquired before accessing `pendingInterfaceState`.
2018-05-11 17:26:00 +01:00
Garrett Moon 3981f1724e #trivial Add forgotten experiment into Schemas/configuration.json (#912) 2018-05-11 17:25:25 +01:00
Abdurahim Jauzee 382f624d83 [ASTextNode] Check variables before calling delegate method #trivial (#898) 2018-05-11 17:24:26 +01:00
everettjf bf48ebd8da replace back quote with "code" in containers-overview.md (#884)
* Update containers-overview.md

* Update containers-overview.md

* Update containers-overview.md
2018-05-11 17:14:22 +01:00
Michael Schneider efe924cca7 Prevent UITextView from updating contentOffset while deallocating (#915)
* Prevent UITextView from updating contentOffset while deallocating

* Add comment on the flag point to the issue
2018-05-09 08:30:03 -07:00
kenstir 4171e767be Fix ASDKgram-Swift to avoid 'error parsing JSON within PhotoModel Init' (#913) 2018-05-08 11:22:25 -07:00
Garrett Moon cb29317300 #trivial Fix the C++ assertion (#911)
* Fix the C++ assertion

* Fix indentation
2018-05-07 15:28:48 -07:00
Adlai Holler d97065ca39 Update configuration schema (#893) 2018-05-05 09:48:19 -07:00
Sudhanshu 8379a451d8 Add 'iDiva - Beauty & Wedding tips' to Showcase (#909)
This change is for adding "iDiva - Beauty & Wedding tips" iOS app to Texture showcase.
2018-05-05 08:30:20 -07:00
Garrett Moon 3677e290aa Issue ASNetworkImageNode callbacks off main thread (#908)
* The main thread is under a bunch of contention on startup, let's avoid using it.

* Update CHANGELOG
2018-05-04 12:21:42 -07:00
appleguy 9de33361dc [ASTextNode] Fix a deadlock that could occur when enabling experimental ASTextNode2 via ASConfiguration (#903)
Because multiple threads can enter this allocWithZone: method around the same time, it is possible for one of them to setSuperclass first, and then the second thread would get stuck in an infinite loop. When climbing the inheritance heirarchy, ASTextNode2 would be encountered by this second thread, and it would continue until reaching c == Nil. Since there was no case to catch this, an infinite loop would result. Then the main thread can be deadlocked if a method like waitUntilAllUpdatesAreProcessed is called on ASCollectionView.
2018-05-03 03:51:59 -07:00