Commit Graph
4622 Commits
Author SHA1 Message Date
Nadine Salter 1e2f39ea09 Merge pull request #16 from mboyd1017/master
Change ASTextNode's userInteractionEnabled default to NO.
2014-08-15 16:46:16 -07:00
Madelaine Boyd a6a2907ad9 userInteractionEnabled defaults to NO
Previously self.userInteractionEnabled defaulted to YES, and this
caused plenty of bugs for me when text nodes would silently steal
touches. It should default to NO, and callers who want tappability on
their text nodes should manually set .userInteractionEnabled to YES.
2014-08-15 12:07:24 -07:00
Arnaud Coomans 5e5cac1b7d Updated README 2014-08-12 14:38:38 -07:00
Nadine Salter a471eca87b Merge pull request #12 from acoomans/development
ASDisplayNode documentation
2014-08-08 22:43:59 -07:00
Arnaud Coomans 9a18a475a7 Fixed documentation 2014-08-08 17:06:57 -07:00
Arnaud Coomans f8a6e8063d Reformatted ASDisplayNode documentation 2014-08-06 18:16:59 -07:00
Nadine Salter aafd0f3514 Update ASTextNode tests for iOS 8 (fixes #10). 2014-08-06 17:21:46 -07:00
Arnaud Coomans 8b8a8fdb0d Files organization 2014-08-05 16:48:46 -07:00
Nadine Salter 07a538a2dc Update comments with correct symbol names (#11).
* ASDisplayNodeAsyncView -> _ASDisplayView
* ASDisplayNodeView -> ASDisplayNodeViewProperties
2014-07-30 15:59:06 -07:00
Nadine Salter 11eb47c87e Update README to reference umbrella header (#9). 2014-07-23 15:19:37 -07:00
Nadine Salter b5f45d698f Merge pull request #9 from toulouse/master
Add umbrella header
2014-07-23 15:18:04 -07:00
Andrew Toulouse 1efe3d95d6 Add umbrella header
Summary:
Import the headers for control, image, and text nodes, as well as the normal display node and helper functions. Subclass headers omitted as they are intended to be imported in subclass implementation files, not public headers.

Test Plan:
`#import <AsyncDisplayKit/AsyncDisplayKit.h>` followed some time later by:
```
ASDisplayNode *node;
ASImageNode *node2;
ASTextNode *node3;
ASControlNode *node4;
```
2014-07-18 00:30:32 -07:00
Nadine Salter 986fa0246a Merge pull request #6 from toulouse/flagNaming
Unify boolean flag naming confention, getter spacing, and property attribute naming
2014-07-17 13:58:26 -07:00
Andrew Toulouse a35c109a08 Unify boolean flag naming confention, getter spacing, and property attribute naming
Summary:
* Fixes #3
* Ordering: atomicity, then [optional] readonly, then value semantics (retain/copy/assign)
* Removed redundant `readwrite`
* No spaces between "getter = name" ("getter=name" instead)
* Property method overrides renamed as well
* self.isBlah, while technically not entirely correct, still resolves to [self blah], so left alone (@kimon had advice on this sort of naming issue last summer), and largely inconsequential

Test Plan:
* Compile and run
2014-07-17 13:18:47 -07:00
Nadine Salter f504ab4d15 Merge pull request #4 from toulouse/master
Export ASThread to unbreak the subclass header files
2014-07-17 12:52:17 -07:00
Andrew Toulouse 0741f89a55 Export ASThread to unbreak the subclass header files
Summary:
* Moves ASThread.h from Private to Public visibility
* Moves ASThread.h from Private/ to Details/
* Changes public #imports from "" to <>

Test Plan:
```
#import <AsyncDisplayKit/ASDisplayNode+Subclasses.h>
#import <AsyncDisplayKit/ASControlNode+Subclasses.h>
```
2014-07-16 15:25:15 -07:00
Nadine Salter 291fa885cc Merge pull request #2 from fastred/format_specifiers
Fix incorrect string format specifier for NSInteger
2014-06-30 14:08:17 -07:00
Arkadiusz Holko 00573e5368 Fix incorrect string format specifier for NSInteger 2014-06-30 22:56:06 +02:00
Nadine Salter 752b084df1 Merge pull request #1 from DanielTomlinson/feature/precision-warnings
Use correct format identifiers for logs on 64 bit systems.
2014-06-27 11:38:28 -07:00
Daniel Tomlinson a38e86f039 Use correct format identifiers for logs on 64 bit systems. 2014-06-27 19:09:27 +01:00
Nadine Salter f59f4c0b63 Minor README tweaks. 1.0beta 2014-06-26 22:43:28 -07:00
Nadine Salter 15565873c9 Initial commit. 2014-06-26 22:32:55 -07:00