feat: BUMP version 1.2.3

feat: Update CHANGELOG file
Merge pull request #78 from hisaac/master
2018-07-25 08:52:15 +02:00 · 2018-07-25 08:50:08 +02:00 · 2018-07-24 15:13:51 +02:00 · 2018-07-24 11:59:13 +02:00 · 2018-07-24 08:34:26 +02:00 · 2018-07-24 08:27:42 +02:00
18 changed files with 75 additions and 27 deletions
@@ -1,6 +1,35 @@
 # Change Log
 All notable changes to this project will be documented in this file

+## [Typo (1.2.3)](https://github.com/Juanpe/SkeletonView/releases/tag/1.2.3)
+
+### Fixes
+
+- Fix typo in `SkeletonTableViewDataSource` protocol
+
+### Improvements
+
+- Now it takes in account the `UIStackView` to calculate the `SkeletonLayer` bounds (thanks @giantramen)
+
+## [New face (1.2.2)](https://github.com/Juanpe/SkeletonView/releases/tag/1.2.2)
+
+### New
+
+- Rebranding
+
+### Bug fixes
+- Solved issue [#23](https://github.com/Juanpe/SkeletonView/issues/23). Problem with UIStackView. (thanks @giantramen)
+
+## [State (1.2.1)](https://github.com/Juanpe/SkeletonView/releases/tag/1.2.1)
+
+### New
+
+- You can set the corner radius multiline elements (thanks @B4V4-G)
+- Save view state when skeleton appears and recovery when it is hidden (@juanpe)
+
+### Bug fixes
+- Solved issue [#51](https://github.com/Juanpe/SkeletonView/issues/51). Support inspectable properties when using Carthage. (thanks @eduardbosch)
+
 ## [On TV (1.2)](https://github.com/Juanpe/SkeletonView/releases/tag/1.2)

 ### New
@@ -15,7 +15,7 @@
 	<key>CFBundlePackageType</key>
 	<string>FMWK</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.2</string>
+	<string>1.2.1</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>
@@ -15,7 +15,7 @@
 	<key>CFBundlePackageType</key>
 	<string>APPL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.2</string>
+	<string>1.2.1</string>
 	<key>CFBundleVersion</key>
 	<string>1</string>
 	<key>LSRequiresIPhoneOS</key>
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="14109" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" useSafeAreas="YES" colorMatched="YES" initialViewController="BYZ-38-t0r">
+<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="14113" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" useSafeAreas="YES" colorMatched="YES" initialViewController="BYZ-38-t0r">
    <device id="retina4_7" orientation="portrait">
        <adaptation id="fullscreen"/>
    </device>
@@ -213,7 +213,7 @@
                </viewController>
                <placeholder placeholderIdentifier="IBFirstResponder" id="dkx-z0-nzr" sceneMemberID="firstResponder"/>
            </objects>
-            <point key="canvasLocation" x="-2481" y="-394"/>
+            <point key="canvasLocation" x="-2582" y="-400"/>
        </scene>
    </scenes>
    <resources>
@@ -136,7 +136,7 @@ extension ViewController: SkeletonTableViewDataSource {
        return 9
    }
    
-    func collectionSkeletonView(_ skeletonView: UITableView, cellIdenfierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier {
+    func collectionSkeletonView(_ skeletonView: UITableView, cellIdentifierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier {
        return "CellIdentifier"
    }
    
@@ -1,4 +1,4 @@
-![](Assets/header.jpg)
+![](Assets/header2.jpg)

 <p align="center">
    <a href="https://travis-ci.org/Juanpe/SkeletonView">
@@ -51,7 +51,7 @@ Enjoy it! 🙂
  * [Hierarchy](#-hierarchy)
 * [Documentation](#-documentation)
 * [Next steps](#-next-steps)
-* [Contributed](#-contributed)
+* [Contributing](#-contributing)
 * [Mentions](#-mentions)
 * [Author](#-author)
 * [License](#-license)
@@ -77,8 +77,6 @@ Enjoy it! 🙂

 To run the example project, clone the repo and run `SkeletonViewExample` target.

-![](Assets/demoApp2.png)
-
 ## 📲 Installation

 #### Using [CocoaPods](https://cocoapods.org)
@@ -173,7 +171,7 @@ If you want to show the skeleton in a ```UITableView```, you need to conform to
 public protocol SkeletonTableViewDataSource: UITableViewDataSource {
    func numSections(in collectionSkeletonView: UITableView) -> Int
    func collectionSkeletonView(_ skeletonView: UITableView, numberOfRowsInSection section: Int) -> Int
-    func collectionSkeletonView(_ skeletonView: UITableView, cellIdenfierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier
+    func collectionSkeletonView(_ skeletonView: UITableView, cellIdentifierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier
 }
 ```
 As you can see, this protocol inherits from ```UITableViewDataSource```, so you can replace this protocol with the skeleton protocol.
@@ -193,12 +191,12 @@ func collectionSkeletonView(_ skeletonView: UITableView, numberOfRowsInSection s

 There is only one method you need to implement to let Skeleton know the cell identifier. This method doesn't have default implementation:
 ``` swift
- func collectionSkeletonView(_ skeletonView: UITableView, cellIdenfierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier
+ func collectionSkeletonView(_ skeletonView: UITableView, cellIdentifierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier
 ```

 **Example**
 ``` swift
- func collectionSkeletonView(_ skeletonView: UITableView, cellIdenfierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier {
+ func collectionSkeletonView(_ skeletonView: UITableView, cellIdentifierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier {
    return "CellIdentifier"
 }
 ```
@@ -231,12 +229,14 @@ Besides, you can decide how many lines you want. If  ```numberOfLines``` is set
 ##### 🎛 Customize

 You can set some properties for multilines elements.
- **Filling percent** of the last line.
-  - values: `0...100`
-  - default: `70%`
- **Corner radius** of lines. (**NEW**)
-  - values: `0...10
-  - default: `0`
+
+
+| Property | Values | Default | Preview
+| ------- | ------- |------- | -------
+| **Filling percent** of the last line. | `0...100` | `70%` | ![](Assets/multiline_lastline.png)
+| **Corner radius** of lines. (**NEW**) | `0...10` | `0` | ![](Assets/multiline_corner.png)
+
+

 To modify the percent or radius **using code**, set the properties:
 ```swift
@@ -313,7 +313,7 @@ view.showAnimatedGradientSkeleton(usingGradient: gradient, animation: animation)
 |------- | -------
 | .leftRight | ![](Assets/sliding_left_to_right.gif)
 | .rightLeft | ![](Assets/sliding_right_to_left.gif)
-| .topBottom | ![](Assets/sliding_top_to_bottom.gif)  
+| .topBottom | ![](Assets/sliding_top_to_bottom.gif)
 | .bottomTop | ![](Assets/sliding_bottom_to_top.gif)
 | .topLeftBottomRight | ![](Assets/sliding_topLeft_to_bottomRight.gif)
 | .bottomRightTopLeft | ![](Assets/sliding_bottomRight_to_topLeft.gif)
@@ -354,7 +354,7 @@ Coming soon...😅
 * [ ] Add animations when it shows/hides the skeletons
 * [ ] MacOS and WatchOS compatible

-## ❤️ Contributed
+## ❤️ Contributing
 This is an open source project, so feel free to contribute. How?
 - Open an [issue](https://github.com/Juanpe/SkeletonView/issues/new).
 - Send feedback via [email](mailto://juanpecatalan.com).
@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
  s.name         = "SkeletonView"
-  s.version      = "1.2"
+  s.version      = "1.2.3"
  s.summary      = "An elegant way to show users that something is happening and also prepare them to which contents he is waiting"
  s.description  = <<-DESC
  Today almost all apps have async processes, as API requests, long runing processes, etc. And while the processes are working, usually developers place a loading view to show users that something is going on.
@@ -36,7 +36,7 @@ extension SkeletonCollectionDataSource: UITableViewDataSource {
    }
    
    func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
-        let cellIdentifier = originalTableViewDataSource?.collectionSkeletonView(tableView, cellIdenfierForRowAt: indexPath) ?? ""
+        let cellIdentifier = originalTableViewDataSource?.collectionSkeletonView(tableView, cellIdentifierForRowAt: indexPath) ?? ""
        let cell = tableView.dequeueReusableCell(withIdentifier: cellIdentifier, for: indexPath)
        return cell
    }
@@ -11,7 +11,7 @@ import UIKit
 public protocol SkeletonTableViewDataSource: UITableViewDataSource {
    func numSections(in collectionSkeletonView: UITableView) -> Int
    func collectionSkeletonView(_ skeletonView: UITableView, numberOfRowsInSection section: Int) -> Int
-    func collectionSkeletonView(_ skeletonView: UITableView, cellIdenfierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier
+    func collectionSkeletonView(_ skeletonView: UITableView, cellIdentifierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier
 }

 public extension SkeletonTableViewDataSource {
@@ -21,6 +21,13 @@ public extension SkeletonTableViewDataSource {
    }
    
    func numSections(in collectionSkeletonView: UITableView) -> Int { return 1 }
+
+    /// Keeping the misspelled version around until it can be deprecated
+    /// Right now, it just calls the new correctly spelled method and returns its result
+    @available(*, deprecated, renamed: "collectionSkeletonView(_:cellIdentifierForRowAt:)")
+    func collectionSkeletonView(_ skeletonView: UITableView, cellIdenfierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier {
+        return collectionSkeletonView(skeletonView, cellIdentifierForRowAt: indexPath)
+    }
 }

 public protocol SkeletonTableViewDelegate: UITableViewDelegate {
@@ -12,6 +12,18 @@ import UIKit
 extension UIView {
    
    var maxBoundsEstimated: CGRect {
+        if let parentStackView = (superview as? UIStackView) {
+            var origin: CGPoint = .zero
+            switch parentStackView.alignment {
+            case .center:
+                origin.x = maxWidthEstimated / 2
+            case .trailing:
+                origin.x = maxWidthEstimated
+            default:
+                break
+            }
+            return CGRect(origin: origin, size: maxSizeEstimated)
+        }
        return CGRect(origin: .zero, size: maxSizeEstimated)
    }
    
@@ -14,14 +14,14 @@ protocol PrepareForSkeleton {

 extension UILabel: PrepareForSkeleton {
    func prepareViewForSkeleton() {
-        text = nil
+        text = " "
        resignFirstResponder()
    }
 }

 extension UITextView: PrepareForSkeleton {
    func prepareViewForSkeleton() {
-        text = nil
+        text = " "
        resignFirstResponder()
    }
 }
@@ -40,7 +40,7 @@ extension UILabel {
    
    override func recoverViewState(forced: Bool) {
        super.recoverViewState(forced: forced)
-        text = text == "" || forced ? viewState?.text : text
+        text = text == " " || forced ? viewState?.text : text
    }
 }

@@ -52,7 +52,7 @@ extension UITextView {
    
    override func recoverViewState(forced: Bool) {
        super.recoverViewState(forced: forced)
-        text = text == "" || forced ? viewState?.text : text
+        text = text == " " || forced ? viewState?.text : text
    }
 }
Author	SHA1	Message	Date
Juanpe Catalán	c2720898ac	feat: BUMP version 1.2.3	2018-07-25 08:52:15 +02:00
Juanpe Catalán	9e395c7747	feat: Update CHANGELOG file	2018-07-25 08:50:08 +02:00
Juanpe Catalán	b8aa587af6	Merge pull request #78 from hisaac/master fix: Typos in README and method signature	2018-07-24 15:13:51 +02:00
Juanpe Catalán	349f7eb48e	Merge pull request #77 from giantramen/master feat: Use Stack View to Calculate Bounds	2018-07-24 11:59:13 +02:00
Juanpe Catalán	4f874a84f0	feat: Bump version 1.2.2	2018-07-24 08:34:26 +02:00
Juanpe Catalán	a6de5342a4	Merge branch 'master' of https://github.com/Juanpe/SkeletonView	2018-07-24 08:27:42 +02:00
Juanpe Catalán	404da95cbe	feat: New branding	2018-07-24 08:27:39 +02:00
Isaac Halvorson	ebe7f3e463	Add default implementation of old method and deprecation message	2018-07-19 10:03:47 -05:00
Isaac Halvorson	ad5cf2a21f	Fix a couple small typos in README and a method signature	2018-07-19 09:37:15 -05:00
Kamin, Grant	7afe87160a	Use Stack View to Calculate Bounds Labels inside of stack views are not aligned properly because we were assuming leading alignment. Calculating the origin based off of the stack view alignment instead.	2018-07-06 09:04:10 -05:00
Juanpe Catalán	7c7be7c80c	Merge pull request #73 from giantramen/master fix: UIStackView Label Issue #23	2018-06-26 16:25:59 +02:00
giantramen	ff42bd02e2	Fix UIStackView Label Issue Fixes issue where SkeletonView sets the text of each label to nil, UIStackView sets the height of each label to 0 and lays them out on top of each other.	2018-06-26 09:20:49 -05:00
Juanpe Catalán	0136c8576c	feat: Update README	2018-06-06 10:36:19 +02:00
Juanpe Catalán	76c526385d	Merge branch 'master' of https://github.com/Juanpe/SkeletonView	2018-06-06 10:20:16 +02:00
Juanpe Catalán	2b633e5ab6	BUMP version 1.2.1	2018-06-06 10:20:12 +02:00
Juanpe Catalán	5c19df67df	Merge pull request #68 from eduardbosch/patch-1 Revert wrong README change	2018-06-06 10:00:59 +02:00
Juanpe Catalán	b1778542d7	Merge pull request #69 from eduardbosch/patch-2 Fix tipo and remove space	2018-06-06 10:00:30 +02:00
Eduard Bosch Bertran	ad5c87eea2	Fix tipo and remove space	2018-06-06 09:32:13 +02:00
Eduard Bosch Bertran	09813e530c	Revert wrong README change I've just reverted a missing ` in the README in this commit https://github.com/Juanpe/SkeletonView/commit/c06ae2d72c640a8fddf520991f3a3b274ad91ffd	2018-06-06 09:28:49 +02:00
Juanpe Catalán	23489159dd	Update CHANGELOG.md	2018-06-05 17:51:11 +02:00