Commit Graph
5141 Commits
Author SHA1 Message Date
Ben Alpert d15938cd92 Clarify use of arrow functions
Per https://github.com/facebook/react/commit/1db20999f0336cfacc6af5ee6f5a77803d74381b#commitcomment-12865588.
2015-08-24 17:21:10 -07:00
Paul O’Shannessy 10c8166043 Merge pull request #4682 from lyip1992/patch-2
Update Gruntfile.js
2015-08-22 16:11:04 -07:00
Paul O’Shannessy 27e5a563db Merge pull request #4684 from lyip1992/patch-3
Update 10.1-animation.md
2015-08-22 16:10:05 -07:00
Paul O’Shannessy d5e5261e38 Merge pull request #4686 from lyip1992/patch-5
Update 06-transferring-props.md
2015-08-22 16:09:02 -07:00
Paul O’Shannessy 7dbcff2df4 Merge pull request #4687 from lyip1992/patch-6
Update 04-multiple-components.md
2015-08-22 16:08:27 -07:00
Paul O’Shannessy cca1065183 Merge pull request #4688 from lyip1992/patch-7
Update 02.3-jsx-gotchas.md
2015-08-22 16:08:02 -07:00
Paul O’Shannessy adfbc64d4b Merge pull request #4685 from lyip1992/patch-4
Update 08.1-more-about-refs.md
2015-08-22 16:07:20 -07:00
Leon Yip 71454365f2 Update 02.3-jsx-gotchas.md
Fix typo.
2015-08-22 00:57:51 -07:00
Leon Yip 2f4ea60571 Update 04-multiple-components.md
Added an extra word to make the sentence read a little easier.
2015-08-22 00:56:23 -07:00
Leon Yip f8fe717ea2 Update 06-transferring-props.md
"This ensures that" sounds a better than "That ensures that." This change is just my personal opinion, so I totally understand my change doesn't get merged.
2015-08-22 00:51:38 -07:00
Leon Yip 3849710d8b Update 08.1-more-about-refs.md
Change render to `render()` for consistency within the paragraph.
2015-08-22 00:46:18 -07:00
Leon Yip c0e21d1b85 Update 10.1-animation.md
Changed "if" to "even when" for clarity.
2015-08-22 00:42:25 -07:00
Leon Yip e99e8b66b2 Update Gruntfile.js
Added punctuation to make the comment consistent with other comments.
2015-08-21 18:06:55 -07:00
Paul O’Shannessy 6508b1ad27 Merge pull request #4678 from ning-github/patch-1
Remove redundancy regarding 'latest React news'
2015-08-21 17:48:57 -07:00
Ning Xia b629289cea Fix repetition by editing second sentence
edited based on paul's input
2015-08-21 16:33:20 -07:00
Jim b36ee449cb Merge pull request #4679 from ning-github/patch-2
Fix typo
2015-08-21 13:28:33 -07:00
Ning Xia 3232a59743 Fix typo
Can not should be a single word: 'cannot'
2015-08-21 13:26:58 -07:00
Ning Xia 5ba1831d76 Remove redundancy regarding 'latest React news'
Previously, it repeated 'latest React news' when the first sentence already begins with the same words.
2015-08-21 13:00:24 -07:00
Ben Alpert 80b7391d64 Merge pull request #2081 from rexxars/search-input-attributes
Allow `results` and `autosave` attributes (WebKit/Blink)
2015-08-21 09:27:06 -07:00
Espen Hovlandsdal 75805e4835 Allow results and autosave attributes (WebKit/Blink) 2015-08-21 10:10:32 +02:00
Paul O’Shannessy b38509cade Merge pull request #4540 from scottburch/ie8-fix
removed dangling comma that messes up loading in IE8
2015-08-20 14:37:20 -07:00
Paul O’Shannessy 0f963bb478 Merge pull request #4654 from zpao/checkversionsoninstall
Check for compatible node,npm versions on install
2015-08-20 14:36:09 -07:00
Ben Alpert 61962c1751 Capitalize Babel 2015-08-20 13:34:04 -07:00
Ben Alpert cd268fdfcd Merge pull request #4546 from rgbkrk/patch-1
Update tooling docs to suggest babel
2015-08-20 13:16:11 -07:00
Kyle Kelley 009902bcd0 Update tooling docs to suggest babel
`react-tools` is deprecated, `babel` is our future

* https://facebook.github.io/react/blog/2015/06/12/deprecating-jstransform-and-react-tools.html
* https://babeljs.io/docs/usage/jsx/
2015-08-20 14:24:20 -05:00
Ben Alpert 5fa72c2659 Merge pull request #4666 from spicyj/prod
Add a simple production-mode sanity check test
2015-08-20 11:03:09 -07:00
Ben Alpert 102fafce7f Add a simple production-mode sanity check test 2015-08-19 22:26:42 -07:00
Ben Alpert ea827eb39d Merge pull request #4561 from djrodgerspryor/css_transition_group_robust_cleanup
Robust animation-end handling in ReactCSSTransitionGroup
2015-08-19 19:15:51 -07:00
Daniel Rodgers-Pryor 6bd6ef208b ReactCSSTransitionGroup timeouts
As discussed in issue 1326
(https://github.com/facebook/react/issues/1326) transitionend events are
unreliable; they may not fire because the element is no longer painted,
the browser tab is no longer focused or for a range of other reasons.
This is particularly harmful during leave transitions since the leaving
element will be permanently stuck in the DOM (and possibly visible).

The ReactCSSTransitionGroup now requires timeouts to be passed in
explicitly for each type of animation. Omitting the timeout duration
for a transition now triggers a PropTypes warning with a link to the
updated documentation.
2015-08-20 11:38:27 +10:00
Ben Alpert b88592a354 Merge pull request #4665 from spicyj/gh-2407
Ensure IE8 style expansion list is up to date
2015-08-19 17:38:32 -07:00
Ben Alpert b126926390 Ensure IE8 style expansion list is up to date
In conjunction with #1953, fixes #2407. This seems to be all of the shorthand style properties that IE8 supports, excluding a few nonstandard ones.
2015-08-19 17:22:37 -07:00
Andreas Svensson f4f22a0baa Apply CSS shorthand expansion to IE8 only
Closes #1953.
2015-08-19 17:17:51 -07:00
Ben Alpert 3de7a281de Merge pull request #4664 from spicyj/ref-docs
Spruce up refs docs
2015-08-19 16:34:44 -07:00
Ben Alpert 1db20999f0 Spruce up refs docs
Fixes #4651.
2015-08-19 16:14:35 -07:00
Ben Alpert 2f96d70087 Merge pull request #4660 from TylerBrock/patch-2
Clarify invocation order of componentDidMount
2015-08-19 11:13:24 -07:00
Paul O’Shannessy 17d5440751 Merge pull request #4567 from koba04/fix-set-boolean-properties
Fixed consistency of behavior boolean properties
2015-08-19 10:20:49 -07:00
Tyler Brock 1e10bb5923 Clarify invocation order of componentDidMount
OP is delivering on promise made here: https://discuss.reactjs.org/t/how-do-you-invoke-the-render-callback-in-jsx/1744
2015-08-19 10:04:34 -07:00
Paul O’Shannessy 50adfeb421 Merge pull request #4657 from zpao/abcorderevents
Re-sort some constants
2015-08-19 09:26:02 -07:00
Paul O’Shannessy ec9b866bc0 Check for compatible node,npm versions on install
This is only for building React and doesnn't apply to production installs.
2015-08-18 23:45:12 -07:00
Paul O’Shannessy eb056fcf5d Re-sort some constants 2015-08-18 22:33:51 -07:00
Ben Alpert 9c98a5998a Merge pull request #4656 from spicyj/jest-fast
hax to make jest fast
2015-08-18 21:45:42 -07:00
Ben Alpert a8b6c8292b hax to make jest fast
Turns out jest is _incredibly_ slow at resolving require paths like `require('fbjs/lib/foo')`. Like several milliseconds per require. Really adds up when all our files require `invariant` and `warning`. Here's a temporary hack to make things fast again.

Test Plan:
```
npm test src/renderers/shared/reconciler/__tests__/ReactCompositeComponent-test.js
```

has a self-proclaimed runtime of ~8 seconds now instead of ~35 seconds.
2015-08-18 21:40:58 -07:00
Jim 2a82689e6e Merge pull request #4655 from levibuzolic/patch-1
Update Advanced Performance code examples so they would output values
2015-08-18 20:57:34 -07:00
Levi Buzolic 009f766d6e Update Advanced Performance code examples so they would output values
Noticed the code examples in *Advanced Performance* wouldn't be rendering the example props, this could lead to some minor confusion for new users.
2015-08-19 13:50:43 +10:00
Sebastian Markbåge 4a92860b00 Merge pull request #4089 from sebmarkbage/killowner
Don't use owner to determine if the auto-bailout should be used
2015-08-18 18:09:01 -07:00
Ben Alpert 81b4f7295d Merge pull request #4611 from spicyj/create-element
Use createElement instead of HTML generation
2015-08-18 18:04:54 -07:00
Ben Alpert cfd6f7a1b8 Use createElement instead of HTML generation
Behind a feature flag. This is a relatively simple change; adopting this strategy universally would mean that we could clean up a lot of code but this doesn't attempt to restructure more than necessary.
2015-08-18 17:44:20 -07:00
Sebastian Markbage 9315517dec Don't use owner to determine if the auto-bailout should be used
I didn't realize that we actually special cased this. This is an
unfortunate heuristic but it helps minimize the harm that this optimization
does.
2015-08-18 17:33:13 -07:00
Ben Alpert 5375b503e9 Merge pull request #4652 from spicyj/no-isre
Remove _isReactElement
2015-08-18 16:41:45 -07:00
Ben Alpert 6663fb3135 Remove _isReactElement
As of this commit, we still support objects as maps so if anyone has an object with keys 'type' and 'props' this will change behavior, but otherwise this should be pretty safe.
2015-08-18 12:55:34 -07:00