mirror of
https://github.com/facebook/react.git
synced 2026-11-18 20:15:56 +00:00
Remove _isReactElement
As of this commit, we still support objects as maps so if anyone has an object with keys 'type' and 'props' this will change behavior, but otherwise this should be pretty safe.
This commit is contained in:
1 parent
b4ee5b5bf1
commit
6663fb3135
2 files changed
+9
-14
No files matched your search
@@ -81,9 +81,7 @@ var ReactElement = function(type, key, ref, self, source, owner, props) {
|
||||
|
||||
// We intentionally don't expose the function on the constructor property.
|
||||
// ReactElement should be indistinguishable from a plain object.
|
||||
ReactElement.prototype = {
|
||||
_isReactElement: true,
|
||||
};
|
||||
ReactElement.prototype = {};
|
||||
|
||||
ReactElement.createElement = function(type, config, children) {
|
||||
var propName;
|
||||
@@ -251,17 +249,12 @@ ReactElement.cloneElement = function(element, config, children) {
|
||||
* @final
|
||||
*/
|
||||
ReactElement.isValidElement = function(object) {
|
||||
// ReactTestUtils is often used outside of beforeEach where as React is
|
||||
// within it. This leads to two different instances of React on the same
|
||||
// page. To identify a element from a different React instance we use
|
||||
// a flag instead of an instanceof check.
|
||||
var isElement = !!(object && object._isReactElement);
|
||||
// if (isElement && !(object instanceof ReactElement)) {
|
||||
// This is an indicator that you're using multiple versions of React at the
|
||||
// same time. This will screw with ownership and stuff. Fix it, please.
|
||||
// TODO: We could possibly warn here.
|
||||
// }
|
||||
return isElement;
|
||||
return !!(
|
||||
typeof object === 'object' &&
|
||||
object != null &&
|
||||
'type' in object &&
|
||||
'props' in object
|
||||
);
|
||||
};
|
||||
|
||||
module.exports = ReactElement;
|
||||
@@ -976,6 +976,8 @@ var ReactMount = {
|
||||
|
||||
getNodeFromInstance: getNodeFromInstance,
|
||||
|
||||
isValid: isValid,
|
||||
|
||||
purgeID: purgeID,
|
||||
};
|
||||
|
||||
|
||||
Reference in new issue
Block a user