mirror of
https://github.com/facebook/react.git
synced 2025-11-01 09:12:30 +00:00
Fix usage of console.error to prevent transform (#24188)
We were suppressing the `react-internals/warning-args` lint rule for the call to `console.error` in `defaultOnRecoverableError`. As far as I could tell, the lint rule exists because on dev builds, we replace all calls to `console.error` with [this error function](https://github.com/facebook/react/blob/main/packages/shared/consoleWithStackDev.js#L31-L37) which expects a format string + args and nothing else. We were trying to pass in an `Error` object directly. After this commit's change, we will still be passing an `Error` but the transform won't occur.
This commit is contained in:
+2
-2
@@ -81,8 +81,8 @@ const defaultOnRecoverableError =
|
||||
reportError
|
||||
: (error: mixed) => {
|
||||
// In older browsers and test environments, fallback to console.error.
|
||||
// eslint-disable-next-line react-internal/no-production-logging, react-internal/warning-args
|
||||
console.error(error);
|
||||
// eslint-disable-next-line react-internal/no-production-logging
|
||||
console['error'](error);
|
||||
};
|
||||
|
||||
function ReactDOMRoot(internalRoot: FiberRoot) {
|
||||
|
||||
Reference in New Issue
Block a user