From fe6e0741286345edb2aa23784c21f8ea611ebdea Mon Sep 17 00:00:00 2001 From: Yash Srivastav Date: Tue, 29 Mar 2022 10:45:14 +0100 Subject: [PATCH] Fix usage of console.error to prevent transform (#24188) We were suppressing the `react-internals/warning-args` lint rule for the call to `console.error` in `defaultOnRecoverableError`. As far as I could tell, the lint rule exists because on dev builds, we replace all calls to `console.error` with [this error function](https://github.com/facebook/react/blob/main/packages/shared/consoleWithStackDev.js#L31-L37) which expects a format string + args and nothing else. We were trying to pass in an `Error` object directly. After this commit's change, we will still be passing an `Error` but the transform won't occur. --- packages/react-dom/src/client/ReactDOMRoot.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-dom/src/client/ReactDOMRoot.js b/packages/react-dom/src/client/ReactDOMRoot.js index c7820a703a..55c340be7d 100644 --- a/packages/react-dom/src/client/ReactDOMRoot.js +++ b/packages/react-dom/src/client/ReactDOMRoot.js @@ -81,8 +81,8 @@ const defaultOnRecoverableError = reportError : (error: mixed) => { // In older browsers and test environments, fallback to console.error. - // eslint-disable-next-line react-internal/no-production-logging, react-internal/warning-args - console.error(error); + // eslint-disable-next-line react-internal/no-production-logging + console['error'](error); }; function ReactDOMRoot(internalRoot: FiberRoot) {