* Write failing test

* Ensure .min and .max are set before .value

* Adjusting test for false negative

* Revert test adjustment (apparently it was only failing locally)

(cherry picked from commit 3013afe2d5)
This commit is contained in:
Troy DeMonbreun
2016-08-15 13:38:53 -05:00
committed by Paul O’Shannessy
parent df4356133d
commit bfb3852942
2 changed files with 6 additions and 2 deletions
@@ -67,6 +67,10 @@ var ReactDOMInput = {
// Make sure we set .step before .value (setting .value before .step
// means .value is rounded on mount, based upon step precision)
step: undefined,
// Make sure we set .min & .max before .value (to ensure proper order
// in corner cases such as min or max deriving from value, e.g. Issue #7170)
min: undefined,
max: undefined,
}, DisabledInputUtils.getHostProps(inst, props), {
defaultChecked: undefined,
defaultValue: undefined,
@@ -733,7 +733,7 @@ describe('ReactDOMInput', function() {
);
});
it('sets type and step before value always', function() {
it('sets type, step, min, max before value always', function() {
if (!ReactDOMFeatureFlags.useCreateElement) {
return;
}
@@ -760,10 +760,10 @@ describe('ReactDOMInput', function() {
'set data-reactroot',
'set type',
'set step',
'set value',
'set min',
'set max',
'set value',
'set value',
'set checked',
'set checked',
]);