mirror of
https://github.com/facebook/react.git
synced 2025-11-01 09:12:30 +00:00
* Write failing test * Ensure .min and .max are set before .value * Adjusting test for false negative * Revert test adjustment (apparently it was only failing locally)
This commit is contained in:
committed by
Brandon Dail
parent
9a48b5ca7b
commit
3013afe2d5
@@ -67,6 +67,10 @@ var ReactDOMInput = {
|
||||
// Make sure we set .step before .value (setting .value before .step
|
||||
// means .value is rounded on mount, based upon step precision)
|
||||
step: undefined,
|
||||
// Make sure we set .min & .max before .value (to ensure proper order
|
||||
// in corner cases such as min or max deriving from value, e.g. Issue #7170)
|
||||
min: undefined,
|
||||
max: undefined,
|
||||
}, DisabledInputUtils.getHostProps(inst, props), {
|
||||
defaultChecked: undefined,
|
||||
defaultValue: undefined,
|
||||
|
||||
@@ -742,7 +742,7 @@ describe('ReactDOMInput', function() {
|
||||
);
|
||||
});
|
||||
|
||||
it('sets type and step before value always', function() {
|
||||
it('sets type, step, min, max before value always', function() {
|
||||
if (!ReactDOMFeatureFlags.useCreateElement) {
|
||||
return;
|
||||
}
|
||||
@@ -769,10 +769,10 @@ describe('ReactDOMInput', function() {
|
||||
'set data-reactroot',
|
||||
'set type',
|
||||
'set step',
|
||||
'set value',
|
||||
'set min',
|
||||
'set max',
|
||||
'set value',
|
||||
'set value',
|
||||
'set checked',
|
||||
'set checked',
|
||||
]);
|
||||
|
||||
Reference in New Issue
Block a user