Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Add helpful message about pooled classes"

Browse Source 
This reverts commit e65f17b86c. This might have a perf impact so we're not going to go with it for now.
This commit is contained in:
Ben Alpert
2014-07-11 16:00:58 -07:00
parent 4526f627f2
commit 92d2dcc25f
1 changed files with 12 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/utils/PooledClass.js
+12 -29
View File
@@ -20,14 +20,6 @@
var invariant = require('invariant');
var ABOUT_POOLING_MESSAGE = null;
if (__DEV__) {
ABOUT_POOLING_MESSAGE = (
'This object is reused for performance reasons. If you\'re seeing this ' +
'after logging an object, try logging individual properties.'
);
}
/**
* Static poolers. Several custom versions for each potential number of
* arguments. A completely generic pooler is easy to implement, but would
@@ -37,54 +29,46 @@ if (__DEV__) {
*/
var oneArgumentPooler = function(copyFieldsFrom) {
var Klass = this;
var instance;
if (Klass.instancePool.length) {
instance = Klass.instancePool.pop();
var instance = Klass.instancePool.pop();
Klass.call(instance, copyFieldsFrom);
return instance;
} else {
instance = new Klass(copyFieldsFrom);
return new Klass(copyFieldsFrom);
}
instance._ABOUT_POOLING = null;
return instance;
};
var twoArgumentPooler = function(a1, a2) {
var Klass = this;
var instance;
if (Klass.instancePool.length) {
instance = Klass.instancePool.pop();
var instance = Klass.instancePool.pop();
Klass.call(instance, a1, a2);
return instance;
} else {
instance = new Klass(a1, a2);
return new Klass(a1, a2);
}
instance._ABOUT_POOLING = null;
return instance;
};
var threeArgumentPooler = function(a1, a2, a3) {
var Klass = this;
var instance;
if (Klass.instancePool.length) {
instance = Klass.instancePool.pop();
var instance = Klass.instancePool.pop();
Klass.call(instance, a1, a2, a3);
return instance;
} else {
instance = new Klass(a1, a2, a3);
return new Klass(a1, a2, a3);
}
instance._ABOUT_POOLING = null;
return instance;
};
var fiveArgumentPooler = function(a1, a2, a3, a4, a5) {
var Klass = this;
var instance;
if (Klass.instancePool.length) {
instance = Klass.instancePool.pop();
var instance = Klass.instancePool.pop();
Klass.call(instance, a1, a2, a3, a4, a5);
return instance;
} else {
instance = new Klass(a1, a2, a3, a4, a5);
return new Klass(a1, a2, a3, a4, a5);
}
instance._ABOUT_POOLING = null;
return instance;
};
var standardReleaser = function(instance) {
@@ -96,7 +80,6 @@ var standardReleaser = function(instance) {
if (instance.destructor) {
instance.destructor();
}
instance._ABOUT_POOLING = ABOUT_POOLING_MESSAGE;
if (Klass.instancePool.length < Klass.poolSize) {
Klass.instancePool.push(instance);
}