From 92d2dcc25fa049d125a2c0dc82a98e1ce98e1a89 Mon Sep 17 00:00:00 2001 From: Ben Alpert Date: Fri, 11 Jul 2014 16:00:58 -0700 Subject: [PATCH] Revert "Add helpful message about pooled classes" This reverts commit e65f17b86cdfbe04453766161d5159203e672a7f. This might have a perf impact so we're not going to go with it for now. --- src/utils/PooledClass.js | 41 ++++++++++++---------------------------- 1 file changed, 12 insertions(+), 29 deletions(-) diff --git a/src/utils/PooledClass.js b/src/utils/PooledClass.js index 606c28e8ee..e1ed2b100c 100644 --- a/src/utils/PooledClass.js +++ b/src/utils/PooledClass.js @@ -20,14 +20,6 @@ var invariant = require('invariant'); -var ABOUT_POOLING_MESSAGE = null; -if (__DEV__) { - ABOUT_POOLING_MESSAGE = ( - 'This object is reused for performance reasons. If you\'re seeing this ' + - 'after logging an object, try logging individual properties.' - ); -} - /** * Static poolers. Several custom versions for each potential number of * arguments. A completely generic pooler is easy to implement, but would @@ -37,54 +29,46 @@ if (__DEV__) { */ var oneArgumentPooler = function(copyFieldsFrom) { var Klass = this; - var instance; if (Klass.instancePool.length) { - instance = Klass.instancePool.pop(); + var instance = Klass.instancePool.pop(); Klass.call(instance, copyFieldsFrom); + return instance; } else { - instance = new Klass(copyFieldsFrom); + return new Klass(copyFieldsFrom); } - instance._ABOUT_POOLING = null; - return instance; }; var twoArgumentPooler = function(a1, a2) { var Klass = this; - var instance; if (Klass.instancePool.length) { - instance = Klass.instancePool.pop(); + var instance = Klass.instancePool.pop(); Klass.call(instance, a1, a2); + return instance; } else { - instance = new Klass(a1, a2); + return new Klass(a1, a2); } - instance._ABOUT_POOLING = null; - return instance; }; var threeArgumentPooler = function(a1, a2, a3) { var Klass = this; - var instance; if (Klass.instancePool.length) { - instance = Klass.instancePool.pop(); + var instance = Klass.instancePool.pop(); Klass.call(instance, a1, a2, a3); + return instance; } else { - instance = new Klass(a1, a2, a3); + return new Klass(a1, a2, a3); } - instance._ABOUT_POOLING = null; - return instance; }; var fiveArgumentPooler = function(a1, a2, a3, a4, a5) { var Klass = this; - var instance; if (Klass.instancePool.length) { - instance = Klass.instancePool.pop(); + var instance = Klass.instancePool.pop(); Klass.call(instance, a1, a2, a3, a4, a5); + return instance; } else { - instance = new Klass(a1, a2, a3, a4, a5); + return new Klass(a1, a2, a3, a4, a5); } - instance._ABOUT_POOLING = null; - return instance; }; var standardReleaser = function(instance) { @@ -96,7 +80,6 @@ var standardReleaser = function(instance) { if (instance.destructor) { instance.destructor(); } - instance._ABOUT_POOLING = ABOUT_POOLING_MESSAGE; if (Klass.instancePool.length < Klass.poolSize) { Klass.instancePool.push(instance); }