Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

[react-ui] Remove event object warnings (#16822)

Browse Source
This commit is contained in:
Dominic Gannaway
2019-09-19 12:46:17 +02:00
committed by GitHub
parent a5df18a9e5
commit 924a305780
2 changed files with 0 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-dom/src/events/DOMEventResponderSystem.js
Vendored
-10
View File
@@ -303,16 +303,6 @@ function validateEventValue(eventValue: any): void {
);
}
};
eventValue.preventDefault = () => {
if (__DEV__) {
showWarning('preventDefault()');
}
};
eventValue.stopPropagation = () => {
if (__DEV__) {
showWarning('stopPropagation()');
}
};
eventValue.isDefaultPrevented = () => {
if (__DEV__) {
showWarning('isDefaultPrevented()');
packages/react-dom/src/events/__tests__/DOMEventResponderSystem-test.internal.js
-24
View File
@@ -837,30 +837,6 @@ describe('DOMEventResponderSystem', () => {
</button>
);
};
expect(() => {
handler = event => {
event.preventDefault();
};
ReactDOM.render(<Test />, container);
dispatchClickEvent(buttonRef.current);
}).toWarnDev(
'Warning: preventDefault() is not available on event objects created from event responder modules ' +
'(React Flare).' +
' Try wrapping in a conditional, i.e. `if (event.type !== "press") { event.preventDefault() }`',
{withoutStack: true},
);
expect(() => {
handler = event => {
event.stopPropagation();
};
ReactDOM.render(<Test />, container);
dispatchClickEvent(buttonRef.current);
}).toWarnDev(
'Warning: stopPropagation() is not available on event objects created from event responder modules ' +
'(React Flare).' +
' Try wrapping in a conditional, i.e. `if (event.type !== "press") { event.stopPropagation() }`',
{withoutStack: true},
);
expect(() => {
handler = event => {
event.isDefaultPrevented();