From 924a305780eb71866eb0932027048237b6f5c3cd Mon Sep 17 00:00:00 2001 From: Dominic Gannaway Date: Thu, 19 Sep 2019 12:46:17 +0200 Subject: [PATCH] [react-ui] Remove event object warnings (#16822) --- .../src/events/DOMEventResponderSystem.js | 10 -------- .../DOMEventResponderSystem-test.internal.js | 24 ------------------- 2 files changed, 34 deletions(-) diff --git a/packages/react-dom/src/events/DOMEventResponderSystem.js b/packages/react-dom/src/events/DOMEventResponderSystem.js index c2a0c089c0..14bd5f5fff 100644 --- a/packages/react-dom/src/events/DOMEventResponderSystem.js +++ b/packages/react-dom/src/events/DOMEventResponderSystem.js @@ -303,16 +303,6 @@ function validateEventValue(eventValue: any): void { ); } }; - eventValue.preventDefault = () => { - if (__DEV__) { - showWarning('preventDefault()'); - } - }; - eventValue.stopPropagation = () => { - if (__DEV__) { - showWarning('stopPropagation()'); - } - }; eventValue.isDefaultPrevented = () => { if (__DEV__) { showWarning('isDefaultPrevented()'); diff --git a/packages/react-dom/src/events/__tests__/DOMEventResponderSystem-test.internal.js b/packages/react-dom/src/events/__tests__/DOMEventResponderSystem-test.internal.js index 90605b9f61..83f17d0c17 100644 --- a/packages/react-dom/src/events/__tests__/DOMEventResponderSystem-test.internal.js +++ b/packages/react-dom/src/events/__tests__/DOMEventResponderSystem-test.internal.js @@ -837,30 +837,6 @@ describe('DOMEventResponderSystem', () => { ); }; - expect(() => { - handler = event => { - event.preventDefault(); - }; - ReactDOM.render(, container); - dispatchClickEvent(buttonRef.current); - }).toWarnDev( - 'Warning: preventDefault() is not available on event objects created from event responder modules ' + - '(React Flare).' + - ' Try wrapping in a conditional, i.e. `if (event.type !== "press") { event.preventDefault() }`', - {withoutStack: true}, - ); - expect(() => { - handler = event => { - event.stopPropagation(); - }; - ReactDOM.render(, container); - dispatchClickEvent(buttonRef.current); - }).toWarnDev( - 'Warning: stopPropagation() is not available on event objects created from event responder modules ' + - '(React Flare).' + - ' Try wrapping in a conditional, i.e. `if (event.type !== "press") { event.stopPropagation() }`', - {withoutStack: true}, - ); expect(() => { handler = event => { event.isDefaultPrevented();