 Gustavo Gard
|
8b9b3f605e
|
Correct AnimatedValueXY URL
Summary:
Correct URL
Closes https://github.com/facebook/react-native/pull/18556
Differential Revision: D7396357
Pulled By: mdvacca
fbshipit-source-id: f8ff6c9b037fe733cf3be8d1b889d1dcd9c94afb
|
2018-03-25 20:01:30 -07:00 |
|
|
Gustavo Gard
|
8547b7e111
|
Correct logo URL
Summary:
Added static files to remove dependency with `react` website, related PR https://github.com/facebook/react-native/pull/16204
After is merged to master, check if all the URLs are working correctly.
TheSavior
Closes https://github.com/facebook/react-native/pull/16207
Differential Revision: D6509133
Pulled By: hramos
fbshipit-source-id: a31dcc07742211dc17046e7e98d805c2282f2a82
|
2017-12-07 08:31:38 -08:00 |
|
|
Gustavo Gard
|
eca331937e
|
"subject" field for Share
Summary:
Add field `subject` to `Options` when Share.
Check https://github.com/facebook/react-native/blob/9ee815f6b52e0c2417c04e5a05e1e31df26daed2/Libraries/ActionSheetIOS/ActionSheetIOS.js#L52
iOS:
The field `subject` is obtained from `Options`
https://github.com/facebook/react-native/blob/1e8f3b11027fe0a7514b4fc97d0798d3c64bc895/Libraries/ActionSheetIOS/RCTActionSheetManager.m#L159
**iOS:**
Tested the following components `ActionSheetIOS` and `Share` using RNTester
**Android**
Don't use the key `subject`
Check https://github.com/facebook/react-native/blob/1e8f3b11027fe0a7514b4fc97d0798d3c64bc895/ReactAndroid/src/main/java/com/facebook/react/modules/share/ShareModule.java#L52
Closes https://github.com/facebook/react-native/pull/15800
Differential Revision: D6060998
Pulled By: hramos
fbshipit-source-id: fd06f680a4705989e397c5700d8ab35aa7129ba6
|
2017-10-23 11:32:44 -07:00 |
|
|
Gustavo Gard
|
dbe6044074
|
Correct propTypes for placeholder
Summary:
Proptype mistake, placeholder is a "string" not a "node".
https://github.com/facebook/react-native/blob/1e8f3b11027fe0a7514b4fc97d0798d3c64bc895/Libraries/Text/RCTBackedTextInputViewProtocol.h#L18
https://github.com/facebook/react-native/blob/4d54b48167c99d0f3a8917e7637ffe3304c6bed6/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java#L300
Closes https://github.com/facebook/react-native/pull/16237
Differential Revision: D6017909
Pulled By: shergin
fbshipit-source-id: 75046080a0f33196832f5d4ab58f8b1f4aabad1f
|
2017-10-09 22:31:24 -07:00 |
|
|
Gustavo Gard
|
57b4f49db0
|
Remove broken links
Summary:
Issue https://github.com/facebook/react-native/issues/16255
Remove broken links
Closes https://github.com/facebook/react-native/pull/16262
Differential Revision: D6017751
Pulled By: hramos
fbshipit-source-id: a9465a8a8212dc7b5e1aae21c73b46e60e24c10e
|
2017-10-09 22:02:09 -07:00 |
|
|
Gustavo Gard
|
2d2dfa26bc
|
Correct logo URL
Summary:
Update logo URL
https://facebook.github.io/react/img/logo_og.png (old) to https://facebook.github.io/react/logo-og.png (new)
Check that the old URL shows a "Page Not Found" and the new URL the correct image.
Closes https://github.com/facebook/react-native/pull/16204
Differential Revision: D5978967
Pulled By: TheSavior
fbshipit-source-id: f6af03dfd25d68c96e01054c256d8b6ba9fedba2
|
2017-10-04 14:38:02 -07:00 |
|
