Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Correct propTypes for placeholder

Browse Source 
Summary:
Proptype mistake, placeholder is a "string" not a "node".

https://github.com/facebook/react-native/blob/1e8f3b11027fe0a7514b4fc97d0798d3c64bc895/Libraries/Text/RCTBackedTextInputViewProtocol.h#L18

https://github.com/facebook/react-native/blob/4d54b48167c99d0f3a8917e7637ffe3304c6bed6/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java#L300
Closes https://github.com/facebook/react-native/pull/16237

Differential Revision: D6017909

Pulled By: shergin

fbshipit-source-id: 75046080a0f33196832f5d4ab58f8b1f4aabad1f
This commit is contained in:
Gustavo Gard
2017-10-09 22:31:24 -07:00
committed by Facebook Github Bot
parent 7a7bdeec3e
commit dbe6044074
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Libraries/Components/TextInput/TextInput.js
+1 -1
View File
@@ -430,7 +430,7 @@ const TextInput = createReactClass({
/**
* The string that will be rendered before text input has been entered.
*/
placeholder: PropTypes.node,
placeholder: PropTypes.string,
/**
* The text color of the placeholder string.
*/