Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary addTimeAnnotation method from performance logger

Browse Source 
Summary:
Changelog:
[Internal][Removed] Removed `addTimeAnnotation` method from performance loggers

Reviewed By: lunaleaps

Differential Revision: D23758816

fbshipit-source-id: 98e0abae25266f3dcc5953f25f20cde8e3dac190
This commit is contained in:
Rubén Norte
2020-09-18 07:14:16 -07:00
committed by Facebook GitHub Bot
parent 4d842963fa
commit fc4f667cde
2 changed files with 8 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Libraries/Utilities/__tests__/PerformanceLogger-test.js
+6 -10
View File
@@ -15,8 +15,6 @@ import createPerformanceLogger from '../createPerformanceLogger';
import type {IPerformanceLogger} from '../createPerformanceLogger';
const TIMESPAN_1 = '<timespan_1>';
const TIMESPAN_2 = '<timespan_2>';
const TIMESPAN_2_DURATION = 123;
const EXTRA_KEY = '<extra_key>';
const EXTRA_VALUE = '<extra_value>';
const EXTRA_VALUE_2 = '<extra_value_2>';
@@ -29,16 +27,16 @@ describe('PerformanceLogger', () => {
GlobalPerformanceLogger.clear();
});
it('starts & stops and adds a timespan', () => {
it('starts & stops a timespan', () => {
let perfLogger = createPerformanceLogger();
perfLogger.startTimespan(TIMESPAN_1);
perfLogger.stopTimespan(TIMESPAN_1);
perfLogger.addTimeAnnotation(TIMESPAN_2, TIMESPAN_2_DURATION);
expect(perfLogger.hasTimespan(TIMESPAN_1)).toBe(true);
expect(perfLogger.hasTimespan(TIMESPAN_2)).toBe(true);
expect(perfLogger.getTimespans()[TIMESPAN_2].totalTime).toBe(
TIMESPAN_2_DURATION,
);
expect(perfLogger.getTimespans()[TIMESPAN_1]).toEqual({
startTime: expect.any(Number),
endTime: expect.any(Number),
totalTime: expect.any(Number),
});
});
it('does not override a timespan', () => {
@@ -47,8 +45,6 @@ describe('PerformanceLogger', () => {
let old = perfLogger.getTimespans()[TIMESPAN_1];
perfLogger.startTimespan(TIMESPAN_1);
expect(perfLogger.getTimespans()[TIMESPAN_1]).toBe(old);
perfLogger.addTimeAnnotation(TIMESPAN_1, 1);
expect(perfLogger.getTimespans()[TIMESPAN_1]).toBe(old);
});
it('adds a timespan with start and end timestamps', () => {
Libraries/Utilities/createPerformanceLogger.js
+2 -19
View File
@@ -17,16 +17,15 @@ const performanceNow: () => number =
global.nativeQPLTimestamp ?? global.performance.now.bind(global.performance);
type Timespan = {
totalTime?: number,
startTime?: number,
startTime: number,
endTime?: number,
totalTime?: number,
};
// Extra values should be serializable primitives
type ExtraValue = number | string | boolean;
export interface IPerformanceLogger {
addTimeAnnotation(key: string, durationInMs: number): void;
addTimespan(key: string, startTime: number, endTime: number): void;
startTimespan(key: string): void;
stopTimespan(key: string, options?: {update?: boolean}): void;
@@ -52,22 +51,6 @@ class PerformanceLogger implements IPerformanceLogger {
_extras: {[key: string]: ExtraValue} = {};
_points: {[key: string]: number} = {};
addTimeAnnotation(key: string, durationInMs: number) {
if (this._timespans[key]) {
if (PRINT_TO_CONSOLE && __DEV__) {
infoLog(
'PerformanceLogger: Attempting to add a timespan that already exists ',
key,
);
}
return;
}
this._timespans[key] = {
totalTime: durationInMs,
};
}
addTimespan(key: string, startTime: number, endTime: number) {
if (this._timespans[key]) {
if (PRINT_TO_CONSOLE && __DEV__) {