From fc4f667cdeb024cf5b251964166d0f642dcd1153 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rub=C3=A9n=20Norte?= <rubennorte@fb.com>
Date: Fri, 18 Sep 2020 07:11:17 -0700
Subject: [PATCH] Remove unnecessary addTimeAnnotation method from performance
 logger

Summary:
Changelog:
[Internal][Removed] Removed `addTimeAnnotation` method from performance loggers

Reviewed By: lunaleaps

Differential Revision: D23758816

fbshipit-source-id: 98e0abae25266f3dcc5953f25f20cde8e3dac190
---
 .../__tests__/PerformanceLogger-test.js       | 16 ++++++--------
 .../Utilities/createPerformanceLogger.js      | 21 ++-----------------
 2 files changed, 8 insertions(+), 29 deletions(-)

diff --git a/Libraries/Utilities/__tests__/PerformanceLogger-test.js b/Libraries/Utilities/__tests__/PerformanceLogger-test.js
index 651c6f0f47a..ea940f10947 100644
--- a/Libraries/Utilities/__tests__/PerformanceLogger-test.js
+++ b/Libraries/Utilities/__tests__/PerformanceLogger-test.js
@@ -15,8 +15,6 @@ import createPerformanceLogger from '../createPerformanceLogger';
 import type {IPerformanceLogger} from '../createPerformanceLogger';
 
 const TIMESPAN_1 = '<timespan_1>';
-const TIMESPAN_2 = '<timespan_2>';
-const TIMESPAN_2_DURATION = 123;
 const EXTRA_KEY = '<extra_key>';
 const EXTRA_VALUE = '<extra_value>';
 const EXTRA_VALUE_2 = '<extra_value_2>';
@@ -29,16 +27,16 @@ describe('PerformanceLogger', () => {
     GlobalPerformanceLogger.clear();
   });
 
-  it('starts & stops and adds a timespan', () => {
+  it('starts & stops a timespan', () => {
     let perfLogger = createPerformanceLogger();
     perfLogger.startTimespan(TIMESPAN_1);
     perfLogger.stopTimespan(TIMESPAN_1);
-    perfLogger.addTimeAnnotation(TIMESPAN_2, TIMESPAN_2_DURATION);
     expect(perfLogger.hasTimespan(TIMESPAN_1)).toBe(true);
-    expect(perfLogger.hasTimespan(TIMESPAN_2)).toBe(true);
-    expect(perfLogger.getTimespans()[TIMESPAN_2].totalTime).toBe(
-      TIMESPAN_2_DURATION,
-    );
+    expect(perfLogger.getTimespans()[TIMESPAN_1]).toEqual({
+      startTime: expect.any(Number),
+      endTime: expect.any(Number),
+      totalTime: expect.any(Number),
+    });
   });
 
   it('does not override a timespan', () => {
@@ -47,8 +45,6 @@ describe('PerformanceLogger', () => {
     let old = perfLogger.getTimespans()[TIMESPAN_1];
     perfLogger.startTimespan(TIMESPAN_1);
     expect(perfLogger.getTimespans()[TIMESPAN_1]).toBe(old);
-    perfLogger.addTimeAnnotation(TIMESPAN_1, 1);
-    expect(perfLogger.getTimespans()[TIMESPAN_1]).toBe(old);
   });
 
   it('adds a timespan with start and end timestamps', () => {
diff --git a/Libraries/Utilities/createPerformanceLogger.js b/Libraries/Utilities/createPerformanceLogger.js
index 643493b936f..e98b516be35 100644
--- a/Libraries/Utilities/createPerformanceLogger.js
+++ b/Libraries/Utilities/createPerformanceLogger.js
@@ -17,16 +17,15 @@ const performanceNow: () => number =
   global.nativeQPLTimestamp ?? global.performance.now.bind(global.performance);
 
 type Timespan = {
-  totalTime?: number,
-  startTime?: number,
+  startTime: number,
   endTime?: number,
+  totalTime?: number,
 };
 
 // Extra values should be serializable primitives
 type ExtraValue = number | string | boolean;
 
 export interface IPerformanceLogger {
-  addTimeAnnotation(key: string, durationInMs: number): void;
   addTimespan(key: string, startTime: number, endTime: number): void;
   startTimespan(key: string): void;
   stopTimespan(key: string, options?: {update?: boolean}): void;
@@ -52,22 +51,6 @@ class PerformanceLogger implements IPerformanceLogger {
   _extras: {[key: string]: ExtraValue} = {};
   _points: {[key: string]: number} = {};
 
-  addTimeAnnotation(key: string, durationInMs: number) {
-    if (this._timespans[key]) {
-      if (PRINT_TO_CONSOLE && __DEV__) {
-        infoLog(
-          'PerformanceLogger: Attempting to add a timespan that already exists ',
-          key,
-        );
-      }
-      return;
-    }
-
-    this._timespans[key] = {
-      totalTime: durationInMs,
-    };
-  }
-
   addTimespan(key: string, startTime: number, endTime: number) {
     if (this._timespans[key]) {
       if (PRINT_TO_CONSOLE && __DEV__) {