mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
fix: correctly assign name to both begin and end events for measures (#53588)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/53588 # Changelog: [Internal] Since the `name` was already moved for the begin event, there is nothing to be moved for `end` event. Instead, we will be creating a copy for the `begin` event. This was actually affecting some entries on a timeline, like component triggers (yellow ones). Reviewed By: vzaidman Differential Revision: D81589847 fbshipit-source-id: 3b7d801d3429217ce279ed7de41c40c3838a5f37
This commit is contained in:
committed by
Facebook GitHub Bot
parent
8d8452173a
commit
f9cecc5f00
@@ -445,7 +445,7 @@ void PerformanceTracer::enqueueTraceEventsFromPerformanceTracerEvent(
|
||||
|
||||
events.emplace_back(TraceEvent{
|
||||
.id = eventId,
|
||||
.name = std::move(event.name),
|
||||
.name = event.name,
|
||||
.cat = "blink.user_timing",
|
||||
.ph = 'b',
|
||||
.ts = event.start,
|
||||
|
||||
Reference in New Issue
Block a user