From f9cecc5f00f0a6008d32ad2ff2e8d3cc654e9c58 Mon Sep 17 00:00:00 2001 From: Ruslan Lesiutin Date: Wed, 3 Sep 2025 10:11:41 -0700 Subject: [PATCH] fix: correctly assign name to both begin and end events for measures (#53588) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/53588 # Changelog: [Internal] Since the `name` was already moved for the begin event, there is nothing to be moved for `end` event. Instead, we will be creating a copy for the `begin` event. This was actually affecting some entries on a timeline, like component triggers (yellow ones). Reviewed By: vzaidman Differential Revision: D81589847 fbshipit-source-id: 3b7d801d3429217ce279ed7de41c40c3838a5f37 --- .../jsinspector-modern/tracing/PerformanceTracer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.cpp b/packages/react-native/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.cpp index 238003fd393..80db2a1dce1 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.cpp +++ b/packages/react-native/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.cpp @@ -445,7 +445,7 @@ void PerformanceTracer::enqueueTraceEventsFromPerformanceTracerEvent( events.emplace_back(TraceEvent{ .id = eventId, - .name = std::move(event.name), + .name = event.name, .cat = "blink.user_timing", .ph = 'b', .ts = event.start,