Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disable localhostBundleURL check in testBundleURL, without breaking stable

Browse Source 
Summary:
This test was disabled in e106112202 to allow unit tests to run on Facebook's internal CI. The change was reverted in 1f6de88230 because another internal test was broken when it found that mainBundleURL() was not getting called.

In this commit, I've commented out the actual piece of code that would cause unit tests to fail in Facebook's internal CI, without removing the call to mainBundleURL(). The localhostBundleURL() method is called elsewhere in the file, so commenting it out here should not cause any issues.

Changelog:
[iOS] [Changed] - Disable testBundleURL test.

Reviewed By: cpojer

Differential Revision: D15049238

fbshipit-source-id: da3a393922f2190b423980cac5ab54df5e7e3e41
This commit is contained in:
Héctor Ramos
2019-04-24 09:26:56 -07:00
committed by Facebook Github Bot
parent e9adbb58ba
commit f1086b8c5b
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
RNTester/RNTesterUnitTests/RCTBundleURLProviderTests.m
+4 -2
View File
@@ -71,8 +71,10 @@ static NSURL *ipBundleURL()
NSURL *URL = [settings jsBundleURLForBundleRoot:testFile fallbackResource:nil];
if (!getenv("CI_USE_PACKAGER")) {
XCTAssertEqualObjects(URL, mainBundleURL());
} else {
XCTAssertEqualObjects(URL, localhostBundleURL());
// TODO: t43430850: Temporarily disable testBundleURL test.
// To be re-enabled when the packager can be reliably used on Sandcastle.
// } else {
// XCTAssertEqualObjects(URL, localhostBundleURL());
}
}