From f1086b8c5bca55692468fa8a9812e4aeaaecb1d1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A9ctor=20Ramos?= Date: Wed, 24 Apr 2019 09:26:56 -0700 Subject: [PATCH] Disable localhostBundleURL check in testBundleURL, without breaking stable Summary: This test was disabled in e106112202f9b805162d2b814ddf14ab29a0f97b to allow unit tests to run on Facebook's internal CI. The change was reverted in 1f6de88230ffd076e57838dbad7b48b71b1be6a0 because another internal test was broken when it found that mainBundleURL() was not getting called. In this commit, I've commented out the actual piece of code that would cause unit tests to fail in Facebook's internal CI, without removing the call to mainBundleURL(). The localhostBundleURL() method is called elsewhere in the file, so commenting it out here should not cause any issues. Changelog: [iOS] [Changed] - Disable testBundleURL test. Reviewed By: cpojer Differential Revision: D15049238 fbshipit-source-id: da3a393922f2190b423980cac5ab54df5e7e3e41 --- RNTester/RNTesterUnitTests/RCTBundleURLProviderTests.m | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/RNTester/RNTesterUnitTests/RCTBundleURLProviderTests.m b/RNTester/RNTesterUnitTests/RCTBundleURLProviderTests.m index b1f7c204c7b..89585a5f083 100644 --- a/RNTester/RNTesterUnitTests/RCTBundleURLProviderTests.m +++ b/RNTester/RNTesterUnitTests/RCTBundleURLProviderTests.m @@ -71,8 +71,10 @@ static NSURL *ipBundleURL() NSURL *URL = [settings jsBundleURLForBundleRoot:testFile fallbackResource:nil]; if (!getenv("CI_USE_PACKAGER")) { XCTAssertEqualObjects(URL, mainBundleURL()); - } else { - XCTAssertEqualObjects(URL, localhostBundleURL()); + // TODO: t43430850: Temporarily disable testBundleURL test. + // To be re-enabled when the packager can be reliably used on Sandcastle. + // } else { + // XCTAssertEqualObjects(URL, localhostBundleURL()); } }