Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fabric: Removing some code leftovers from RCTComponentViewRegistry

Browse Source 
Summary:
The removed code is fragments of one of failed approches to implement the functionality of RCTMountingTransactionObserverCoordinator.

Changelog: [Internal] Fabric-specific internal change.

Reviewed By: sammy-SC

Differential Revision: D18567733

fbshipit-source-id: cd7d6abc91394a2755866c35ff43d2c4f0271470
This commit is contained in:
Valentin Shergin
2019-11-18 18:22:35 -08:00
committed by Facebook Github Bot
parent ccc05cd054
commit e4a23f72d5
1 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
React/Fabric/Mounting/RCTComponentViewRegistry.mm
-12
View File
@@ -77,8 +77,6 @@ const NSInteger RCTComponentViewRegistryRecyclePoolMaxSize = 1024;
@implementation RCTComponentViewRegistry {
better::map<Tag, RCTComponentViewDescriptor> _registry;
better::map<ComponentHandle, std::vector<RCTComponentViewDescriptor>> _recyclePool;
std::unordered_set<RCTComponentViewDescriptor> _mountingTransactionObservers;
}
- (instancetype)init
@@ -135,11 +133,6 @@ const NSInteger RCTComponentViewRegistryRecyclePoolMaxSize = 1024;
_registry.insert({tag, componentViewDescriptor});
if (componentViewDescriptor.observesMountingTransactionDidMount ||
componentViewDescriptor.observesMountingTransactionWillMount) {
_mountingTransactionObservers.insert(componentViewDescriptor);
}
#ifdef LEGACY_UIMANAGER_INTEGRATION_ENABLED
[RCTUIManager registerView:componentViewDescriptor.view];
#endif
@@ -160,11 +153,6 @@ const NSInteger RCTComponentViewRegistryRecyclePoolMaxSize = 1024;
[RCTUIManager unregisterView:componentViewDescriptor.view];
#endif
if (componentViewDescriptor.observesMountingTransactionDidMount ||
componentViewDescriptor.observesMountingTransactionWillMount) {
_mountingTransactionObservers.erase(componentViewDescriptor);
}
_registry.erase(tag);
componentViewDescriptor.view.tag = 0;
[self _enqueueComponentViewWithComponentHandle:componentHandle componentViewDescriptor:componentViewDescriptor];