From e4a23f72d5ab714b3efd1418ff0a72a382c1934b Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Mon, 18 Nov 2019 18:22:35 -0800 Subject: [PATCH] Fabric: Removing some code leftovers from RCTComponentViewRegistry Summary: The removed code is fragments of one of failed approches to implement the functionality of RCTMountingTransactionObserverCoordinator. Changelog: [Internal] Fabric-specific internal change. Reviewed By: sammy-SC Differential Revision: D18567733 fbshipit-source-id: cd7d6abc91394a2755866c35ff43d2c4f0271470 --- React/Fabric/Mounting/RCTComponentViewRegistry.mm | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/React/Fabric/Mounting/RCTComponentViewRegistry.mm b/React/Fabric/Mounting/RCTComponentViewRegistry.mm index a274af78d45..23d08cef831 100644 --- a/React/Fabric/Mounting/RCTComponentViewRegistry.mm +++ b/React/Fabric/Mounting/RCTComponentViewRegistry.mm @@ -77,8 +77,6 @@ const NSInteger RCTComponentViewRegistryRecyclePoolMaxSize = 1024; @implementation RCTComponentViewRegistry { better::map _registry; better::map> _recyclePool; - - std::unordered_set _mountingTransactionObservers; } - (instancetype)init @@ -135,11 +133,6 @@ const NSInteger RCTComponentViewRegistryRecyclePoolMaxSize = 1024; _registry.insert({tag, componentViewDescriptor}); - if (componentViewDescriptor.observesMountingTransactionDidMount || - componentViewDescriptor.observesMountingTransactionWillMount) { - _mountingTransactionObservers.insert(componentViewDescriptor); - } - #ifdef LEGACY_UIMANAGER_INTEGRATION_ENABLED [RCTUIManager registerView:componentViewDescriptor.view]; #endif @@ -160,11 +153,6 @@ const NSInteger RCTComponentViewRegistryRecyclePoolMaxSize = 1024; [RCTUIManager unregisterView:componentViewDescriptor.view]; #endif - if (componentViewDescriptor.observesMountingTransactionDidMount || - componentViewDescriptor.observesMountingTransactionWillMount) { - _mountingTransactionObservers.erase(componentViewDescriptor); - } - _registry.erase(tag); componentViewDescriptor.view.tag = 0; [self _enqueueComponentViewWithComponentHandle:componentHandle componentViewDescriptor:componentViewDescriptor];