Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix inconsistent-missing-destructor-override warning

Browse Source 
Summary: Changelog: [internal]

Reviewed By: neildhar, jpporto

Differential Revision: D37454445

fbshipit-source-id: 423fa99f91e54ade807a56169204c523ad1f9d20
This commit is contained in:
Pieter De Baets
2022-06-29 12:56:01 -07:00
committed by Facebook GitHub Bot
parent 4d62e0d2bf
commit e23520bb56
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/cxxreact/JSBigString.h
+2 -2
View File
@@ -82,7 +82,7 @@ class RN_EXPORT JSBigBufferString : public JSBigString {
m_data[m_size] = '\0';
}
~JSBigBufferString() {
~JSBigBufferString() override {
delete[] m_data;
}
@@ -111,7 +111,7 @@ class RN_EXPORT JSBigBufferString : public JSBigString {
class RN_EXPORT JSBigFileString : public JSBigString {
public:
JSBigFileString(int fd, size_t size, off_t offset = 0);
~JSBigFileString();
~JSBigFileString() override;
bool isAscii() const override {
return true;
ReactCommon/hermes/inspector/RuntimeAdapter.h
+1 -1
View File
@@ -66,7 +66,7 @@ class INSPECTOR_EXPORT SharedRuntimeAdapter : public RuntimeAdapter {
SharedRuntimeAdapter(
std::shared_ptr<jsi::Runtime> runtime,
debugger::Debugger &debugger);
virtual ~SharedRuntimeAdapter();
~SharedRuntimeAdapter() override;
jsi::Runtime &getRuntime() override;
debugger::Debugger &getDebugger() override;