From e23520bb567f5956b59fb5381ff4de3f1caaaf4f Mon Sep 17 00:00:00 2001 From: Pieter De Baets Date: Wed, 29 Jun 2022 12:56:01 -0700 Subject: [PATCH] Fix inconsistent-missing-destructor-override warning Summary: Changelog: [internal] Reviewed By: neildhar, jpporto Differential Revision: D37454445 fbshipit-source-id: 423fa99f91e54ade807a56169204c523ad1f9d20 --- ReactCommon/cxxreact/JSBigString.h | 4 ++-- ReactCommon/hermes/inspector/RuntimeAdapter.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ReactCommon/cxxreact/JSBigString.h b/ReactCommon/cxxreact/JSBigString.h index 14ce3464c4d..bd7297e992c 100644 --- a/ReactCommon/cxxreact/JSBigString.h +++ b/ReactCommon/cxxreact/JSBigString.h @@ -82,7 +82,7 @@ class RN_EXPORT JSBigBufferString : public JSBigString { m_data[m_size] = '\0'; } - ~JSBigBufferString() { + ~JSBigBufferString() override { delete[] m_data; } @@ -111,7 +111,7 @@ class RN_EXPORT JSBigBufferString : public JSBigString { class RN_EXPORT JSBigFileString : public JSBigString { public: JSBigFileString(int fd, size_t size, off_t offset = 0); - ~JSBigFileString(); + ~JSBigFileString() override; bool isAscii() const override { return true; diff --git a/ReactCommon/hermes/inspector/RuntimeAdapter.h b/ReactCommon/hermes/inspector/RuntimeAdapter.h index 361c54c62f7..c0788247023 100644 --- a/ReactCommon/hermes/inspector/RuntimeAdapter.h +++ b/ReactCommon/hermes/inspector/RuntimeAdapter.h @@ -66,7 +66,7 @@ class INSPECTOR_EXPORT SharedRuntimeAdapter : public RuntimeAdapter { SharedRuntimeAdapter( std::shared_ptr runtime, debugger::Debugger &debugger); - virtual ~SharedRuntimeAdapter(); + ~SharedRuntimeAdapter() override; jsi::Runtime &getRuntime() override; debugger::Debugger &getDebugger() override;