Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Support Slide Over and Split View on iPad (#36255)

Browse Source 
Summary:
Context: We have been looking at more multi-window on iPad bugs and issues for React Native. One is that the default test app currently doesn't support SlideOver / Split View / MultiWindow. This change should support the first two of those configurations.

This mirrors a change we had done in React Native Test App: https://github.com/microsoft/react-native-test-app/pull/1032/
In order to support Slide Over and Split View on iPad, the app must support all 4 orientations.

Note, this does not support multi-window, which would require RNTester to be refactored to use a `SceneDelegate`. React Native Test app already does this: https://github.com/microsoft/react-native-test-app/blob/trunk/ios/ReactTestApp/SceneDelegate.swift

## Changelog

[INTERNAL] [CHANGED] - Support Slide Over and Split View on iPad for RNTester

Pull Request resolved: https://github.com/facebook/react-native/pull/36255

Test Plan:
Ran RNTester and tested both configurations.

https://user-images.githubusercontent.com/6722175/220747910-9bf43d10-055e-4d46-a98c-5e3b24641700.mov

Reviewed By: NickGerleman

Differential Revision: D43655607

Pulled By: javache

fbshipit-source-id: 4829a11accaddacc6ffa4cc77fb2f54a26f08382
This commit is contained in:
Saad Najmi
2023-02-28 13:46:02 -08:00
committed by Facebook GitHub Bot
parent 32d03c250c
commit d4b228b956
1 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/rn-tester/RNTester/Info.plist
+2 -11
View File
@@ -2,16 +2,6 @@
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>LSApplicationQueriesSchemes</key>
<array>
<string>tel</string>
<string>telprompt</string>
<string>http</string>
<string>fb</string>
<string>geo</string>
</array>
<key>UIStatusBarStyle</key>
<string>UIStatusBarStyleBlackTranslucent</string>
<key>CFBundleDevelopmentRegion</key>
<string>en</string>
<key>CFBundleExecutable</key>
@@ -60,9 +50,10 @@
</array>
<key>UISupportedInterfaceOrientations</key>
<array>
<string>UIInterfaceOrientationPortrait</string>
<string>UIInterfaceOrientationLandscapeLeft</string>
<string>UIInterfaceOrientationLandscapeRight</string>
<string>UIInterfaceOrientationPortrait</string>
<string>UIInterfaceOrientationPortraitUpsideDown</string>
</array>
<key>UIViewControllerBasedStatusBarAppearance</key>
<false/>