From d4b228b956e225e170f6fcaebea923841ec0e142 Mon Sep 17 00:00:00 2001 From: Saad Najmi Date: Tue, 28 Feb 2023 13:46:02 -0800 Subject: [PATCH] Support Slide Over and Split View on iPad (#36255) Summary: Context: We have been looking at more multi-window on iPad bugs and issues for React Native. One is that the default test app currently doesn't support SlideOver / Split View / MultiWindow. This change should support the first two of those configurations. This mirrors a change we had done in React Native Test App: https://github.com/microsoft/react-native-test-app/pull/1032/ In order to support Slide Over and Split View on iPad, the app must support all 4 orientations. Note, this does not support multi-window, which would require RNTester to be refactored to use a `SceneDelegate`. React Native Test app already does this: https://github.com/microsoft/react-native-test-app/blob/trunk/ios/ReactTestApp/SceneDelegate.swift ## Changelog [INTERNAL] [CHANGED] - Support Slide Over and Split View on iPad for RNTester Pull Request resolved: https://github.com/facebook/react-native/pull/36255 Test Plan: Ran RNTester and tested both configurations. https://user-images.githubusercontent.com/6722175/220747910-9bf43d10-055e-4d46-a98c-5e3b24641700.mov Reviewed By: NickGerleman Differential Revision: D43655607 Pulled By: javache fbshipit-source-id: 4829a11accaddacc6ffa4cc77fb2f54a26f08382 --- packages/rn-tester/RNTester/Info.plist | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/packages/rn-tester/RNTester/Info.plist b/packages/rn-tester/RNTester/Info.plist index 788e4d6193c..0542ca74710 100644 --- a/packages/rn-tester/RNTester/Info.plist +++ b/packages/rn-tester/RNTester/Info.plist @@ -2,16 +2,6 @@ - LSApplicationQueriesSchemes - - tel - telprompt - http - fb - geo - - UIStatusBarStyle - UIStatusBarStyleBlackTranslucent CFBundleDevelopmentRegion en CFBundleExecutable @@ -60,9 +50,10 @@ UISupportedInterfaceOrientations - UIInterfaceOrientationPortrait UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight + UIInterfaceOrientationPortrait + UIInterfaceOrientationPortraitUpsideDown UIViewControllerBasedStatusBarAppearance