Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Pass the hermestag file to the read function (#37231)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37231

In a previous diff, we tried to disambiguate between versions of hermes engine by reading the hermestag file.

However, we forgot to pass the file to the `read` function.

It used to work both on main and on CI because that file doesn't exists in those environments. But it failed as soon as we tried to test a release.

## Changelog:
[iOS][Fixed] - Pass the hermestag file to the `read` function.

Reviewed By: dmytrorykun

Differential Revision: D45530010

fbshipit-source-id: 2dcdb77adad375d2e28dd4230ab05dbb85fb82e5
This commit is contained in:
Riccardo Cipolleschi
2023-05-03 09:14:40 -07:00
committed by Facebook GitHub Bot
parent ab3a2f4ad9
commit d1d8fdf4ca
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/scripts/cocoapods/jsengine.rb
+1 -1
View File
@@ -33,7 +33,7 @@ def setup_hermes!(react_native_path: "../node_modules/react-native", fabric_enab
# This `:tag => hermestag` below is only to tell CocoaPods to update hermes-engine when React Native version changes.
# We have custom logic to compute the source for hermes-engine. See sdks/hermes-engine/*
hermestag_file = File.join(react_native_path, "sdks", ".hermesversion")
hermestag = File.exist?(hermestag_file) ? File.read().strip : ''
hermestag = File.exist?(hermestag_file) ? File.read(hermestag_file).strip : ''
pod 'hermes-engine', :podspec => "#{react_native_path}/sdks/hermes-engine/hermes-engine.podspec", :tag => hermestag
pod 'React-hermes', :path => "#{react_native_path}/ReactCommon/hermes"
pod 'libevent', '~> 2.1.12'