Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disable flaky windows test for ReactFabricPublicInstance-test.js (#37216)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37216

Yet another windows flaky test for ReactFabricPublicInstance-test.js which I'm disabling now. It will still run on linux/mac.

Changelog:
[Internal] [Changed] - Disable flaky windows test for ReactFabricPublicInstance-test.js

Reviewed By: cipolleschi

Differential Revision: D45521018

fbshipit-source-id: b37c00d674997e14fd8e12c3f3746f51bcc90669
This commit is contained in:
Nicola Corti
2023-05-03 08:33:20 -07:00
committed by Facebook GitHub Bot
parent 86436270ab
commit ab3a2f4ad9
1 changed files with 21 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/Libraries/ReactNative/ReactFabricPublicInstance/__tests__/ReactFabricPublicInstance-test.js
Vendored
+21 -18
View File
@@ -215,7 +215,7 @@ async function mockRenderKeys(
});
describe('measureLayout', () => {
test('component.measureLayout(component, ...) invokes callback', async () => {
it('component.measureLayout(component, ...) invokes callback', async () => {
const result = await mockRenderKeys([['foo', 'bar']]);
const fooRef = nullthrows(result?.[0]?.[0]);
const barRef = nullthrows(result?.[0]?.[1]);
@@ -230,7 +230,7 @@ async function mockRenderKeys(
expect(successCallback.mock.calls).toEqual([[1, 1, 100, 100]]);
});
test('unmounted.measureLayout(component, ...) does nothing', async () => {
it('unmounted.measureLayout(component, ...) does nothing', async () => {
const result = await mockRenderKeys([
['foo', 'bar'],
['foo', null],
@@ -248,25 +248,28 @@ async function mockRenderKeys(
expect(successCallback).not.toHaveBeenCalled();
});
test('component.measureLayout(unmounted, ...) does nothing', async () => {
const result = await mockRenderKeys([
['foo', 'bar'],
[null, 'bar'],
]);
const fooRef = nullthrows(result?.[0]?.[0]);
const barRef = nullthrows(result?.[0]?.[1]);
itif(!isWindows)(
'component.measureLayout(unmounted, ...) does nothing',
async () => {
const result = await mockRenderKeys([
['foo', 'bar'],
[null, 'bar'],
]);
const fooRef = nullthrows(result?.[0]?.[0]);
const barRef = nullthrows(result?.[0]?.[1]);
const successCallback = jest.fn();
const failureCallback = jest.fn();
fooRef.measureLayout(barRef, successCallback, failureCallback);
const successCallback = jest.fn();
const failureCallback = jest.fn();
fooRef.measureLayout(barRef, successCallback, failureCallback);
expect(
nullthrows(FabricUIManager.getFabricUIManager()).measureLayout,
).not.toHaveBeenCalled();
expect(successCallback).not.toHaveBeenCalled();
});
expect(
nullthrows(FabricUIManager.getFabricUIManager()).measureLayout,
).not.toHaveBeenCalled();
expect(successCallback).not.toHaveBeenCalled();
},
);
test('unmounted.measureLayout(unmounted, ...) does nothing', async () => {
it('unmounted.measureLayout(unmounted, ...) does nothing', async () => {
const result = await mockRenderKeys([['foo', 'bar'], null]);
const fooRef = nullthrows(result?.[0]?.[0]);
const barRef = nullthrows(result?.[0]?.[1]);