mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Properly export the hermes tarball path to reuse it in RNTester (#44931)
Summary: While working on GHA, I realized that RNTester is not reusing the hermes package we create in the previous steps. This change should fix that, saving ~5 minute per RNTester test as it does not have to rebuild hermes every time. ## Changelog: [Internal] - Improve CI to reuse hermes tarballs Pull Request resolved: https://github.com/facebook/react-native/pull/44931 Test Plan: | Before | After | | --- | --- | | <img width="847" alt="Screenshot 2024-06-13 at 16 02 32" src="https://github.com/facebook/react-native/assets/11162307/099fd2d4-0954-4e64-baf0-6322e02d57bb"> | <img width="1203" alt="Screenshot 2024-06-13 at 16 34 20" src="https://github.com/facebook/react-native/assets/11162307/f8b9f9b6-0bd3-4ea4-8acd-3a4c1bffbc88"> | Reviewed By: cortinico Differential Revision: D58530335 Pulled By: cipolleschi fbshipit-source-id: e711ae8affd78a4da4b64e6092cfffafd40589e5
This commit is contained in:
committed by
Facebook GitHub Bot
parent
7bd98eecd0
commit
c7d3220f4d
@@ -60,11 +60,6 @@ runs:
|
||||
exit 0
|
||||
fi
|
||||
|
||||
if [ ! -d ~/react-native ]; then
|
||||
echo "No React Native checkout found. Run `checkout` first."
|
||||
exit 0
|
||||
fi
|
||||
|
||||
TARBALL_FILENAME=$(node ./packages/react-native/scripts/hermes/get-tarball-name.js --buildType "${{ inputs.flavor }}")
|
||||
TARBALL_PATH=$HERMES_TARBALL_ARTIFACTS_DIR/$TARBALL_FILENAME
|
||||
|
||||
@@ -102,6 +97,8 @@ runs:
|
||||
run: |
|
||||
if [[ ${{ inputs.jsengine }} == "JSC" ]]; then
|
||||
export USE_HERMES=0
|
||||
else
|
||||
export HERMES_ENGINE_TARBALL_PATH=$HERMES_ENGINE_TARBALL_PATH
|
||||
fi
|
||||
|
||||
if [[ ${{ inputs.use-frameworks }} == "DynamicFrameworks" ]]; then
|
||||
|
||||
Reference in New Issue
Block a user