From c7d3220f4dd960c570d8bb492147fe29ec20d1fe Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Fri, 14 Jun 2024 04:42:15 -0700 Subject: [PATCH] Properly export the hermes tarball path to reuse it in RNTester (#44931) Summary: While working on GHA, I realized that RNTester is not reusing the hermes package we create in the previous steps. This change should fix that, saving ~5 minute per RNTester test as it does not have to rebuild hermes every time. ## Changelog: [Internal] - Improve CI to reuse hermes tarballs Pull Request resolved: https://github.com/facebook/react-native/pull/44931 Test Plan: | Before | After | | --- | --- | | Screenshot 2024-06-13 at 16 02 32 | Screenshot 2024-06-13 at 16 34 20 | Reviewed By: cortinico Differential Revision: D58530335 Pulled By: cipolleschi fbshipit-source-id: e711ae8affd78a4da4b64e6092cfffafd40589e5 --- .github/actions/test_ios_rntester/action.yml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/actions/test_ios_rntester/action.yml b/.github/actions/test_ios_rntester/action.yml index 53637a4b0f1..3f339734c9d 100644 --- a/.github/actions/test_ios_rntester/action.yml +++ b/.github/actions/test_ios_rntester/action.yml @@ -60,11 +60,6 @@ runs: exit 0 fi - if [ ! -d ~/react-native ]; then - echo "No React Native checkout found. Run `checkout` first." - exit 0 - fi - TARBALL_FILENAME=$(node ./packages/react-native/scripts/hermes/get-tarball-name.js --buildType "${{ inputs.flavor }}") TARBALL_PATH=$HERMES_TARBALL_ARTIFACTS_DIR/$TARBALL_FILENAME @@ -102,6 +97,8 @@ runs: run: | if [[ ${{ inputs.jsengine }} == "JSC" ]]; then export USE_HERMES=0 + else + export HERMES_ENGINE_TARBALL_PATH=$HERMES_ENGINE_TARBALL_PATH fi if [[ ${{ inputs.use-frameworks }} == "DynamicFrameworks" ]]; then