Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent implicit conversion to boolean

Browse Source 
Summary:
changelog: [internal]

This looks like a bug where the author did not intend the conversion to boolean. This means that `onlyMutationIsUpdate` was evaluated to true even if more than 1 animation was in the vector.

Reviewed By: RSNara

Differential Revision: D30767172

fbshipit-source-id: 0ef47b65a5d8ef07d774d9e0b358e5642dc0a9ea
This commit is contained in:
Samuel Susla
2021-09-12 08:56:32 -07:00
committed by Facebook GitHub Bot
parent 1e4f364f87
commit c6e203bdb0
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.cpp
+1 -1
View File
@@ -785,7 +785,7 @@ LayoutAnimationKeyFrameManager::pullTransaction(
// don't want to queue up any final UPDATE mutations here.
bool shouldGenerateSyntheticMutations =
keyFrame.generateFinalSyntheticMutations;
bool numFinalMutations = keyFrame.finalMutationsForKeyFrame.size();
auto numFinalMutations = keyFrame.finalMutationsForKeyFrame.size();
bool onlyMutationIsUpdate =
(numFinalMutations == 1 &&
keyFrame.finalMutationsForKeyFrame[0].type ==