mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Cover idlecallbacks with Stable API guards (#58139)
Summary: Pull Request resolved: https://github.com/react/react-native/pull/58139 Classifies `react/nativemodule/idlecallbacks:idlecallbacks` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to the module's single exported header (`NativeIdleCallbacks.h`), and wires the guard dependency into BUCK, CMake, and the podspec. The podspec needs no `USE_FRAMEWORKS` header search path edit: its existing `$(PODS_TARGET_SRCROOT)/../../..` already resolves to `ReactCommon`, so `<react/cxxstableapi/...>` is on the path. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D117333873 fbshipit-source-id: d5d51baa78f4568c3445de12144dfd419660165d
This commit is contained in:
1 parent
16f8889908
commit
c148be6ece
3 files changed
+4
No files matched your search
@@ -15,6 +15,7 @@ target_include_directories(react_nativemodule_idlecallbacks PUBLIC ${REACT_COMMO
|
||||
target_link_libraries(react_nativemodule_idlecallbacks
|
||||
react_codegen_rncore
|
||||
react_cxxreact
|
||||
react_cxxstableapi
|
||||
react_renderer_runtimescheduler
|
||||
)
|
||||
target_compile_reactnative_options(react_nativemodule_idlecallbacks PRIVATE)
|
||||
|
||||
+2
@@ -7,6 +7,8 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/PrivateGuard.h>
|
||||
|
||||
#if __has_include("FBReactNativeSpecJSI.h") // CocoaPod headers on Apple
|
||||
#include "FBReactNativeSpecJSI.h"
|
||||
#else
|
||||
|
||||
+1
@@ -50,6 +50,7 @@ Pod::Spec.new do |s|
|
||||
s.dependency "ReactCommon/turbomodule/core"
|
||||
s.dependency "React-bridging"
|
||||
s.dependency "React-runtimescheduler"
|
||||
s.dependency "React-cxxstableapi"
|
||||
add_dependency(s, "React-RCTFBReactNativeSpec")
|
||||
add_dependency(s, "React-runtimeexecutor", :additional_framework_paths => ["platform/ios"])
|
||||
|
||||
|
||||
Reference in new issue
Block a user