From c148be6ece5f987ceffff69ae9c779806ae93b8f Mon Sep 17 00:00:00 2001 From: Jakub Piasecki Date: Wed, 2 Sep 2026 11:41:15 -0700 Subject: [PATCH] Cover `idlecallbacks` with Stable API guards (#58139) Summary: Pull Request resolved: https://github.com/react/react-native/pull/58139 Classifies `react/nativemodule/idlecallbacks:idlecallbacks` as a private target under the C++ stable API three-tier visibility model. Adds `#include ` to the module's single exported header (`NativeIdleCallbacks.h`), and wires the guard dependency into BUCK, CMake, and the podspec. The podspec needs no `USE_FRAMEWORKS` header search path edit: its existing `$(PODS_TARGET_SRCROOT)/../../..` already resolves to `ReactCommon`, so `` is on the path. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D117333873 fbshipit-source-id: d5d51baa78f4568c3445de12144dfd419660165d --- .../ReactCommon/react/nativemodule/idlecallbacks/CMakeLists.txt | 1 + .../react/nativemodule/idlecallbacks/NativeIdleCallbacks.h | 2 ++ .../idlecallbacks/React-idlecallbacksnativemodule.podspec | 1 + 3 files changed, 4 insertions(+) diff --git a/packages/react-native/ReactCommon/react/nativemodule/idlecallbacks/CMakeLists.txt b/packages/react-native/ReactCommon/react/nativemodule/idlecallbacks/CMakeLists.txt index 4114bb58198..408708a6735 100644 --- a/packages/react-native/ReactCommon/react/nativemodule/idlecallbacks/CMakeLists.txt +++ b/packages/react-native/ReactCommon/react/nativemodule/idlecallbacks/CMakeLists.txt @@ -15,6 +15,7 @@ target_include_directories(react_nativemodule_idlecallbacks PUBLIC ${REACT_COMMO target_link_libraries(react_nativemodule_idlecallbacks react_codegen_rncore react_cxxreact + react_cxxstableapi react_renderer_runtimescheduler ) target_compile_reactnative_options(react_nativemodule_idlecallbacks PRIVATE) diff --git a/packages/react-native/ReactCommon/react/nativemodule/idlecallbacks/NativeIdleCallbacks.h b/packages/react-native/ReactCommon/react/nativemodule/idlecallbacks/NativeIdleCallbacks.h index 8ac5fc627c2..0a8a5c27dde 100644 --- a/packages/react-native/ReactCommon/react/nativemodule/idlecallbacks/NativeIdleCallbacks.h +++ b/packages/react-native/ReactCommon/react/nativemodule/idlecallbacks/NativeIdleCallbacks.h @@ -7,6 +7,8 @@ #pragma once +#include + #if __has_include("FBReactNativeSpecJSI.h") // CocoaPod headers on Apple #include "FBReactNativeSpecJSI.h" #else diff --git a/packages/react-native/ReactCommon/react/nativemodule/idlecallbacks/React-idlecallbacksnativemodule.podspec b/packages/react-native/ReactCommon/react/nativemodule/idlecallbacks/React-idlecallbacksnativemodule.podspec index a12c8829341..6f40cb29657 100644 --- a/packages/react-native/ReactCommon/react/nativemodule/idlecallbacks/React-idlecallbacksnativemodule.podspec +++ b/packages/react-native/ReactCommon/react/nativemodule/idlecallbacks/React-idlecallbacksnativemodule.podspec @@ -50,6 +50,7 @@ Pod::Spec.new do |s| s.dependency "ReactCommon/turbomodule/core" s.dependency "React-bridging" s.dependency "React-runtimescheduler" + s.dependency "React-cxxstableapi" add_dependency(s, "React-RCTFBReactNativeSpec") add_dependency(s, "React-runtimeexecutor", :additional_framework_paths => ["platform/ios"])