Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Correct "does not exists" in Animated error messages (#37930)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37930

# Changelog:
[Internal] -

Was looking at some [crash report](https://github.com/facebook/react-native/pull/37927) on Github and noticed that error message has a grammar error.

Searching the code revealed three more, all in Animated.

This calms down my OCD :)

Reviewed By: sammy-SC

Differential Revision: D46792795

fbshipit-source-id: 5fcf78e38d5d1540d3699e81bbf4ba036fb5c74d
This commit is contained in:
Ruslan Shestopalyuk
2023-06-16 06:23:09 -07:00
committed by Facebook GitHub Bot
parent 1525c5f342
commit bd3d07773f
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.m
+1 -1
View File
@@ -346,7 +346,7 @@ static NSString *RCTNormalizeAnimatedEventName(NSString *eventName)
RCTAnimatedNode *node = _animationNodes[nodeTag];
if (!node) {
RCTLogError(@"Animated node with tag %@ does not exists", nodeTag);
RCTLogError(@"Animated node with tag %@ does not exist", nodeTag);
return;
}
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/PropsAnimatedNode.java
+1 -1
View File
@@ -97,7 +97,7 @@ import java.util.Map;
for (Map.Entry<String, Integer> entry : mPropNodeMapping.entrySet()) {
@Nullable AnimatedNode node = mNativeAnimatedNodesManager.getNodeById(entry.getValue());
if (node == null) {
throw new IllegalArgumentException("Mapped property node does not exists");
throw new IllegalArgumentException("Mapped property node does not exist");
} else if (node instanceof StyleAnimatedNode) {
((StyleAnimatedNode) node).collectViewUpdates(mPropMap);
} else if (node instanceof ValueAnimatedNode) {
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/StyleAnimatedNode.java
+1 -1
View File
@@ -38,7 +38,7 @@ import java.util.Map;
for (Map.Entry<String, Integer> entry : mPropMapping.entrySet()) {
@Nullable AnimatedNode node = mNativeAnimatedNodesManager.getNodeById(entry.getValue());
if (node == null) {
throw new IllegalArgumentException("Mapped style node does not exists");
throw new IllegalArgumentException("Mapped style node does not exist");
} else if (node instanceof TransformAnimatedNode) {
((TransformAnimatedNode) node).collectViewUpdates(propsMap);
} else if (node instanceof ValueAnimatedNode) {
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/TransformAnimatedNode.java
+1 -1
View File
@@ -66,7 +66,7 @@ import java.util.List;
int nodeTag = ((AnimatedTransformConfig) transformConfig).mNodeTag;
AnimatedNode node = mNativeAnimatedNodesManager.getNodeById(nodeTag);
if (node == null) {
throw new IllegalArgumentException("Mapped style node does not exists");
throw new IllegalArgumentException("Mapped style node does not exist");
} else if (node instanceof ValueAnimatedNode) {
value = ((ValueAnimatedNode) node).getValue();
} else {