From bd3d07773fe331c393b70975c25e5cbbaf426a95 Mon Sep 17 00:00:00 2001 From: Ruslan Shestopalyuk Date: Fri, 16 Jun 2023 06:23:09 -0700 Subject: [PATCH] Correct "does not exists" in Animated error messages (#37930) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/37930 # Changelog: [Internal] - Was looking at some [crash report](https://github.com/facebook/react-native/pull/37927) on Github and noticed that error message has a grammar error. Searching the code revealed three more, all in Animated. This calms down my OCD :) Reviewed By: sammy-SC Differential Revision: D46792795 fbshipit-source-id: 5fcf78e38d5d1540d3699e81bbf4ba036fb5c74d --- .../Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.m | 2 +- .../java/com/facebook/react/animated/PropsAnimatedNode.java | 2 +- .../java/com/facebook/react/animated/StyleAnimatedNode.java | 2 +- .../java/com/facebook/react/animated/TransformAnimatedNode.java | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.m b/packages/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.m index a272dcc8ded..b3669766ea0 100644 --- a/packages/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.m +++ b/packages/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.m @@ -346,7 +346,7 @@ static NSString *RCTNormalizeAnimatedEventName(NSString *eventName) RCTAnimatedNode *node = _animationNodes[nodeTag]; if (!node) { - RCTLogError(@"Animated node with tag %@ does not exists", nodeTag); + RCTLogError(@"Animated node with tag %@ does not exist", nodeTag); return; } diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/PropsAnimatedNode.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/PropsAnimatedNode.java index ff722adbb24..d34624b5410 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/PropsAnimatedNode.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/PropsAnimatedNode.java @@ -97,7 +97,7 @@ import java.util.Map; for (Map.Entry entry : mPropNodeMapping.entrySet()) { @Nullable AnimatedNode node = mNativeAnimatedNodesManager.getNodeById(entry.getValue()); if (node == null) { - throw new IllegalArgumentException("Mapped property node does not exists"); + throw new IllegalArgumentException("Mapped property node does not exist"); } else if (node instanceof StyleAnimatedNode) { ((StyleAnimatedNode) node).collectViewUpdates(mPropMap); } else if (node instanceof ValueAnimatedNode) { diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/StyleAnimatedNode.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/StyleAnimatedNode.java index ae4b70c215d..478fb34aa4a 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/StyleAnimatedNode.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/StyleAnimatedNode.java @@ -38,7 +38,7 @@ import java.util.Map; for (Map.Entry entry : mPropMapping.entrySet()) { @Nullable AnimatedNode node = mNativeAnimatedNodesManager.getNodeById(entry.getValue()); if (node == null) { - throw new IllegalArgumentException("Mapped style node does not exists"); + throw new IllegalArgumentException("Mapped style node does not exist"); } else if (node instanceof TransformAnimatedNode) { ((TransformAnimatedNode) node).collectViewUpdates(propsMap); } else if (node instanceof ValueAnimatedNode) { diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/TransformAnimatedNode.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/TransformAnimatedNode.java index 8b3ec593d4e..1664bb18f2f 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/TransformAnimatedNode.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/TransformAnimatedNode.java @@ -66,7 +66,7 @@ import java.util.List; int nodeTag = ((AnimatedTransformConfig) transformConfig).mNodeTag; AnimatedNode node = mNativeAnimatedNodesManager.getNodeById(nodeTag); if (node == null) { - throw new IllegalArgumentException("Mapped style node does not exists"); + throw new IllegalArgumentException("Mapped style node does not exist"); } else if (node instanceof ValueAnimatedNode) { value = ((ValueAnimatedNode) node).getValue(); } else {