Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make TurboModuleManager not implement JSIModule (#42060)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/42060

For removal of JSIModule getting rid of the inheritance relationship b/w interfaces TurboModuleManager & JSIModule by directly defining `invalidate()`. `initialize()` here isn't being used hence not defining it.

Changelog:
[Internal] internal

Reviewed By: philIip, mdvacca

Differential Revision: D49977957

fbshipit-source-id: 8de644b1f344d8ce8d4a78655556829f860a2b10
This commit is contained in:
Arushi Kesarwani
2023-12-27 21:02:07 -08:00
committed by Facebook GitHub Bot
parent d992abc56d
commit b507e11867
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/turbomodule/core/TurboModuleManager.java
+1 -5
View File
@@ -15,7 +15,6 @@ import com.facebook.infer.annotation.Assertions;
import com.facebook.jni.HybridData;
import com.facebook.proguard.annotations.DoNotStrip;
import com.facebook.react.bridge.CxxModuleWrapper;
import com.facebook.react.bridge.JSIModule;
import com.facebook.react.bridge.NativeModule;
import com.facebook.react.bridge.ReactNoCrashSoftException;
import com.facebook.react.bridge.ReactSoftExceptionLogger;
@@ -35,7 +34,7 @@ import java.util.Map;
* has a C++ counterpart This class installs the JSI bindings. It also implements the method to get
* a Java module, that the C++ counterpart calls.
*/
public class TurboModuleManager implements JSIModule, TurboModuleRegistry {
public class TurboModuleManager implements TurboModuleRegistry {
private final List<String> mEagerInitModuleNames;
private final ModuleProvider mTurboModuleProvider;
private final ModuleProvider mLegacyModuleProvider;
@@ -432,9 +431,6 @@ public class TurboModuleManager implements JSIModule, TurboModuleRegistry {
private native void installJSIBindings(
boolean shouldCreateLegacyModules, boolean enableSyncVoidMethods);
@Override
public void initialize() {}
@Override
public void invalidate() {
/*