From b507e118678d5851555f664585bb239f6dcd6022 Mon Sep 17 00:00:00 2001 From: Arushi Kesarwani Date: Wed, 27 Dec 2023 21:02:07 -0800 Subject: [PATCH] Make TurboModuleManager not implement JSIModule (#42060) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/42060 For removal of JSIModule getting rid of the inheritance relationship b/w interfaces TurboModuleManager & JSIModule by directly defining `invalidate()`. `initialize()` here isn't being used hence not defining it. Changelog: [Internal] internal Reviewed By: philIip, mdvacca Differential Revision: D49977957 fbshipit-source-id: 8de644b1f344d8ce8d4a78655556829f860a2b10 --- .../react/internal/turbomodule/core/TurboModuleManager.java | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/turbomodule/core/TurboModuleManager.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/turbomodule/core/TurboModuleManager.java index 74efb5c2c48..81887fd80ca 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/turbomodule/core/TurboModuleManager.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/turbomodule/core/TurboModuleManager.java @@ -15,7 +15,6 @@ import com.facebook.infer.annotation.Assertions; import com.facebook.jni.HybridData; import com.facebook.proguard.annotations.DoNotStrip; import com.facebook.react.bridge.CxxModuleWrapper; -import com.facebook.react.bridge.JSIModule; import com.facebook.react.bridge.NativeModule; import com.facebook.react.bridge.ReactNoCrashSoftException; import com.facebook.react.bridge.ReactSoftExceptionLogger; @@ -35,7 +34,7 @@ import java.util.Map; * has a C++ counterpart This class installs the JSI bindings. It also implements the method to get * a Java module, that the C++ counterpart calls. */ -public class TurboModuleManager implements JSIModule, TurboModuleRegistry { +public class TurboModuleManager implements TurboModuleRegistry { private final List mEagerInitModuleNames; private final ModuleProvider mTurboModuleProvider; private final ModuleProvider mLegacyModuleProvider; @@ -432,9 +431,6 @@ public class TurboModuleManager implements JSIModule, TurboModuleRegistry { private native void installJSIBindings( boolean shouldCreateLegacyModules, boolean enableSyncVoidMethods); - @Override - public void initialize() {} - @Override public void invalidate() { /*