From ab3a2f4ad91c443273fffc74bcef47454e00e60b Mon Sep 17 00:00:00 2001
From: Nicola Corti <ncor@meta.com>
Date: Wed, 3 May 2023 08:33:20 -0700
Subject: [PATCH] Disable flaky windows test for
 ReactFabricPublicInstance-test.js (#37216)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37216

Yet another windows flaky test for ReactFabricPublicInstance-test.js which I'm disabling now. It will still run on linux/mac.

Changelog:
[Internal] [Changed] - Disable flaky windows test for ReactFabricPublicInstance-test.js

Reviewed By: cipolleschi

Differential Revision: D45521018

fbshipit-source-id: b37c00d674997e14fd8e12c3f3746f51bcc90669
---
 .../ReactFabricPublicInstance-test.js         | 39 ++++++++++---------
 1 file changed, 21 insertions(+), 18 deletions(-)

diff --git a/packages/react-native/Libraries/ReactNative/ReactFabricPublicInstance/__tests__/ReactFabricPublicInstance-test.js b/packages/react-native/Libraries/ReactNative/ReactFabricPublicInstance/__tests__/ReactFabricPublicInstance-test.js
index a9684999cc8..5b4ae92fb7e 100644
--- a/packages/react-native/Libraries/ReactNative/ReactFabricPublicInstance/__tests__/ReactFabricPublicInstance-test.js
+++ b/packages/react-native/Libraries/ReactNative/ReactFabricPublicInstance/__tests__/ReactFabricPublicInstance-test.js
@@ -215,7 +215,7 @@ async function mockRenderKeys(
     });
 
     describe('measureLayout', () => {
-      test('component.measureLayout(component, ...) invokes callback', async () => {
+      it('component.measureLayout(component, ...) invokes callback', async () => {
         const result = await mockRenderKeys([['foo', 'bar']]);
         const fooRef = nullthrows(result?.[0]?.[0]);
         const barRef = nullthrows(result?.[0]?.[1]);
@@ -230,7 +230,7 @@ async function mockRenderKeys(
         expect(successCallback.mock.calls).toEqual([[1, 1, 100, 100]]);
       });
 
-      test('unmounted.measureLayout(component, ...) does nothing', async () => {
+      it('unmounted.measureLayout(component, ...) does nothing', async () => {
         const result = await mockRenderKeys([
           ['foo', 'bar'],
           ['foo', null],
@@ -248,25 +248,28 @@ async function mockRenderKeys(
         expect(successCallback).not.toHaveBeenCalled();
       });
 
-      test('component.measureLayout(unmounted, ...) does nothing', async () => {
-        const result = await mockRenderKeys([
-          ['foo', 'bar'],
-          [null, 'bar'],
-        ]);
-        const fooRef = nullthrows(result?.[0]?.[0]);
-        const barRef = nullthrows(result?.[0]?.[1]);
+      itif(!isWindows)(
+        'component.measureLayout(unmounted, ...) does nothing',
+        async () => {
+          const result = await mockRenderKeys([
+            ['foo', 'bar'],
+            [null, 'bar'],
+          ]);
+          const fooRef = nullthrows(result?.[0]?.[0]);
+          const barRef = nullthrows(result?.[0]?.[1]);
 
-        const successCallback = jest.fn();
-        const failureCallback = jest.fn();
-        fooRef.measureLayout(barRef, successCallback, failureCallback);
+          const successCallback = jest.fn();
+          const failureCallback = jest.fn();
+          fooRef.measureLayout(barRef, successCallback, failureCallback);
 
-        expect(
-          nullthrows(FabricUIManager.getFabricUIManager()).measureLayout,
-        ).not.toHaveBeenCalled();
-        expect(successCallback).not.toHaveBeenCalled();
-      });
+          expect(
+            nullthrows(FabricUIManager.getFabricUIManager()).measureLayout,
+          ).not.toHaveBeenCalled();
+          expect(successCallback).not.toHaveBeenCalled();
+        },
+      );
 
-      test('unmounted.measureLayout(unmounted, ...) does nothing', async () => {
+      it('unmounted.measureLayout(unmounted, ...) does nothing', async () => {
         const result = await mockRenderKeys([['foo', 'bar'], null]);
         const fooRef = nullthrows(result?.[0]?.[0]);
         const barRef = nullthrows(result?.[0]?.[1]);