Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

reduce visibility of getNativeModuleIterator (#39164)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/39164

getNativeModuleIterator is not required to be public, reducing visibillity to package only

changelog: [internal] intenral

Reviewed By: arushikesarwani94

Differential Revision: D48691698

fbshipit-source-id: d319e7038b0307f1a474bdd449f3c50fd4f07f71
This commit is contained in:
David Vacca
2023-08-29 15:20:09 -07:00
committed by Facebook GitHub Bot
parent ff4e7fac6c
commit a60e880882
3 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/LazyReactPackage.java
+3 -2
View File
@@ -37,6 +37,7 @@ public abstract class LazyReactPackage implements ReactPackage {
LazyReactPackage lazyReactPackage) {
return Collections::emptyMap;
}
/**
* We return an iterable
*
@@ -44,8 +45,8 @@ public abstract class LazyReactPackage implements ReactPackage {
* @return {@link Iterable<ModuleHolder>} that contains all native modules registered for the
* context
*/
public Iterable<ModuleHolder> getNativeModuleIterator(
final ReactApplicationContext reactContext) {
/** package */
Iterable<ModuleHolder> getNativeModuleIterator(final ReactApplicationContext reactContext) {
final Map<String, ReactModuleInfo> reactModuleInfoMap =
getReactModuleInfoProvider().getReactModuleInfos();
final List<ModuleSpec> nativeModules = getNativeModules(reactContext);
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageHelper.java
+2 -1
View File
@@ -25,7 +25,8 @@ public class ReactPackageHelper {
* @param reactInstanceManager
* @return
*/
public static Iterable<ModuleHolder> getNativeModuleIterator(
/** package */
static Iterable<ModuleHolder> getNativeModuleIterator(
ReactPackage reactPackage,
ReactApplicationContext reactApplicationContext,
ReactInstanceManager reactInstanceManager) {
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/TurboReactPackage.java
+2 -2
View File
@@ -55,8 +55,8 @@ public abstract class TurboReactPackage implements ReactPackage {
* @param reactContext
* @return
*/
public Iterable<ModuleHolder> getNativeModuleIterator(
final ReactApplicationContext reactContext) {
/** package */
Iterable<ModuleHolder> getNativeModuleIterator(final ReactApplicationContext reactContext) {
final Set<Map.Entry<String, ReactModuleInfo>> entrySet =
getReactModuleInfoProvider().getReactModuleInfos().entrySet();
final Iterator<Map.Entry<String, ReactModuleInfo>> entrySetIterator = entrySet.iterator();