From a60e8808825dcce0eb606deacbc1d028febd6672 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Tue, 29 Aug 2023 15:20:09 -0700 Subject: [PATCH] reduce visibility of getNativeModuleIterator (#39164) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/39164 getNativeModuleIterator is not required to be public, reducing visibillity to package only changelog: [internal] intenral Reviewed By: arushikesarwani94 Differential Revision: D48691698 fbshipit-source-id: d319e7038b0307f1a474bdd449f3c50fd4f07f71 --- .../src/main/java/com/facebook/react/LazyReactPackage.java | 5 +++-- .../src/main/java/com/facebook/react/ReactPackageHelper.java | 3 ++- .../src/main/java/com/facebook/react/TurboReactPackage.java | 4 ++-- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/LazyReactPackage.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/LazyReactPackage.java index 84d4caa329d..570d1a2f89b 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/LazyReactPackage.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/LazyReactPackage.java @@ -37,6 +37,7 @@ public abstract class LazyReactPackage implements ReactPackage { LazyReactPackage lazyReactPackage) { return Collections::emptyMap; } + /** * We return an iterable * @@ -44,8 +45,8 @@ public abstract class LazyReactPackage implements ReactPackage { * @return {@link Iterable} that contains all native modules registered for the * context */ - public Iterable getNativeModuleIterator( - final ReactApplicationContext reactContext) { + /** package */ + Iterable getNativeModuleIterator(final ReactApplicationContext reactContext) { final Map reactModuleInfoMap = getReactModuleInfoProvider().getReactModuleInfos(); final List nativeModules = getNativeModules(reactContext); diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageHelper.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageHelper.java index f66f2171714..993dca00141 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageHelper.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageHelper.java @@ -25,7 +25,8 @@ public class ReactPackageHelper { * @param reactInstanceManager * @return */ - public static Iterable getNativeModuleIterator( + /** package */ + static Iterable getNativeModuleIterator( ReactPackage reactPackage, ReactApplicationContext reactApplicationContext, ReactInstanceManager reactInstanceManager) { diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/TurboReactPackage.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/TurboReactPackage.java index 8dc8ba5471b..88eb2357b72 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/TurboReactPackage.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/TurboReactPackage.java @@ -55,8 +55,8 @@ public abstract class TurboReactPackage implements ReactPackage { * @param reactContext * @return */ - public Iterable getNativeModuleIterator( - final ReactApplicationContext reactContext) { + /** package */ + Iterable getNativeModuleIterator(final ReactApplicationContext reactContext) { final Set> entrySet = getReactModuleInfoProvider().getReactModuleInfos().entrySet(); final Iterator> entrySetIterator = entrySet.iterator();