mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Fix binary FormData uploads on Android (#54917)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/54917 https://github.com/facebook/react-native/pull/54804 was a late pick into 0.83 following RC feedback, but was insufficiently tested. In https://github.com/facebook/react-native/issues/54881, users report failing requests attributed to this code path when performing image uploads. Functionally revert this change, as this breaks runtime behaviour. Changelog: [Internal] Changelog (0.83): [Android][Fixed] - Fix Network error that could occur for `FormData` uploads with binary data Reviewed By: vzaidman Differential Revision: D89373824 fbshipit-source-id: 9f144f075db3f9ad5df8598d0f113655466896cf
This commit is contained in:
1 parent
1ce99461ed
commit
9692e6488e
1 file changed
+2
-17
+2
-17
@@ -23,10 +23,6 @@ internal class ProgressRequestBody(
|
||||
) : RequestBody() {
|
||||
private var contentLength = 0L
|
||||
|
||||
companion object {
|
||||
private const val MAX_BODY_PREVIEW_SIZE = 1024 * 1024 // 1MB
|
||||
}
|
||||
|
||||
override fun contentType(): MediaType? {
|
||||
return requestBody.contentType()
|
||||
}
|
||||
@@ -84,18 +80,7 @@ internal class ProgressRequestBody(
|
||||
}
|
||||
|
||||
fun getBodyPreview(): String {
|
||||
return try {
|
||||
val buffer = okio.Buffer()
|
||||
requestBody.writeTo(buffer)
|
||||
val size = buffer.size()
|
||||
if (size <= MAX_BODY_PREVIEW_SIZE) {
|
||||
buffer.readUtf8()
|
||||
} else {
|
||||
buffer.readUtf8(MAX_BODY_PREVIEW_SIZE.toLong()) +
|
||||
"\n... [truncated, showing $MAX_BODY_PREVIEW_SIZE of $size bytes]"
|
||||
}
|
||||
} catch (e: Exception) {
|
||||
""
|
||||
}
|
||||
// TODO: Safely implement request body previews
|
||||
return "[Preview unavailable]"
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user